Patch Detail
Show a patch.
GET /api/patches/16648/?format=api
{ "id": 16648, "url": "https://patchwork.libcamera.org/api/patches/16648/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16648/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220715143822.672321-2-chenghaoyang@google.com>", "date": "2022-07-15T14:38:17", "name": "[libcamera-devel,v6,1/6] Allow inheritance of FrameBuffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d78749ed8f4bce5d76dcf6ebd520776e9ce97bdb", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16648/mbox/", "series": [ { "id": 3290, "url": "https://patchwork.libcamera.org/api/series/3290/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3290", "date": "2022-07-15T14:38:16", "name": "Add CrOS JEA implementation", "version": 6, "mbox": "https://patchwork.libcamera.org/series/3290/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16648/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16648/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AD14BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jul 2022 14:38:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB49863317;\n\tFri, 15 Jul 2022 16:38:33 +0200 (CEST)", "from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com\n\t[IPv6:2607:f8b0:4864:20::1031])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 336CC63314\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 16:38:31 +0200 (CEST)", "by mail-pj1-x1031.google.com with SMTP id a15so5895386pjs.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 07:38:31 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(208.158.221.35.bc.googleusercontent.com. [35.221.158.208])\n\tby smtp.gmail.com with ESMTPSA id\n\tf15-20020aa7968f000000b00528c22fbb45sm3972782pfk.141.2022.07.15.07.38.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 15 Jul 2022 07:38:28 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657895913;\n\tbh=urt/5C++X9cdIF0y+CArAknSIOV6BzGX19+GU7KvE08=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zzi3EcroRp5FjYzpoaMNN+WB5tAJoDJp7vHLm9CLVnXk4E9ZEWo4XuxN4Zl8rAFC1\n\tKU3d5FMhc9CT48v+rMUc0Dsh167T4ti1i7c72vdHT1ypOrkR8QjptHpbYaupskgbG4\n\tP7eLmxYQ0Pp6z5kuxtH/nHKopqAU+dulg/UDZwSSIBTqvFWWxChoq9fZIQibj6SK6Y\n\tDEoPyVDyfRsheJB8sU2cWrCXJXxnj+SVz3+554YSAwTA2O7BeEDtHYCZEuwZp3dPF7\n\t2UsRnP1LD50/ByLcB5toc+PyVLhJSRx3DIBvipUe23Ve4izMEfb0QU9+dBtoESw3dI\n\tPfNkZXLF/OgGQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=5IC4x1DsTIHmuTCSsPb9dfV0HTdarnfyKdb05Fd8Oy8=;\n\tb=eLxXjw4B4Ru6XPHLdjIsxF1Jb6kvB9f+k2VItrrxnteCseg4+BrDgF2sb1Rl64C02x\n\t3xd8XnOBKh+Oq4uVSRuQ3FY5TYZGQqNp19dR/HoZYJFu9IzE17rMEhNZzPdRpeA/Yy+b\n\tEz31Vsj8sDg9pftdZeEY0nDEa1XoM1KowTiGM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"eLxXjw4B\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=5IC4x1DsTIHmuTCSsPb9dfV0HTdarnfyKdb05Fd8Oy8=;\n\tb=HQT3kcIRXP549Q3RITFzpD68wF2Vo0Pe3uh+9gR76Dx1dAed9tX6v5I9yFNw77eoug\n\tfoU1JNBJscd6SZuwMMfgWRZjG0kqNY2a91wfbMGmciTec+olN83NDuM6XYrOsnr4fcpv\n\tsO6XXz2eeIgSjEzwZl16383KC0CVlaKrkoWJgIJyMpTlBAgK900qoVIyy/G6vAGHdIUM\n\tjYOFI6HYgAL0uq7w59dC8/05xWtr4SCl9BGcCd9nUcdaw2n3Rjab4KX5FyA/fKKNXZd6\n\tnQJhjyM2etSnyoRiXCDBvL9KZANLHY4JGx8sNRUQNfhdfeFIn5MllLDCG4gSFfFo2yCO\n\txUAA==", "X-Gm-Message-State": "AJIora8Sp0c18HMBth1VlQyy9uLkmliBoZ/jw4RVZfkpSOthJ/B0qItD\n\t+70JHKketah6Wmz3OZslVb1w5XBd6OObJQ==", "X-Google-Smtp-Source": "AGRyM1vp0D+l2UsNgEXEbTStzUaUUakdpftCzw9LXjvHGFILoVMHCUDhSsR03xS7BjzQ4AcUwd1G+g==", "X-Received": "by 2002:a17:90b:390a:b0:1f0:6a1a:9654 with SMTP id\n\tob10-20020a17090b390a00b001f06a1a9654mr15987290pjb.90.1657895909334; \n\tFri, 15 Jul 2022 07:38:29 -0700 (PDT)", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 15 Jul 2022 14:38:17 +0000", "Message-Id": "<20220715143822.672321-2-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.37.0.170.g444d1eabd0-goog", "In-Reply-To": "<20220715143822.672321-1-chenghaoyang@google.com>", "References": "<20220715143822.672321-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 1/6] Allow inheritance of FrameBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nTo add buffer_handle_t access in android, this patch allows inheritance\nof FrameBuffer to add a derived class in android.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/framebuffer.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 3b1118d1..e6c769b4 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -46,7 +46,7 @@ private:\n \tstd::vector<Plane> planes_;\n };\n \n-class FrameBuffer final : public Extensible\n+class FrameBuffer : public Extensible\n {\n \tLIBCAMERA_DECLARE_PRIVATE()\n \n@@ -61,6 +61,7 @@ public:\n \tFrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);\n \tFrameBuffer(std::unique_ptr<Private> d,\n \t\t const std::vector<Plane> &planes, unsigned int cookie = 0);\n+\tvirtual ~FrameBuffer() {}\n \n \tconst std::vector<Plane> &planes() const { return planes_; }\n \tRequest *request() const;\n", "prefixes": [ "libcamera-devel", "v6", "1/6" ] }