Patch Detail
Show a patch.
GET /api/patches/16646/?format=api
{ "id": 16646, "url": "https://patchwork.libcamera.org/api/patches/16646/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16646/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220715135609.54060-1-jacopo@jmondi.org>", "date": "2022-07-15T13:56:09", "name": "[libcamera-devel] libcamera: raspberry: Fix format validation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a6bcb140d543b6ec723feaf14fa92c1e94655bf3", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16646/mbox/", "series": [ { "id": 3289, "url": "https://patchwork.libcamera.org/api/series/3289/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3289", "date": "2022-07-15T13:56:09", "name": "[libcamera-devel] libcamera: raspberry: Fix format validation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3289/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16646/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16646/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0332BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jul 2022 13:56:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28FD86330E;\n\tFri, 15 Jul 2022 15:56:27 +0200 (CEST)", "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::223])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7591F6330A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 15:56:25 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 358CD6000D;\n\tFri, 15 Jul 2022 13:56:23 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657893387;\n\tbh=pBZo3GBKPCJBUIonYQH1a1k9kiTCz4NIeiZnyIvF5K0=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=yCt8zdi2sEji4DFb6Yi61r3JDDVVwAKyCfOTH/rTTJqPbK1m/cJa9rqKVJZeD8yfq\n\ton5YYJh7Pmfr1U9hdXqxskcJX/ijzFRHXRRaiKx9KhmlQIcOVatURt+rvVSW7G6KtG\n\tM/oVnSVUH3wJb+NOuG92kUDiQ2vSkBCpWBvs6DNGpK/XUlgGB5JQOdwcv/ntAZpOSZ\n\t+pdPurHCdhyA15SKRiwHMlIq7DfS/UWx4fX/5TTnRCEXfLN0/jiRRKqdYpEJx7m8nc\n\t/P2VqUKIQ/995CcNvMYaO1xKOKQskUdZEFsSW84h3/lw6x6IovC83jOAfbLyoM4O5V\n\tIKEzPNuTNUwFQ==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 15 Jul 2022 15:56:09 +0200", "Message-Id": "<20220715135609.54060-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.36.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: raspberry: Fix format\n\tvalidation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If the pixel format gets adjusted to the default NV12 format during\nvalidation, it gets currently ignored and the user-supplied format is\nused nonetheless.\n\nFix it by using the adjusted pixel format.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.36.1", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex fdc24cd530c2..8c8813038483 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -523,7 +523,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \t\t}\n\n \t\tV4L2DeviceFormat format;\n-\t\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat);\n+\t\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfgPixFmt);\n \t\tformat.size = cfg.size;\n \t\tformat.colorSpace = cfg.colorSpace;\n\n", "prefixes": [ "libcamera-devel" ] }