Patch Detail
Show a patch.
GET /api/patches/16622/?format=api
{ "id": 16622, "url": "https://patchwork.libcamera.org/api/patches/16622/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16622/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220713121534.115492-1-umang.jain@ideasonboard.com>", "date": "2022-07-13T12:15:34", "name": "[libcamera-devel,v3] utils: ipu3-pack: Provide a 10-bit bayer packing utility", "commit_ref": "9eb8211160de2e0a879cc5e0b38f50137df989ce", "pull_url": null, "state": "accepted", "archived": false, "hash": "3e7e1eb2a5a490c1d72293b8bef58efef80f4a18", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16622/mbox/", "series": [ { "id": 3281, "url": "https://patchwork.libcamera.org/api/series/3281/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3281", "date": "2022-07-13T12:15:34", "name": "[libcamera-devel,v3] utils: ipu3-pack: Provide a 10-bit bayer packing utility", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3281/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16622/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16622/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0ED44BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 13 Jul 2022 12:15:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E6E66274E;\n\tWed, 13 Jul 2022 14:15:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1434D6274E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Jul 2022 14:15:47 +0200 (CEST)", "from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:dcbd:bc88:bb0e:d3d8:8610])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B281F305;\n\tWed, 13 Jul 2022 14:15:45 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657714548;\n\tbh=GO3Krw5uwjFk7YwRH/hdssrCPN8DqXa+6iftBKPwzt0=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=HD0V6ckZEyHrpbguRVEHKAn7xZJFL0Uc61ezJqs6MTvkufbfPVaffJluKeZ6zy8Oi\n\tIjT+YFrp+hRBrpMonbDIImLwUFd5tBDv5SDks+ZNXD39JrJrNu3lzZdzl06nLDB6kf\n\tYTwzEIR5FbLokDZtTunfeDvXrDriU3zFoEeEnqgyU3QBTvKoj9y7JXELqf0hA+uK4p\n\tiYyFDpWfOIaOY48YvuY1fmrJAjqN0uWFCnmiU5efI8hsAE43QlUVB8bLhcCvmVu8Pp\n\twH2yjp0Rt2dj0qstaIrO1RhOQZ9E+X1PhRDnQkaK7lhKLuZPS66cBTCFvadHb/ggTq\n\tch42KvS7a0GSw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657714546;\n\tbh=GO3Krw5uwjFk7YwRH/hdssrCPN8DqXa+6iftBKPwzt0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=UjdtbxA6jj28QSb8yEdH95iQb3pGfour3qsHhMriRI+9zmXJAVYEMOugZTIiWj+8d\n\tCiiTnqO9dXEG2xcg0oCcXYbsdCNC2QEDnWfzCwgtKYSH04iupQF+RcZIFXHKiZP2W9\n\tcq3a2WypOAiUtg6yVx5TxybutiHFFQQT9PwC847k=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UjdtbxA6\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 13 Jul 2022 17:45:34 +0530", "Message-Id": "<20220713121534.115492-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3] utils: ipu3-pack: Provide a 10-bit\n\tbayer packing utility", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide a 10-bit bayer packing utility for the unpacked data produced\nby ipu3-unpack.\n\n\tUsage: ipu3-unpack input-file output-file\n\nThe output-file can be \"-\" to pack the data to stdout.\n\nThe output file generated by ipu3-pack can be directly fed to IMGU\nfor streaming.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges in v3:\n- Drop fflush() as stdout is per process not global\n- Use sizeof () directly for bytes to read\n- consistency of goto\n---\n utils/ipu3/ipu3-pack.c | 101 +++++++++++++++++++++++++++++++++++++++++\n utils/ipu3/meson.build | 1 +\n 2 files changed, 102 insertions(+)\n create mode 100644 utils/ipu3/ipu3-pack.c", "diff": "diff --git a/utils/ipu3/ipu3-pack.c b/utils/ipu3/ipu3-pack.c\nnew file mode 100644\nindex 00000000..decbfc6c\n--- /dev/null\n+++ b/utils/ipu3/ipu3-pack.c\n@@ -0,0 +1,101 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * ipu3-pack - Convert unpacked RAW10 Bayer data to the IPU3 packed Bayer formats\n+ *\n+ * Copyright 2022 Umang Jain <umang.jain@ideasonboard.com>\n+ */\n+#define _GNU_SOURCE\n+\n+#include <errno.h>\n+#include <fcntl.h>\n+#include <stdint.h>\n+#include <stdio.h>\n+#include <string.h>\n+#include <sys/stat.h>\n+#include <sys/types.h>\n+#include <unistd.h>\n+\n+static void usage(const char *argv0)\n+{\n+\n+\tprintf(\"Usage: %s input-file output-file\\n\", basename(argv0));\n+\tprintf(\"Convert unpacked RAW10 Bayer data to the IPU3 packed Bayer formats\\n\");\n+\tprintf(\"If the output-file '-', output data will be written to standard output\\n\");\n+}\n+\n+int main(int argc, char *argv[])\n+{\n+\tint in_fd;\n+\tint out_fd;\n+\tint ret;\n+\n+\tif (argc != 3) {\n+\t\tusage(argv[0]);\n+\t\treturn 1;\n+\t}\n+\n+\tin_fd = open(argv[1], O_RDONLY);\n+\tif (in_fd == -1) {\n+\t\tfprintf(stderr, \"Failed to open input file '%s': %s\\n\",\n+\t\t\targv[1], strerror(errno));\n+\t\treturn 1;\n+\t}\n+\n+\tif (strcmp(argv[2], \"-\") == 0) {\n+\t\tout_fd = STDOUT_FILENO;\n+\t} else {\n+\t\tout_fd = open(argv[2], O_WRONLY | O_TRUNC | O_CREAT, 0644);\n+\t\tif (out_fd == -1) {\n+\t\t\tfprintf(stderr, \"Failed to open output file '%s': %s\\n\",\n+\t\t\t\targv[2], strerror(errno));\n+\t\t\tclose(in_fd);\n+\t\t\treturn 1;\n+\t\t}\n+\t}\n+\n+\twhile (1) {\n+\t\tuint16_t in_data[25];\n+\t\tuint8_t out_data[32];\n+\t\tunsigned int i;\n+\n+\t\tret = read(in_fd, in_data, sizeof(in_data));\n+\t\tif (ret < 0) {\n+\t\t\tfprintf(stderr, \"Failed to read input data: %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\t\tgoto done;\n+\t\t}\n+\n+\t\tif ((unsigned)ret < sizeof(in_data)) {\n+\t\t\tif (ret != 0)\n+\t\t\t\tfprintf(stderr, \"%u bytes of stray data at end of input\\n\",\n+\t\t\t\t\tret);\n+\t\t\tgoto done;\n+\t\t}\n+\n+\t\tfor (i = 0; i < 30; ++i) {\n+\t\t\tunsigned int index = (i * 8) / 10;\n+\t\t\tunsigned int msb_shift = (i * 8) % 10;\n+\t\t\tunsigned int lsb_shift = 10 - msb_shift;\n+\n+\t\t\tout_data[i] = ((in_data[index] >> msb_shift) & 0xff)\n+\t\t\t\t | ((in_data[index+1] << lsb_shift) & 0xff);\n+\t\t}\n+\n+\t\tout_data[30] = (in_data[24] >> 0) & 0xff;\n+\t\tout_data[31] = (in_data[24] >> 8) & 0x03;\n+\n+\t\tret = write(out_fd, out_data, sizeof(out_data));\n+\t\tif (ret < 0) {\n+\t\t\tfprintf(stderr, \"Failed to write output data: %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\t\tgoto done;\n+\t\t}\n+\t}\n+\n+done:\n+\tclose(in_fd);\n+\tif (out_fd != STDOUT_FILENO)\n+\t\tclose(out_fd);\n+\n+\treturn ret ? 1 : 0;\n+}\ndiff --git a/utils/ipu3/meson.build b/utils/ipu3/meson.build\nindex 88049f58..c92cc658 100644\n--- a/utils/ipu3/meson.build\n+++ b/utils/ipu3/meson.build\n@@ -1,3 +1,4 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+ipu3_pack = executable('ipu3-pack', 'ipu3-pack.c')\n ipu3_unpack = executable('ipu3-unpack', 'ipu3-unpack.c')\n", "prefixes": [ "libcamera-devel", "v3" ] }