Patch Detail
Show a patch.
GET /api/patches/16590/?format=api
{ "id": 16590, "url": "https://patchwork.libcamera.org/api/patches/16590/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16590/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220711153711.36679-4-rishikeshdonadkar@gmail.com>", "date": "2022-07-11T15:37:09", "name": "[libcamera-devel,v3,3/5] gstreamer: Convert from GStreamer colorimetry to libcamera ColorSpace", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f651935d9ea5985839fa543b6f2f1ac6a919ff9b", "submitter": { "id": 118, "url": "https://patchwork.libcamera.org/api/people/118/?format=api", "name": "Rishikesh Donadkar", "email": "rishikeshdonadkar@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16590/mbox/", "series": [ { "id": 3270, "url": "https://patchwork.libcamera.org/api/series/3270/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3270", "date": "2022-07-11T15:37:06", "name": "Add colorimetry support to libcamera gstreamer element.", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3270/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16590/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16590/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8E75BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 11 Jul 2022 15:38:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BA4A6331A;\n\tMon, 11 Jul 2022 17:38:22 +0200 (CEST)", "from mail-pf1-x434.google.com (mail-pf1-x434.google.com\n\t[IPv6:2607:f8b0:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 530E462752\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 Jul 2022 17:38:21 +0200 (CEST)", "by mail-pf1-x434.google.com with SMTP id y9so5063039pff.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 Jul 2022 08:38:21 -0700 (PDT)", "from localhost.localdomain ([103.124.170.70])\n\tby smtp.googlemail.com with ESMTPSA id\n\tu18-20020a17090a891200b001ef87123615sm4891268pjn.37.2022.07.11.08.38.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 11 Jul 2022 08:38:19 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657553902;\n\tbh=a5Z1rYPGczQYT6xgZPRYsVxkVJdAn3pV2eDdAkEWDyU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XErmTx+F2CC7qVQINum/n4tCqNlnlGuRSIUxL3xkQ7Qmne5HoUj1xqE9OxmuKmc66\n\tq65/BQs0LKhxDPkzEI57dao8KDLZIcuaf87GRPtruvLpShiPm20R8Fldp0RT6rlkX+\n\tYceCYk4sK3VgoxyrSh/WYamQP+3eHlKXGA6u4X/W9Re9avw2DvNPHcr58TrPC19zKV\n\tSrUN1XEXV3VciRUckOrJ0wQ4i0e+r0NaRa18iKtFvrXZ/xOc3//eyFVxu8l1nQb3UA\n\tagXzZhLSxZfK0DpRysETW/dO35ew/Vp80WOt7spR1wGis40JorQzpr2wdeTOyCTERq\n\tXf2rYdNxceOzQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=a7p2TIqTwzVE60rzD3Z9ONOdYkhJcRYhYYnscTnx/hg=;\n\tb=WlcH/H0iUKJHQ4s0AlZ3sxPTG7NW7ZciDgWpd/TmgeJTRiMeKImPTYgjaWci6vLoAM\n\toKOdZnhLtLY0XOI4c1L1KuIdky/S2Z6cD/do9Hal2ctuttJSZ11dQiWhYaR8NaacsVGU\n\tCNZ+5yZsAdXRZBJArZ/NrWmpG+0JYD0PRvPUltIF3CnK9W3JnukQg7VRzAxs9ismdbn4\n\tCbWJ8CqFxAVQI2LpNORdtC5NyenibI35Pz+N9P1LxFr496khEzip5Pwl6KsEYG11N/9I\n\t0fdyqJhJVzona5oM3rWREuwOHVSUDEEJC9+BKTfM9VAFg4b+WY8Nb+s9kcMcDi8QM+iF\n\tOunw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WlcH/H0i\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=a7p2TIqTwzVE60rzD3Z9ONOdYkhJcRYhYYnscTnx/hg=;\n\tb=nv4oGK1HutyI/QXpP+I8iOtWdejmaxRY1yDZU57HwXVGrxKX/9zabJoOm1hQB2PvVh\n\tvxSNdIs8Oo6zbGX5NJCpGsBvI0PL/793x8kCAEJxf5WUm1+C4kmBEOMYRKd8h23d2EXz\n\tpJCH1FHsJPeOegaEx3EEHxSyZRBcpYsgP2wIhQCimVR5OUWIik80AcyboXzeuOs8kS18\n\tN3nWBqdS4x54ibDS+C8MaxV+lLMVB+G18e1/Dwrc0pTF1jx4dZvdR00hG4IiXDIXhCOz\n\teiMYvYAsTKq5CY3WuYn11dVbRUf7U3EtvBfe7f9p0CsX1RMkLCbFXJY0w7CfhrwWQT5Q\n\tFytA==", "X-Gm-Message-State": "AJIora9Wvbl7rS2nmRlLeNtARnGQGCBOJZtE59JejR+DSYgMFN1drWQO\n\t4Y/gWRpT/OywdHZIFWOd7zVGcIenAVs=", "X-Google-Smtp-Source": "AGRyM1v1GHZXFKFFjgOZX/Z62qAKhXAs1XzG/87E6R7i0inlz1z7Q6nG+MSWlAxwjKldtWy445/Fxw==", "X-Received": "by 2002:a63:f809:0:b0:415:f224:2f61 with SMTP id\n\tn9-20020a63f809000000b00415f2242f61mr6927969pgh.577.1657553899748; \n\tMon, 11 Jul 2022 08:38:19 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 11 Jul 2022 21:07:09 +0530", "Message-Id": "<20220711153711.36679-4-rishikeshdonadkar@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220711153711.36679-1-rishikeshdonadkar@gmail.com>", "References": "<20220711153711.36679-1-rishikeshdonadkar@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 3/5] gstreamer: Convert from GStreamer\n\tcolorimetry to libcamera ColorSpace", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Rishikesh Donadkar via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>", "Cc": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add map colorimetryToColorSpace that maps the GStreamer colorimetry to\nlibcamera ColorSpace and the function colorspace_from_colorimetry()\nto convert from gstreamer colorimetry to libcamera colorspace using the map.\nThe obtained colorspace form the conversion will be applied to the\ncolorSpace field of the StreamConfiguration.\n\nSigned-off-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex a2d9b64d..5b3bfd70 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -51,6 +51,12 @@ static const std::vector<std::pair<ColorSpace, std::string>> ColorSpaceToColorim\n \t{ ColorSpace::Rec2020, GST_VIDEO_COLORIMETRY_BT2020 },\n };\n \n+static const std::map<std::string, ColorSpace> colorimetryToColorSpace = {\n+\t{ GST_VIDEO_COLORIMETRY_SRGB, ColorSpace::Srgb },\n+\t{ GST_VIDEO_COLORIMETRY_BT709, ColorSpace::Rec709 },\n+\t{ GST_VIDEO_COLORIMETRY_BT2020, ColorSpace::Rec2020 },\n+};\n+\n static GstVideoFormat\n pixel_format_to_gst_format(const PixelFormat &format)\n {\n@@ -117,6 +123,18 @@ colorimetry_from_colorspace(ColorSpace colorSpace)\n \treturn colorimetry_gst_string;\n }\n \n+static std::optional<ColorSpace>\n+colorspace_from_colorimetry(const gchar *colorimetry)\n+{\n+\tstd::optional<ColorSpace> colorSpace;\n+\tauto iterColorSpace = colorimetryToColorSpace.find(colorimetry);\n+\tif (iterColorSpace != colorimetryToColorSpace.end()) {\n+\t\tcolorSpace = iterColorSpace->second;\n+\t}\n+\n+\treturn colorSpace;\n+}\n+\n GstCaps *\n gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n {\n", "prefixes": [ "libcamera-devel", "v3", "3/5" ] }