Patch Detail
Show a patch.
GET /api/patches/16570/?format=api
{ "id": 16570, "url": "https://patchwork.libcamera.org/api/patches/16570/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16570/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220707094402.28730-5-rishikeshdonadkar@gmail.com>", "date": "2022-07-07T09:44:02", "name": "[libcamera-devel,v2,4/4] gstreamer: Configure the colorSpace in the Stream configuration.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8ccd35e99aadfb1078de37da1574ee7f652e4a53", "submitter": { "id": 118, "url": "https://patchwork.libcamera.org/api/people/118/?format=api", "name": "Rishikesh Donadkar", "email": "rishikeshdonadkar@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16570/mbox/", "series": [ { "id": 3263, "url": "https://patchwork.libcamera.org/api/series/3263/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3263", "date": "2022-07-07T09:43:58", "name": "Add colorimetry support to libcamera gstreamer element.", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3263/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16570/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16570/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D3CDBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Jul 2022 09:45:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38F086331B;\n\tThu, 7 Jul 2022 11:45:21 +0200 (CEST)", "from mail-pg1-x535.google.com (mail-pg1-x535.google.com\n\t[IPv6:2607:f8b0:4864:20::535])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCA6B60401\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Jul 2022 11:45:19 +0200 (CEST)", "by mail-pg1-x535.google.com with SMTP id 145so17474144pga.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 07 Jul 2022 02:45:19 -0700 (PDT)", "from localhost.localdomain\n\t([2402:8100:30ae:d446:13ee:d079:112a:ac10])\n\tby smtp.googlemail.com with ESMTPSA id\n\tp2-20020a1709027ec200b00168f08d0d12sm24530712plb.89.2022.07.07.02.45.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 07 Jul 2022 02:45:18 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657187121;\n\tbh=vwLNOOd8KqMTxpbDa0Qo8PIPOBBLsA9MbL8bOUFd5bc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=c7+X+akrMYm83DdfQvfR9dn/ZztTjphxI4gWcUTnS1+zvoDD6Cq+PhSiDPJEeKZ+k\n\thKOZcEJVO5ys8MCpEEhH4OyPVbpKC1DQz1bxM1+ZfyWOR5pyHsLI08LCN9tLu0X0Sx\n\ti8iMIR8WHZdQN1vfy4e/XNsNAU4HsbZnNZOqLZouDdVDSvwllEy/BVjyziboZ3grPt\n\tj4+K+pXCwm3Dx5+WVcOtcF/Q0BJqk3xv2Da7yipj/EFAbvfsJdu9Ybe/VJETbv0C8T\n\t0GiZHKqth+u6BYeyqfvLV5IP19hJV7qq9Qgri3dUwX7qjB85y0QsX29/E6kd9Ute2O\n\tnCaDnEq3kwzaA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=3iRgLuDezP4t290LfGG98rmzMB3RzYpumLdoyBdEnyM=;\n\tb=XbS8N8r46T2BCZQ2JwwgZFyGs/pbKqO3Vaoh+/YlxDmSxgdmYpNytmTLgUCIo5tQgn\n\tGs3YLIrUQI3ca7KNdF/LZjppHfkU/qj7zBDpPDaUE63+4DGo0ga2oV5IJH6lOsNf5hC8\n\tE1mLg4BwEG3VfIUt9COSyi5O6iY8fjCf+am8f20oQVt8BP8isaVFB4fTGKQ7xWlvMaQO\n\tOYteGB9OMyzuO1hO9nJLqWdA9n1K3iw+H6KlkS2yrfjjFQfHZyWFtfIQrkvgi02rMgnZ\n\t7Adb3gYjBfHXEP8wjS6A/OlvB75yF435Lq0lCxxpWZJwlepcqLzWMb4ughb1GidwApco\n\tt7Lg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XbS8N8r4\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=3iRgLuDezP4t290LfGG98rmzMB3RzYpumLdoyBdEnyM=;\n\tb=joe3RT11fO5IrBreNxDB3a+WQyCII6VMToblop0I9Ts6GQgXuY0aTDAlhB1eGPbjZ9\n\tWSW75SoXEYu9gGeuHRnPDLjUfqNLOsFV0uayiRRdeMncvDrvJp/8ilFcQvgOXlKH763O\n\tN5sHUWPkBW/By/3YMfHA7XrvQW87Lvdv1yRs+2gvBjabJMmvxso8rENIuiSM5E9Wq4fA\n\tQax1Eb9Oyd2Z+ibPp1NQwSMwTBGhRC/SwIWnXkesFY30wLGpqOVMtdZC4mkYSlCuDea8\n\tuxLwafsYJ2GGUmHD6x/A7EjPfcsJpSkZHRvrPpFoNYEpdontZ8T4IPOCH+/QhsDjTV8+\n\tI22g==", "X-Gm-Message-State": "AJIora/n1qpb6PEB3/PHhyVLnCfznmAzqwns4Bccr7K9f/nX46Me4Nyn\n\t4F6IGrPaQsd4OsJTUxTIIMUUi39KJvs=", "X-Google-Smtp-Source": "AGRyM1v93LrDd18u1VziFU5zxhVjk82rfLiKx2+fmip/DGGCJFmGycTghD2L1DP+QkU4Kqer1H56Nw==", "X-Received": "by 2002:a17:90b:3e8a:b0:1ef:6a5e:e55a with SMTP id\n\trj10-20020a17090b3e8a00b001ef6a5ee55amr4246968pjb.112.1657187118229; \n\tThu, 07 Jul 2022 02:45:18 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 7 Jul 2022 15:14:02 +0530", "Message-Id": "<20220707094402.28730-5-rishikeshdonadkar@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220707094402.28730-1-rishikeshdonadkar@gmail.com>", "References": "<20220707094402.28730-1-rishikeshdonadkar@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/4] gstreamer: Configure the\n\tcolorSpace in the Stream configuration.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Rishikesh Donadkar via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>", "Cc": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Get the colorimetry if requested in the gstreamer pipeline and pass\nthat to the function colorspace_form_colorimetry() which will set\nthe colorspace corresponding to the requested colorimetry in the\nstream configuration.\n\nSigned-off-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex feefead9..229a29cd 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -279,6 +279,13 @@ gst_libcamera_configure_stream_from_caps(StreamConfiguration &stream_cfg,\n \t\tg_critical(\"Unsupported media type: %s\", gst_structure_get_name(s));\n \t}\n \n+\t/* Configure colorSpace */\n+\tif (gst_structure_has_field(s, \"colorimetry\")) {\n+\t\tconst gchar *colorimetry = gst_structure_get_string(s, \"colorimetry\");\n+\t\tstd::optional<ColorSpace> &colorSpace = stream_cfg.colorSpace;\n+\t\tcolorspace_form_colorimetry(colorSpace, colorimetry);\n+\t}\n+\n \tgint width, height;\n \tgst_structure_get_int(s, \"width\", &width);\n \tgst_structure_get_int(s, \"height\", &height);\n", "prefixes": [ "libcamera-devel", "v2", "4/4" ] }