Patch Detail
Show a patch.
GET /api/patches/16565/?format=api
{ "id": 16565, "url": "https://patchwork.libcamera.org/api/patches/16565/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16565/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220706191016.2842476-1-eschwartz93@gmail.com>", "date": "2022-07-06T19:10:16", "name": "[libcamera-devel] meson: correctly pass the global include to the compiler", "commit_ref": "ba6435930f08e802cffc688d90f156a8959a0f86", "pull_url": null, "state": "accepted", "archived": false, "hash": "11578a27d3e65508caae12e83fdc15120319d5b4", "submitter": { "id": 129, "url": "https://patchwork.libcamera.org/api/people/129/?format=api", "name": "Eli Schwartz", "email": "eschwartz93@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16565/mbox/", "series": [ { "id": 3262, "url": "https://patchwork.libcamera.org/api/series/3262/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3262", "date": "2022-07-06T19:10:16", "name": "[libcamera-devel] meson: correctly pass the global include to the compiler", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3262/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16565/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16565/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AF05BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Jul 2022 19:17:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87A116330C;\n\tWed, 6 Jul 2022 21:17:50 +0200 (CEST)", "from mail-io1-xd29.google.com (mail-io1-xd29.google.com\n\t[IPv6:2607:f8b0:4864:20::d29])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 098B460403\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Jul 2022 21:10:20 +0200 (CEST)", "by mail-io1-xd29.google.com with SMTP id z191so14870260iof.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 06 Jul 2022 12:10:19 -0700 (PDT)", "from didactylos.localdomain\n\t([2600:1700:57f0:ca20:763a:c795:fcf6:91ea])\n\tby smtp.gmail.com with ESMTPSA id\n\tl8-20020a927008000000b002dc318249f1sm1225737ilc.0.2022.07.06.12.10.17\n\tfor <libcamera-devel@lists.libcamera.org>\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 06 Jul 2022 12:10:17 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657135070;\n\tbh=Q/zFsRfGkuUKGh11y30odHNLM6VqyRorM4eyJJW1Kpk=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=IF8ZNwwykTkLpQP6Zmzm1WaVIWVuKQOczZW2uemUyfZ2/xlsMLYL4fhLmb+LpbCCa\n\teDVvaiDuUjpgxTxbspeOlDs1SrPrHpEzt1gCHzKskCwHDXSD4o+B2/pF9td/yg06j5\n\tDMIjjTTGbVzBwv4gP5VpHx/3D7i+Fb1aBeuXXDY8/oPYugUCSan6fHZy4xjBlGqsH5\n\t+zQfNREwo8aT6IARoBnZoKNwTadU0Krf20KzKeOMq5D+y25J3NVilmhzJk3c1ESqEQ\n\tx5X9jMkN+yv0X5y6/xYAO8SgCHc/4jtYcGY4pb+zU/WsrTtwflPMNaHYlIJfvKiGgg\n\tizA2+oJ8oewow==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=8jpeBeigHBb+erL4vCrkWZn8XgyoUybYCAu4K6Gmqi0=;\n\tb=Q2mir/5/cEF8XgSNL023XIBTLT1pTs8GEsCNIK2W+T8fAsKsLF+39dCwstngAthRFj\n\tkoID9fgvg2BwPQm9wVA9RH44wf8X7ktMlDFScByL75ZhYlSet+0m7pNlDM7I79V4QEDm\n\tsFWJqY9GxToyXftU8HqkLfXWAGZXipqtr/YOD05zoNrh0y+QPGishHLKPHO5SOkNedCA\n\tMIbzYuE1/H079nH1ZLsHsAmkHYdUOwyWoug1wAi2Uj3qUEOl5JMeAiBeBRB50XTN8AE+\n\tWVd8iwIPlKvzuzS85D/mnMz5VodZpg8lQFOcOJr8aXGxgsSu0itX+mQpkG3b9ft50v8Z\n\tBbjA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Q2mir/5/\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=8jpeBeigHBb+erL4vCrkWZn8XgyoUybYCAu4K6Gmqi0=;\n\tb=kn4SnxjhgsauE5F10g4D7XNGWNjVhuWiR8ZSwWR9yIT8gtXg6sTg2VCYbVJEtZzqMV\n\tojzS04iK9m9nuvWZcIdjhzXEmbEM/hr0JAuWFdUJR1/KhIYTDp/9VnAgWl0Ov1xCMwoJ\n\tvJZdtS396Cy4V1hgxJgjSbMq8J36Krcu3jdoV6Rjd30BtDHp2kkFJb64hGtKrorwbY+G\n\tfjjIdzga0PnQ/nSzkfcFPqVoYoTovk2x9mlukFMTfsOe2MWTCeeIWHNhJkUukurh1rzt\n\tlfxwEo72L9CA6splGS6jXOfDzTS11LsvMs6jEi0nzYX5j1XERF8m5OY5KUrOVmp2ZC+x\n\tZNnw==", "X-Gm-Message-State": "AJIora+IT0aRzfDpgEttoH2z380iBnIRo/lGFZvuPeDmkU+a6i4uoqOi\n\tGl7BU0oXT+aOFxcYyRdkGJuBtxxvE+Pn2nYZ", "X-Google-Smtp-Source": "AGRyM1taZpaS3bXU1YNA4/sHE82BEXISJ2B25LXQEjDXRROJ+ukeKz9skA/FBXxs4W0tUViXkBV/Ew==", "X-Received": "by 2002:a5e:a506:0:b0:66a:2cdc:e6f7 with SMTP id\n\t6-20020a5ea506000000b0066a2cdce6f7mr22855519iog.113.1657134618227; \n\tWed, 06 Jul 2022 12:10:18 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Jul 2022 15:10:16 -0400", "Message-Id": "<20220706191016.2842476-1-eschwartz93@gmail.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 06 Jul 2022 21:17:49 +0200", "Subject": "[libcamera-devel] [PATCH] meson: correctly pass the global include\n\tto the compiler", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Eli Schwartz via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Eli Schwartz <eschwartz93@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It's not safe to assume `-include config.h` works, since this depends on\nthe functionality of the compiler that the cwd when running the compiler\nis searched first.\n\nWhen libcamera is included as a Meson subproject, the cwd of the\ncompiler is the cwd of the main project, not of libcamera's build dir,\nand thus cannot be found. Instead, pass the include filename as a path\nbased on the current build dir.\n\nSigned-off-by: Eli Schwartz <eschwartz93@gmail.com>\n---\n meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 6d7d3ca6..3f7a3f56 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -44,7 +44,7 @@ endif\n \n common_arguments = [\n '-Wshadow',\n- '-include', 'config.h',\n+ '-include', meson.current_build_dir() / 'config.h',\n ]\n \n c_arguments = []\n", "prefixes": [ "libcamera-devel" ] }