Patch Detail
Show a patch.
GET /api/patches/16554/?format=api
{ "id": 16554, "url": "https://patchwork.libcamera.org/api/patches/16554/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16554/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220706080030.30929-2-rishikeshdonadkar@gmail.com>", "date": "2022-07-06T08:00:30", "name": "[libcamera-devel,v2,2/5] gstreamer: Update the obtained colorimetry in caps.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "38a7fc8130a3f04338fc316dcb4880a3ef03467b", "submitter": { "id": 118, "url": "https://patchwork.libcamera.org/api/people/118/?format=api", "name": "Rishikesh Donadkar", "email": "rishikeshdonadkar@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16554/mbox/", "series": [ { "id": 3257, "url": "https://patchwork.libcamera.org/api/series/3257/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3257", "date": "2022-07-06T08:00:29", "name": "[libcamera-devel,v2,1/5] gstreamer: convert from libcamera colorspace to GStreamer colorimetry.", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3257/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16554/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16554/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C789FBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Jul 2022 08:01:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93B9363313;\n\tWed, 6 Jul 2022 10:01:10 +0200 (CEST)", "from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com\n\t[IPv6:2607:f8b0:4864:20::52b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A75A60400\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Jul 2022 10:01:09 +0200 (CEST)", "by mail-pg1-x52b.google.com with SMTP id bf13so357657pgb.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 06 Jul 2022 01:01:09 -0700 (PDT)", "from localhost.localdomain ([103.124.170.117])\n\tby smtp.googlemail.com with ESMTPSA id\n\tb16-20020a170903229000b001696751796asm25013049plh.139.2022.07.06.01.01.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 06 Jul 2022 01:01:07 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657094470;\n\tbh=urL573M7ZJB65es0bfiX8bMi9EWtxAR4MosajrRkJg0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3fH+bwpFXGwoHxw+lW9OKGlM9oHyJg45C6y1sy/JDkCD03kQwbHfR0KoRDtoASAoU\n\topCYFeLp0c0xso1VQMe5/DNRYGPpmVy5fkZVhcvZJEyIXjW/aMzpwWtph3w7Nbjs4P\n\tpIg3fOK656Q6T7cOJ8AJQCcBBszNn9b7lvV/dpkU/hKkVis7Hv6qyJZ79826ti/YZV\n\tuiJRUYrcKemubw0oBxkkI/vZ3fI+/BHLqIIdpWNKxzEefbd54hga5gaNqbrN00nFP1\n\tFH3kHbZ2e3tYxcuHlURL3sWIdgnkRPzde238x5Mp+S+Ocwy3HjN4mKDXQCDTN0mwVJ\n\t9avi+2uZ3KDDA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=OGXpw4fZPKOP+bWSilv5kaumz+JHKfmnJqHFwEvTFys=;\n\tb=Wc/bHTPuTRS4mLtBB/4ON9OwaZ/7q/yWMWO35dmuPGmbe1N3bnaBVBjkKvrzPoJ5x3\n\tFha3tfW8n/dOGbI1LGadVCs0rUS9c6VGbMdDRdD0ya0hLz6pNncu0p6Ex94L/Hv+UZrn\n\trG8erzf8cjbdzFuJ9WAKBwtlWGpwkeTygCZCn7gR3P3yiCsEVyonNiTFG5n5S6IXKVwt\n\td2c6T2Y839tIA8vzvMiLGyHGEQ9JOE1AUvG1akXb2HdS+LpfQq0Tj3eTOtTDX+eY5zgd\n\tQKsDrgO/g1bTAU/VQNGmE5wsnc9AWRQ/WwGHgdXGTBnzVlojPmGtnxVRrG9j345GReJi\n\tdatQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Wc/bHTPu\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=OGXpw4fZPKOP+bWSilv5kaumz+JHKfmnJqHFwEvTFys=;\n\tb=Tqz5+WZXnCtKUzw/ghykZfBx5cOlXM2XJ4Yz0d98fT/YL2m2N6sqZFWvnpfBkwWxNP\n\tpnL5dMOZlaicXRMRDf4dinNtx1XlwL/Vh6nhBS+bbp9JMMAI7m4zQrKyZSfte/wrKg4p\n\tEM/B5DJPqJofVdmSqL8z6MtKrn8n8lTWOVWxKAkzLE4kdAEbJk6FkvGfqhg8phWSH5uh\n\thsMb3d7QpDoh2GXDqnbpoyiuovpQYTAVhHiGXzEQmt0lFCHmaPjxm7FCM6k0s/vrcZHL\n\tmonfMNLDYFyQHN93/IFkgFPBqe+GJvLwT6POas4xt5DyiihvBSL4p8hrjOZD1jL58DUn\n\ty5pA==", "X-Gm-Message-State": "AJIora8ESoT3yT0SSZqoYeCcvya8/A3w/TwWTUa86fAcKvFIsNHbrVFD\n\thxPquQCwEdW3oS0NoFvN9STK2Hh1s7Y=", "X-Google-Smtp-Source": "AGRyM1v6goG8wCq1TDXoBSfdg3gcwPIO4jVkmFYvSw4JUEkCMlauibo037PwHYKixHM7eJPgMQHJUw==", "X-Received": "by 2002:a63:f256:0:b0:40d:5509:2126 with SMTP id\n\td22-20020a63f256000000b0040d55092126mr32435147pgk.566.1657094467631; \n\tWed, 06 Jul 2022 01:01:07 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Jul 2022 13:30:30 +0530", "Message-Id": "<20220706080030.30929-2-rishikeshdonadkar@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220706080030.30929-1-rishikeshdonadkar@gmail.com>", "References": "<20220706080030.30929-1-rishikeshdonadkar@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/5] gstreamer: Update the obtained\n\tcolorimetry in caps.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Rishikesh Donadkar via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>", "Cc": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If the colorspace is set in the StreamConfiguration, get the colorimetry as\na result of conversion from the previous patch and update it into the caps.\n\nSigned-off-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 60ac8c8e..c155dd0c 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -166,11 +166,23 @@ gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg\n {\n \tGstCaps *caps = gst_caps_new_empty();\n \tGstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat);\n+\tgchar *colorimetry = nullptr;\n+\tstd::optional<ColorSpace> colorspace = stream_cfg.colorSpace;\n \n \tgst_structure_set(s,\n \t\t\t \"width\", G_TYPE_INT, stream_cfg.size.width,\n \t\t\t \"height\", G_TYPE_INT, stream_cfg.size.height,\n \t\t\t nullptr);\n+\n+\tif (colorspace) {\n+\t\tcolorimetry = colorimerty_from_colorspace(colorspace);\n+\t\tif (colorimetry)\n+\t\t\tgst_structure_set(s,\n+\t\t\t \"colorimetry\", G_TYPE_STRING, colorimetry, nullptr);\n+\t} else {\n+\t\tg_free(colorimetry);\n+\t}\n+\n \tgst_caps_append_structure(caps, s);\n \n \treturn caps;\n", "prefixes": [ "libcamera-devel", "v2", "2/5" ] }