Patch Detail
Show a patch.
GET /api/patches/16545/?format=api
{ "id": 16545, "url": "https://patchwork.libcamera.org/api/patches/16545/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16545/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220705134100.26713-1-naush@raspberrypi.com>", "date": "2022-07-05T13:41:00", "name": "[libcamera-devel,v1] pipeline: raspberrypi: Fix incorrect advertising of ScalerCrop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "53a3ba469750484a1152a9ffa20d8ac7b62aa6c4", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16545/mbox/", "series": [ { "id": 3252, "url": "https://patchwork.libcamera.org/api/series/3252/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3252", "date": "2022-07-05T13:41:00", "name": "[libcamera-devel,v1] pipeline: raspberrypi: Fix incorrect advertising of ScalerCrop", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3252/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16545/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16545/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9ACBBBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 5 Jul 2022 13:41:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 102A86330C;\n\tTue, 5 Jul 2022 15:41:15 +0200 (CEST)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C56E61FB0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Jul 2022 15:41:12 +0200 (CEST)", "by mail-wr1-x436.google.com with SMTP id v16so6183738wrd.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 05 Jul 2022 06:41:12 -0700 (PDT)", "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t12-20020a05600c020c00b003a04b0bcb43sm22187192wmi.40.2022.07.05.06.41.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 05 Jul 2022 06:41:11 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657028475;\n\tbh=vmqd/2NC13QnZsEiQxdnT++vlTNJvAKRGOFaYlam2CA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=kDtndGVXh/0E6Yz/P/oBoWiaDqVvhHIJOGueR1MAyuyzlyGkK4oRjtb7a4actdB4k\n\t/kwvVnzKFo8biycz332fbMdQutIVCLa4uGUryBEQdNIfQ/p9FXc9hycu+lUXB2zEqe\n\tBa0bw8rgevmJNOdNVGyxCFzL1DD4pDLozf0wgJbsr3Z43eCIIorJjGE5ueTtnW3vvq\n\tw7XckM1IbamAuO7qRkpx0Fwre6GHloKRhYM9okUNBIUDW7NFlKhATOrEmCRI+Ijpc+\n\tLRWBkfe7XShXxehXi+c8hA2tUCpqCIcWMM0TPqYmHeyjW5ZoT50mw7BKmh43brqTSi\n\tkvC8d+eMVWqyg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=mVYAiQtwB6M20uPMaz67xmVS72EN2vGvZctzvZROwvg=;\n\tb=UHRzKdR0H8cVtqyJHJfIyNlz/mw/8E1pBPkynGWmYIVKdJIvpusE8djdRngrr46bZj\n\tBixBn04Qu6bUDqjFs3OFQs5cMrhbMMlTiLybqQIb/ZfwdK6jMMokE0z34LvSr2f/9u9I\n\tAvJ+xn1taxuU+IYq6ksumgoi2OQKa7GXCmWdG0Ngyso7bG4pbBfNxwVP99dwsnwDq9Xf\n\tXSUAIz1Els/WiOU+80z3RToIx8NDkMcx4l7x7oEKvZN8enBKIojBqQwnEQe/rFCsc5EQ\n\tihnc/f2v8drBOkEv+hqWQ9brSvoxFeCIz644yRQK4IhdDcU83nwDFP/+YAFwgW842Tpd\n\td2BQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"UHRzKdR0\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=mVYAiQtwB6M20uPMaz67xmVS72EN2vGvZctzvZROwvg=;\n\tb=crVq9jz1mc4EDXKHpKHxKRkRsp/ROvH95Kb+j6mMtEbnunLnnPlHZQO7ybgl2HfqWa\n\ts+Uk8IRIv4fJoHp+RHDmiKsNMoVb2C7zNzSerbPcXAefS9I3aCiDm4gXl+eplSA6hecI\n\tqVHK4E4jKY4AJX1Wcas5JUhfy0YZkI3RNt/EcVoURWiZ96/d5d+f+5xxEwwTN+MPMmBf\n\tRDAq710pUL/DbuPxXJC7vTUCW/F47KSugi+QNNG0kq3QvX45voZU6JOTvW83GFvwtmyt\n\thGc+K8sRspRo18ix39cNcmErlc+sTC7kmEUA3GHup3h8dF0eTKyeGDkRvnGWWLD7gmr8\n\t12EA==", "X-Gm-Message-State": "AJIora/Mg2dwlTktMlL7JRshfaGPt730A14OgCJ7cp6klwO98V5dJfSf\n\tGGoMhr89TAyQujkmbaV9nz4JTqJMvPG21yDj", "X-Google-Smtp-Source": "AGRyM1u92ndNwW1gyzqvJan3VjX9KaaqlU5XaIF1hCJsruLDUjFXQNOVtaVf4WMFs6u9xDICwynBrg==", "X-Received": "by 2002:a5d:410d:0:b0:21d:7195:43f3 with SMTP id\n\tl13-20020a5d410d000000b0021d719543f3mr3973009wrp.456.1657028471956; \n\tTue, 05 Jul 2022 06:41:11 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 5 Jul 2022 14:41:00 +0100", "Message-Id": "<20220705134100.26713-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1] pipeline: raspberrypi: Fix incorrect\n\tadvertising of ScalerCrop", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The controls::ScalerCrop in the ControlInfoMap was advertised based on the ISP\noutput Rectangle. This is incorrect, it needs to be set based on the sensor\noutput Rectangle. Fix this.\n\nAdditionally, do not use emplace to be consistent with the other controls set\nin the ControlInfoMap.\n\nFixes: 9dacde0d651d (pipeline: raspberrypi: Advertise ScalerCrop from the pipeline handler)\nReported-by: David Plowman <david.plowman@raspberrypi.com>\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 66a84b1dfb97..d1ecc50af3b9 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -946,8 +946,8 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \t\tctrlMap.emplace(c.first, c.second);\n \n \t/* Add the ScalerCrop control limits based on the current mode. */\n-\tctrlMap.emplace(&controls::ScalerCrop,\n-\t\t\tControlInfo(Rectangle(data->ispMinCropSize_), Rectangle(data->sensorInfo_.outputSize)));\n+\tctrlMap[&controls::ScalerCrop] =\n+\t\tControlInfo(Rectangle(data->ispMinCropSize_), Rectangle(data->sensorInfo_.analogCrop.size()));\n \n \tdata->controlInfo_ = ControlInfoMap(std::move(ctrlMap), result.controlInfo.idmap());\n \n", "prefixes": [ "libcamera-devel", "v1" ] }