Patch Detail
Show a patch.
GET /api/patches/16539/?format=api
{ "id": 16539, "url": "https://patchwork.libcamera.org/api/patches/16539/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16539/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220704233217.54769-3-Rauch.Christian@gmx.de>", "date": "2022-07-04T23:32:15", "name": "[libcamera-devel,v9,2/4] libcamera: controls: Define size of array controls as a shape vector", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3b18e268fd1237c12c7964bf59403f3158744e57", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16539/mbox/", "series": [ { "id": 3250, "url": "https://patchwork.libcamera.org/api/series/3250/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3250", "date": "2022-07-04T23:32:13", "name": "generate and use fixed-sized Span Control types", "version": 9, "mbox": "https://patchwork.libcamera.org/series/3250/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16539/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16539/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6C0DBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 4 Jul 2022 23:32:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CBA263318;\n\tTue, 5 Jul 2022 01:32:37 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C3946330E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Jul 2022 01:32:34 +0200 (CEST)", "from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id\n\t1MuDc7-1nKnka2PIT-00ub2R; Tue, 05 Jul 2022 01:32:33 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656977557;\n\tbh=/16NRmqVAVwDPoEee56Lymj5hfeWnsuaNzk+/jfYIM4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=eTC4OYnqtGhahdcUaNS5pcDqIu4BE+KrBnR5T/G5WwOtve+FnEBnkgqaswe2H2gml\n\tazrQzxuCBftr9O6bJJykFv9wnbUpYyaYc4BONz6mnBo8gEb3R111qYOVZOaEIpdy8u\n\tyGQo0Sxx6ciREM04RArJt6JtVes8gpO1MbZ3yrOOinvIRsB6WR1jb+N6KVepucaan/\n\tOUmRRCt0eV7JhfhrVMGCNbSzVZ4tzMvQaGz/ylXvk8NzTkUzkXltl241nCxTg4ysq0\n\tNKdM8+4/h/KReWTezTM2TaxYR+BsrP8xLv768THQDjN7hP3+F+1t2vxUkSI5vDqEWn\n\tuL1fqaWiYdswQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1656977553;\n\tbh=/16NRmqVAVwDPoEee56Lymj5hfeWnsuaNzk+/jfYIM4=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=a1aygOr9ON1onlLPVB40B6w9/thWIS36ec9754wvCXJ15JR9CzMMQns05wYqWZnyV\n\tdti4TGuvn2iWvZCV3cq9WpVcTIh2kZr1qeYTT076+c0lL0+L68YXjFQSrrtgvzoYXr\n\tbcVVRLxe6LD5fgt8cIYUkNciV5KO9idwXY4Onkb0=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"a1aygOr9\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 5 Jul 2022 00:32:15 +0100", "Message-Id": "<20220704233217.54769-3-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220704233217.54769-1-Rauch.Christian@gmx.de>", "References": "<20220704233217.54769-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:/2oK35LtBlWFHPeYeZOs3cTRQzzu5SgZ6QNVE5eJwsLoO1CHLIY\n\tDw5EyIt9DCyEK0TLp4JfXuKKg2qk534NwHGJix/ZpGTmV+SqC4huPD8uV30kwyJ07eKhORq\n\t6YMplxoYTzCAhy+R4Yunl07HOh1Jup/0wGAhp6CuiIS4BG40tNyjii0glnSMrQUwPNeCkNm\n\tExyg7frAN8K7Xm89qcUlA==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:nv1wakTSGek=:4P4G1Oe66wajjOpP0TNs53\n\tK0QqAUzlMcUtmwsJvJ8DPPDSEQHygIxiZMAm+iZrsKKggPfmZ9Bt8fUvF0/NS9BKjqZL7OiCm\n\t6czCfik9aiIKdcsOberq0eC0HYBdHk6efL4PzxOCR2OYx9MMmdOVcvtHBmihNm7Qi2vvzVsQo\n\tV0W1uQvvOm9T0tq4DkXum2cMXnabYEVcl06gGEWMyYuGZ5pG4GnwJ4XKXwQhuHwTcxVPbfz0H\n\tnkvkWm7k1yU4xeRO2Kp6hTpua5sk8q04bAdKPG4AG725fQMAIU+tI3lIC8wdPxPCKIhiOgDtB\n\tXZATrKoF/czyaFDRKosEXmsRGHuvloDpknLbOGTsZPr14rur2fnQBxmvREJL6KDTSRfVsIvp1\n\tKgMN4ufnkJCuoN96ITK06Qxfa5vq5wpuY/kp9TZmqNH55yv8bIkDriApZ/zGVd9HYNwcQHVzY\n\tvjeIVr4yS/tzJYSaoA2HrokMOQM1YyarC3VjxXL//NfY2JqQlZLlicgsJwOfEgOPt8Eia6nUX\n\tyEtga40i3KVyhHNOrcJpQVvQH7y25x2qAM4v4Ng8vrQnxfFCWF0BumsSLGjU/fnjMbQEWf5St\n\tt5B5hLtbrX57ksmV+frlR6Mhc8Kd7n6r9P1njq5PfcGKA04Cda3ZiG1xz9sIIyy3k+c2qogNU\n\tVWjGD9bb2BtsfHaM36Um4XSU7JduDmMjrmjHzVfv8qdr06AfQQsFDrSeBmaKlFnrUnwYX8u7C\n\t5d116gdwJWRk3ONgLKXpMbO1xvFgKse873oEdKMhrTWJwWfCSsTgHzpVAQgcNX4r6u1uJYO4D\n\tsVn7mi0BW6Bx4pob0g31RUKJGS0D6eS7vn84Q28IFhG5Dazmi3FRUlme7fX1tsdmV6UroNqZv\n\teAFSywMoLslS/BLhDnX6Ae4VXFWuU+XRdIyThbNnWFNmCoTl1qi+MM2Cu2+xcZ00BDVBrNo5l\n\tfYlKzDtf7wWfpAVAZELRmp1D1/RRX1w83jIBBPT8CVE12kuBsW7GAaWgOfDbWu9l2mjLWpOuF\n\tFJArbXajvoyujTGb9gzaP4sUxmW6eKaRsdday0GWkW/ZjNCv/TDvYQRwCPzPzL4RGZvdrG9cp\n\tx/zmoRSyJwl7JOkyw28q6iEfpqYDboywL/ElGRTqwjh2qt4Xn3gQECRCw==", "Subject": "[libcamera-devel] [PATCH v9 2/4] libcamera: controls: Define size\n\tof array controls as a shape vector", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This follows the convention in other Tensor APIs. Since all tensors are\nrepresented as a Span with a single dimension, values provided in 'size'\nare interpreted as fixed-size Spans, while an empty array (\"[]\") will be\ninterpreted as variable-sized Span.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 4 ++--\n src/libcamera/property_ids.yaml | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex ecab3ae9..5fa168c6 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -291,7 +291,7 @@ controls:\n transformation. The 3x3 matrix is stored in conventional reading\n order in an array of 9 floating point values.\n\n- size: [3x3]\n+ size: [3,3]\n\n - ScalerCrop:\n type: Rectangle\n@@ -525,7 +525,7 @@ controls:\n the window where the focal distance for the objects shown in that part\n of the image are closest to the camera.\n\n- size: [n]\n+ size: []\n\n - AfTrigger:\n type: int32_t\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 11b7ebdc..a87485d7 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -497,7 +497,7 @@ controls:\n\n - PixelArrayOpticalBlackRectangles:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The pixel array region(s) which contain optical black pixels\n considered valid for calibration purposes.\n@@ -592,7 +592,7 @@ controls:\n\n - PixelArrayActiveAreas:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The PixelArrayActiveAreas property defines the (possibly multiple and\n overlapping) portions of the camera sensor readable pixel matrix\n", "prefixes": [ "libcamera-devel", "v9", "2/4" ] }