Patch Detail
Show a patch.
GET /api/patches/16528/?format=api
{ "id": 16528, "url": "https://patchwork.libcamera.org/api/patches/16528/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16528/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220703073358.76643-5-rishikeshdonadkar@gmail.com>", "date": "2022-07-03T07:33:58", "name": "[libcamera-devel,v1,5/5] gstreamer: Change the colorSpace in the Stream configuration.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b4d096aee604e2d37083bf3f75629030dfa6ab53", "submitter": { "id": 118, "url": "https://patchwork.libcamera.org/api/people/118/?format=api", "name": "Rishikesh Donadkar", "email": "rishikeshdonadkar@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16528/mbox/", "series": [ { "id": 3245, "url": "https://patchwork.libcamera.org/api/series/3245/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3245", "date": "2022-07-03T07:33:54", "name": "[libcamera-devel,v1,1/5] gstreamer: Convert form colorspace to colorimetry.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3245/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16528/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16528/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94CD9BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 3 Jul 2022 07:34:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F08365650;\n\tSun, 3 Jul 2022 09:34:41 +0200 (CEST)", "from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com\n\t[IPv6:2607:f8b0:4864:20::1036])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECB736564D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 3 Jul 2022 09:34:39 +0200 (CEST)", "by mail-pj1-x1036.google.com with SMTP id\n\tg16-20020a17090a7d1000b001ea9f820449so10482199pjl.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 03 Jul 2022 00:34:39 -0700 (PDT)", "from localhost.localdomain\n\t([2402:8100:30af:f358:3ebf:ad3f:f834:3344])\n\tby smtp.googlemail.com with ESMTPSA id\n\tl11-20020a170903120b00b0016b953872a7sm10300285plh.201.2022.07.03.00.34.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 03 Jul 2022 00:34:38 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656833681;\n\tbh=Djjw2Xg6w0jHQcyV8UYedjkqFjMlptdQ0h4ErIx2ZfA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PgCMQqG9Qkix2BVqaCuOF6WaNT7m2gfAkIhVZe6C0dohjeG65pbkHIusdqnXEGFRl\n\t6WFZd5lnz+37a/v0Lvr/nJuZaN38G4/QARCWxITC3JIeOVIGC9kMuqdyyneV0PPSxX\n\t8FIRCVAlDO8NeczL+/fZYrkofpSxUK5OPo+Pe7H5dZ0G0KxuMZXBCj/K4qNZ1QxX7I\n\tJJapaWpRc6KinvBotX6xHIgfbdIwopneH0hwwmYoH28tYkxOO+8vcDT/RApVhj4M4l\n\tkUUXQSs1P6VQTVDMaNPIp1iocUEdmyd1PQjfuT04d8ed3hZhuBEDVb2+f+TohDQXo5\n\tAh4gJODI4+1mA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Cr4BjYS4XcdvowXiRLCk7G0cV8EtybZvIBEeGgIpvTQ=;\n\tb=DCYtK6Se3YURdLkum/5M/QytcNokNE8E6aGFOphfcwjk32ucuikX7hZtWktOjr6nAV\n\tfPLxwaNULKuMn4kqGcSFahyQoT+cMED2I+eRfPLqXgMaQeAHqkZGUptaBE2Zf4AxpLDc\n\td3nYynlwX9QXsHi5VyyiKPErcqxvV/okaSoXvlAOdRd7p/zgJWkyaPo/tR+LQa1voQY6\n\t/LZBp0O86c3X4yushS94DFF/tuTBDNt2/JxYUwCeH+H7aUHowj2/Z3dLCGWEsVEV94kn\n\t6qfx6YQsCTGWFtTuarrWAtAah/qLmF0G1Q/LBanEzNManBXN2fgqMzEmVpLtk8JWnOBb\n\tdOUw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DCYtK6Se\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Cr4BjYS4XcdvowXiRLCk7G0cV8EtybZvIBEeGgIpvTQ=;\n\tb=53zuC9DptCXmi5XhjlLsTkKY3iwycg0dCfynfdtRTyitPErMWENQOwx0TOxJbhv5Wf\n\tItjgVqe566TPmpTAqv66vKyi6JmyEoRxl5rErFLYEGlQL0D1R+N9kd9TlypxDjES1WWj\n\t302J1MvWvRMI+cEj9DNm9IrnYDl6OHmbVgkI7Copl3rU2PadFN9brpaGolKpgQUbRkdU\n\tBwWv4bYoUDkGAMjjZTVFO7S5D1IUBd5L2GlxbbMJ4fqeOxuKPx3Y4mwtBRmo/Da6d7Nl\n\t8aGvj7LdYb1UkGrb7dURY7BO//W/sV/mrrjKkJnPhLp6r2g8AmtNJOvDGbsUJvYjpvIb\n\tpkZw==", "X-Gm-Message-State": "AJIora89J02ysds9RReKNdEJIKn12tsuCsZd88UipXU+XKAE3GJEe4yV\n\tNiFdZlQxxRguQCaj+W7AiHuQvbAbG5k9AcmN", "X-Google-Smtp-Source": "AGRyM1uY0HuqcBdI6hY1wgV/GZpk5DceyU6/fbPMhlAs0KZBfdNhY/O/zCxc7wYzeChwo60z+GB1gg==", "X-Received": "by 2002:a17:90a:4294:b0:1ee:f3f2:9cd0 with SMTP id\n\tp20-20020a17090a429400b001eef3f29cd0mr27127788pjg.79.1656833678842; \n\tSun, 03 Jul 2022 00:34:38 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 3 Jul 2022 13:03:58 +0530", "Message-Id": "<20220703073358.76643-5-rishikeshdonadkar@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220703073358.76643-1-rishikeshdonadkar@gmail.com>", "References": "<20220703073358.76643-1-rishikeshdonadkar@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 5/5] gstreamer: Change the colorSpace\n\tin the Stream configuration.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Rishikesh Donadkar via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>", "Cc": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Get the colorimetry if requested in the gstreamer pipeline and pass\nthat to the function colorspace_form_colorimetry() which will set\nthe colorspace corresponding to the requested colorimetry in the\nstream configuration.\n\nSigned-off-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 120319b3..91668e81 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -387,6 +387,13 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \tfor (gsize i = 0; i < state->srcpads_.size(); i++) {\n \t\tGstPad *srcpad = state->srcpads_[i];\n \t\tStreamConfiguration &stream_cfg = state->config_->at(i);\n+\t\tgchar *colorimetry;\n+\n+\t\tg_object_get(self, \"colorimetry\", &colorimetry, NULL);\n+\t\tif (colorimetry != nullptr) {\n+\t\t\tstd::optional<ColorSpace> &colorSpace = stream_cfg.colorSpace;\n+\t\t\tcolorspace_form_colorimetry(colorSpace, colorimetry);\n+\t\t}\n \n \t\t/* Retrieve the supported caps. */\n \t\tg_autoptr(GstCaps) filter = gst_libcamera_stream_formats_to_caps(stream_cfg.formats());\n", "prefixes": [ "libcamera-devel", "v1", "5/5" ] }