Patch Detail
Show a patch.
GET /api/patches/16527/?format=api
{ "id": 16527, "url": "https://patchwork.libcamera.org/api/patches/16527/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16527/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220703073358.76643-4-rishikeshdonadkar@gmail.com>", "date": "2022-07-03T07:33:57", "name": "[libcamera-devel,v1,4/5] gstreamer:Convert between requested colorimetry and libcamera ColorSpace", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "274304af6c1ab08d718c88854ecb3b445e8ccf02", "submitter": { "id": 118, "url": "https://patchwork.libcamera.org/api/people/118/?format=api", "name": "Rishikesh Donadkar", "email": "rishikeshdonadkar@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16527/mbox/", "series": [ { "id": 3245, "url": "https://patchwork.libcamera.org/api/series/3245/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3245", "date": "2022-07-03T07:33:54", "name": "[libcamera-devel,v1,1/5] gstreamer: Convert form colorspace to colorimetry.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3245/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16527/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16527/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2920ABE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 3 Jul 2022 07:34:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E90AA6564A;\n\tSun, 3 Jul 2022 09:34:36 +0200 (CEST)", "from mail-pg1-x532.google.com (mail-pg1-x532.google.com\n\t[IPv6:2607:f8b0:4864:20::532])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2566E6564A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 3 Jul 2022 09:34:35 +0200 (CEST)", "by mail-pg1-x532.google.com with SMTP id q140so6196970pgq.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 03 Jul 2022 00:34:35 -0700 (PDT)", "from localhost.localdomain\n\t([2402:8100:30af:f358:3ebf:ad3f:f834:3344])\n\tby smtp.googlemail.com with ESMTPSA id\n\tl11-20020a170903120b00b0016b953872a7sm10300285plh.201.2022.07.03.00.34.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 03 Jul 2022 00:34:33 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656833676;\n\tbh=od/F7mDvbjsOqucnf4PTHvCW287++kgVDi9oiaJXcfc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=p6+RzO54htspqhEcsBE7rXuTClTd5fmXes2EliVKdOQTIiC8vsWLUmVoM22pXsxUt\n\tfmfQu0b3Fl6OwcffHoGk+I9qaoQz9NnwW8MP8dskczpHqHJHDQ2OujjtrF5VQw7Lkc\n\t4Y025ib++ljeGW1QbIsbCP/ehCC5aHMTupSxCJvp3hu5zVegOo4cTIlXbmQakE27uQ\n\tFpQLxyzRHrCP3yluAjcNC/yxykoOmnCmYJo0ET0OCnP+TuWMwl9fqaFFSO8VzjrXgo\n\tDNP9COGqEwyilVEpVsrk/tAJ/weicrMd+e5DGK63r8pQtiL8kqq/7Tpge4hXe/WqzC\n\t32kFM7JpdWSng==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uKye1mYdGvCKbcR65Kghc9l6W+ZDxjv5P//wb8fqUks=;\n\tb=ig09jwFqUB5PJzDSShXhn5tqQfrDQyS9Zo+pVk8kE+VFKxh5YYMd9SqyEH0dz8ctl1\n\tkliBvLNVbrxBW7WMNpt58oT0P7gSUPaThSALHXe5Lk1Oh/qSCf1DwwNcOin/Mkln4Ljr\n\tOxw+Y5RBDtiY0eK2OctfxXALGy2QF940BALwiRcWkkVOVgxcbbCpyqI9bdJIJw0JIzvP\n\tv4n/96CsRoCJra13NV4idaM45PdXsSlw+wpLorxDo7cJ/2Dk0MUNLMBh1V999gj/oho2\n\tCcfgQv2shFmFzBdhAyS4axYFuI9rMyZfkT1YPV8rqYxLa2uS+Waorh73OTuWyNuKzHod\n\ty/cA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ig09jwFq\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uKye1mYdGvCKbcR65Kghc9l6W+ZDxjv5P//wb8fqUks=;\n\tb=BogF5sufkbW9iFKkOb7G7pdLQK8uiX9xPKPOW6GSYxQYnep3nlvGTdtcbFrevvwf/N\n\tAHnNrzAj35djTAGjDVvUCShC8t2UfDx/oY3rR8D1w0B3ZmSyYmQ7hgckxn6Bvv6aMIeH\n\t/w/gCGoAsVq2pRqh66oteksarmHUB+djDGh27oguno25BTcHfNS8bu2x/HRGCdZ5IefB\n\tIKHXOYxYRQcc4FxhynViPepEOvESwSaSlxjmErToDfegg7Q1haGJW0VtP4KsKqYZP9Wv\n\tbKZmyac4ycKsRh1MOSeJzx1/5BrcficaTAmkZ5VEs8z5lpaG/NY27L//6KQzjNm6JIKo\n\tFDYw==", "X-Gm-Message-State": "AJIora/LssWIoCSmrC1aEW4XVuNLT6dEc1DKNM8NlJ2T4qanRio87tTY\n\tQvkIze3g1g061vCzmTYyeEG6aAeLrHeY+g82", "X-Google-Smtp-Source": "AGRyM1sIwMe+mpuT6nIuCybHgovxEoissNSPhL0UaFJpV9e3st1CRxODg/rpb1hwEMA5UtKwxj60Zw==", "X-Received": "by 2002:a05:6a00:b94:b0:525:930f:57ff with SMTP id\n\tg20-20020a056a000b9400b00525930f57ffmr30161252pfj.72.1656833673521; \n\tSun, 03 Jul 2022 00:34:33 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 3 Jul 2022 13:03:57 +0530", "Message-Id": "<20220703073358.76643-4-rishikeshdonadkar@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220703073358.76643-1-rishikeshdonadkar@gmail.com>", "References": "<20220703073358.76643-1-rishikeshdonadkar@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 4/5] gstreamer:Convert between\n\trequested colorimetry and libcamera ColorSpace", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Rishikesh Donadkar via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>", "Cc": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add map colorimetryToColorSpace and the function\ncolorspace_form_colorimetry() to convert from gstreamer colorimetry\nto libcamera colorspace. The obtained colorspace form the conversion\nwill be applied to the colorSpace field of the StreamConfiguration.\n\nSigned-off-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 15 +++++++++++++++\n src/gstreamer/gstlibcamera-utils.h | 1 +\n 2 files changed, 16 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 690a9f43..221100e9 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -73,6 +73,12 @@ static const std::map<ColorSpace::Range, GstVideoColorRange> ToGstVideoColorRang\n \t{ ColorSpace::Range::Limited, GST_VIDEO_COLOR_RANGE_16_235 },\n };\n \n+static const std::map<std::string, ColorSpace> colorimetryToColorSpace = {\n+\t{ GST_VIDEO_COLORIMETRY_SRGB, ColorSpace::Srgb },\n+\t{ GST_VIDEO_COLORIMETRY_BT709, ColorSpace::Rec709 },\n+\t{ GST_VIDEO_COLORIMETRY_BT2020, ColorSpace::Rec2020 },\n+};\n+\n static GstVideoFormat\n pixel_format_to_gst_format(const PixelFormat &format)\n {\n@@ -158,6 +164,15 @@ colorimerty_from_colorspace(std::optional<ColorSpace> colorSpace)\n \treturn colorimetry_str;\n }\n \n+void colorspace_form_colorimetry(std::optional<ColorSpace> &colorspace, const gchar *colorimetry)\n+{\n+\tauto iterColorSpace = colorimetryToColorSpace.find(colorimetry);\n+\tif (iterColorSpace != colorimetryToColorSpace.end()) {\n+\t\tcolorspace = iterColorSpace->second;\n+\t\treturn;\n+\t}\n+}\n+\n GstCaps *\n gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n {\ndiff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex d54f1588..6aff6be0 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -20,6 +20,7 @@ void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &st\n \t\t\t\t\t GstCaps *caps);\n void gst_libcamera_resume_task(GstTask *task);\n std::shared_ptr<libcamera::CameraManager> gst_libcamera_get_camera_manager(int &ret);\n+void colorspace_form_colorimetry(std::optional<libcamera::ColorSpace> &colorspace, const gchar *colorimetry);\n \n /**\n * \\class GLibLocker\n", "prefixes": [ "libcamera-devel", "v1", "4/5" ] }