Patch Detail
Show a patch.
GET /api/patches/16510/?format=api
{ "id": 16510, "url": "https://patchwork.libcamera.org/api/patches/16510/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16510/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220701103236.1007698-1-umang.jain@ideasonboard.com>", "date": "2022-07-01T10:32:36", "name": "[libcamera-devel] libcamera: camera: Reset request sequence number on stop/start", "commit_ref": "458d917ca2cb27bfeadca2a25c61ca99c5a82e9b", "pull_url": null, "state": "accepted", "archived": false, "hash": "ff516bfe29452fbaabf70f3674d2e84f7c1a9ecc", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16510/mbox/", "series": [ { "id": 3242, "url": "https://patchwork.libcamera.org/api/series/3242/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3242", "date": "2022-07-01T10:32:36", "name": "[libcamera-devel] libcamera: camera: Reset request sequence number on stop/start", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3242/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16510/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16510/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CF28BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 1 Jul 2022 10:32:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57A8F65632;\n\tFri, 1 Jul 2022 12:32:50 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C18F260552\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Jul 2022 12:32:48 +0200 (CEST)", "from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:ca21:e286:106b:5da4:9482])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F12E25C;\n\tFri, 1 Jul 2022 12:32:46 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656671570;\n\tbh=fWMvY6f6viU7vfLZ77gU0Y+1WiEzdMlr9rZueVuCvKg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=tA07RfB8UGWKSZpgWTVQaJ9fmE9HupOtbxhyDqo1tjlQ9kaUxJNERJr2D0dBDhj7I\n\tzfdW3LTieVa49AS97bu4gdgSxjcRg/zI8ozzv8aAMqYiQJrbXVJNO9wN3tFg9bU9E5\n\tUOj5wX4ObWmWV/WTacspoU3PfwYogSaPo+eQ/xbhKuRmKstrsmxE7a9jJnflmQTO9E\n\tg4mSXu9ZDr+9QEMKJaELGM0OVLdhHdNcmhUkWMQG0C1gGYuUujIyt8HxNmZK90fz9q\n\tBy0asQEgyLZqMmryTmtfIFUbyTUcI9RjUCWTsEa9vujoeAIzDYJZKJoS3UNnR33Cim\n\t2l0nm2oWk4A6g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656671568;\n\tbh=fWMvY6f6viU7vfLZ77gU0Y+1WiEzdMlr9rZueVuCvKg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=sGoFCR/xpVHXb7cR9vpgUI/JR3JXdB83KsLsncLI5y4Qs/0QWKr7Z09hSVPeRtAy4\n\tcqXbIPflzfw8mnqnypmbDd2kkt1zWEQGH2SF4HH4Rb8KBRR1uSedoGBMw26ulj0Qtw\n\t0x+Or5CmE5piDQ1hIQkte21XKQ4V0/viM5OFrC8U=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sGoFCR/x\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Jul 2022 16:02:36 +0530", "Message-Id": "<20220701103236.1007698-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: camera: Reset request sequence\n\tnumber on stop/start", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We now have V4L2VideoDevice ensuring that sensor sequence numbers\nstart from zero [1], and we desire that these should match the Request\nsequence number as well.\n\n[1] 1c9dc0fd89cf (\"libcamera: v4l2_videodevice: Identify non-zero stream starts\")\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/camera.cpp | 4 +++-\n src/libcamera/pipeline_handler.cpp | 2 ++\n src/libcamera/request.cpp | 4 ++--\n 3 files changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 713543fd..f8150dcd 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -497,7 +497,7 @@ Camera::Private::~Private()\n * facilitate debugging of internal request usage.\n *\n * The requestSequence_ tracks the number of requests queued to a camera\n- * over its lifetime.\n+ * over a single capture session.\n */\n \n static const char *const camera_state_names[] = {\n@@ -1181,6 +1181,8 @@ int Camera::start(const ControlList *controls)\n \n \tLOG(Camera, Debug) << \"Starting capture\";\n \n+\tASSERT(d->requestSequence_ == 0);\n+\n \tret = d->pipe_->invokeMethod(&PipelineHandler::start,\n \t\t\t\t ConnectionTypeBlocking, this, controls);\n \tif (ret)\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 7ebd76ad..67540533 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -312,6 +312,8 @@ void PipelineHandler::stop(Camera *camera)\n \t/* Make sure no requests are pending. */\n \tCamera::Private *data = camera->_d();\n \tASSERT(data->queuedRequests_.empty());\n+\n+\tdata->requestSequence_ = 0;\n }\n \n /**\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 51d74b29..07613cb3 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -526,8 +526,8 @@ FrameBuffer *Request::findBuffer(const Stream *stream) const\n *\n * When requests are queued, they are given a sequential number to track the\n * order in which requests are queued to a camera. This number counts all\n- * requests given to a camera through its lifetime, and is not reset to zero\n- * between camera stop/start sequences.\n+ * requests given to a camera and is reset to zero between camera stop/start\n+ * sequences.\n *\n * It can be used to support debugging and identifying the flow of requests\n * through a pipeline, but does not guarantee to represent the sequence number\n", "prefixes": [ "libcamera-devel" ] }