Patch Detail
Show a patch.
GET /api/patches/1650/?format=api
{ "id": 1650, "url": "https://patchwork.libcamera.org/api/patches/1650/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1650/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190710205802.2204-1-kieran.bingham@ideasonboard.com>", "date": "2019-07-10T20:58:02", "name": "[libcamera-devel] libcamera: Fix spellings and grammar", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3768be65560e6a53a0fced182d01eaa06fd42efc", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1650/mbox/", "series": [ { "id": 415, "url": "https://patchwork.libcamera.org/api/series/415/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=415", "date": "2019-07-10T20:58:02", "name": "[libcamera-devel] libcamera: Fix spellings and grammar", "version": 1, "mbox": "https://patchwork.libcamera.org/series/415/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1650/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1650/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EBAE6156E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Jul 2019 22:58:06 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B00531C;\n\tWed, 10 Jul 2019 22:58:05 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562792285;\n\tbh=YNApnWq+e1HwETrjnLMMPRJ4AHO7PEP93np+qSG9/wk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=XaQAQ2kIKxvSzJR0ylGyU781679kZODa2+WViSqBv1kHiXj6yfyGrOUzjlVMUj8Yj\n\t/Xw63Kxk602007LcqzKaHFD8CgVggpIddZKp9yalKamMhbykJZVi/Fq6mG9wX3ehi4\n\tzFGz72fSIAM1aCQBWJT1h/RBdkvZXBty5Fq9uOkI=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 10 Jul 2019 21:58:02 +0100", "Message-Id": "<20190710205802.2204-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: Fix spellings and grammar", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 10 Jul 2019 20:58:06 -0000" }, "content": "Fix a number of spelling errors and word duplications throughout the comments\nwithin libcamera.\n\nThese were picked up with spellintian.\n\nAlso one capitalisation of the first word of a \\return statement picked\nup by checkstyle.py while creating this patch.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/buffer.cpp | 2 +-\n src/libcamera/camera.cpp | 2 +-\n src/libcamera/controls.cpp | 2 +-\n src/libcamera/ipa_module.cpp | 2 +-\n src/libcamera/pipeline_handler.cpp | 2 +-\n src/libcamera/stream.cpp | 2 +-\n src/libcamera/v4l2_device.cpp | 2 +-\n 7 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\nindex d86278a8a90a..f9e62c218f39 100644\n--- a/src/libcamera/buffer.cpp\n+++ b/src/libcamera/buffer.cpp\n@@ -222,7 +222,7 @@ Buffer::Buffer()\n * \\fn Buffer::timestamp()\n * \\brief Retrieve the time when the buffer was processed\n *\n- * The timestamp is expressed as a number number of nanoseconds since the epoch.\n+ * The timestamp is expressed as a number of nanoseconds since the epoch.\n *\n * \\return Timestamp when the buffer was processed\n */\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 592dfd39eacc..c74c4e4b8450 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -759,7 +759,7 @@ int Camera::freeBuffers()\n * \\brief Create a request object for the camera\n *\n * This method creates an empty request for the application to fill with\n- * buffers and paramaters, and queue for capture.\n+ * buffers and parameters, and queue for capture.\n *\n * The ownership of the returned request is passed to the caller, which is\n * responsible for either queueing the request or deleting it.\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex d9fbd46d81c9..727fdbd9450d 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -204,7 +204,7 @@ std::string ControlValue::toString() const\n * \\var Contrast\n * ControlType: Integer\n *\n- * Specify a fixed constrast parameter.\n+ * Specify a fixed contrast parameter.\n */\n \n /**\ndiff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex d2e3c366dc04..baf3c5719229 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -322,7 +322,7 @@ close:\n * the IPA module information it contains was successfully retrieved and\n * validated.\n *\n- * \\return true if the the IPAModule is valid, false otherwise\n+ * \\return True if the IPAModule is valid, false otherwise\n */\n bool IPAModule::isValid() const\n {\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 0283e4e5ad51..26f619ea736b 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -149,7 +149,7 @@ PipelineHandler::~PipelineHandler()\n * return false.\n *\n * If multiple instances of a pipeline are available in the system, the\n- * PipelineHandler class will be instanciated once per instance, and its match()\n+ * PipelineHandler class will be instantiated once per instance, and its match()\n * function called for every instance. Each call shall acquire media devices for\n * one pipeline instance, until all compatible media devices are exhausted.\n *\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex d8e87c62281c..9dbb6633c9ce 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -428,7 +428,7 @@ Stream::Stream()\n * \\var Stream::bufferPool_\n * \\brief The pool of buffers associated with the stream\n *\n- * The stream buffer pool is populated by the Camera class after a succesfull\n+ * The stream buffer pool is populated by the Camera class after a successful\n * stream configuration.\n */\n \ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex e3ec44a7f156..9a00566a532b 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -30,7 +30,7 @@ LOG_DEFINE_CATEGORY(V4L2)\n *\n * The V4L2Device class groups together the methods and fields common to\n * both the V4L2VideoDevice and V4L2Subdevice classes, and provides a base\n- * class whith methods to open and close the device node associated with the\n+ * class with methods to open and close the device node associated with the\n * device and to perform IOCTL system calls on it.\n *\n * The V4L2Device class cannot be instantiated directly, as its constructor\n", "prefixes": [ "libcamera-devel" ] }