Patch Detail
Show a patch.
GET /api/patches/16486/?format=api
{ "id": 16486, "url": "https://patchwork.libcamera.org/api/patches/16486/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16486/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220630143543.39599-5-dse@thaumatec.com>", "date": "2022-06-30T14:35:39", "name": "[libcamera-devel,4/8] pipeline: rkisp1: Add basic AF controls to the supported controls list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a51a231d2a02cea54ff0932b94e9339bfd74a9df", "submitter": { "id": 126, "url": "https://patchwork.libcamera.org/api/people/126/?format=api", "name": "Daniel Semkowicz", "email": "dse@thaumatec.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16486/mbox/", "series": [ { "id": 3239, "url": "https://patchwork.libcamera.org/api/series/3239/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3239", "date": "2022-06-30T14:35:35", "name": "ipa: rkisp1: Add autofocus algorithm", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3239/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16486/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16486/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 245EDBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jun 2022 14:36:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C915C6565B;\n\tThu, 30 Jun 2022 16:35:59 +0200 (CEST)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E61D865651\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 16:35:57 +0200 (CEST)", "by mail-wm1-x334.google.com with SMTP id\n\tbe14-20020a05600c1e8e00b003a04a458c54so1804509wmb.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 07:35:57 -0700 (PDT)", "from localhost.localdomain (ip092042140082.rev.nessus.at.\n\t[92.42.140.82]) by smtp.gmail.com with ESMTPSA id\n\tr5-20020a05600c320500b0039db500714fsm6405945wmp.6.2022.06.30.07.35.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 30 Jun 2022 07:35:57 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656599759;\n\tbh=a02j7m+LCJXnGBRYohDsOE13qJPexul5dyO/pjASgNs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=GjE28zlJgP7TxexJo4/5CqG0L0myt7jAZ9oJ7v6BFKQipWf1LKTg3t6LwiwDzyXlk\n\toNq8XhflQ4jmcfsEqV7q6ZgSv3lGgyotpZ+nd/KdBfV5zTkDS4yXxN7qdE6chBb2aJ\n\tOJ7oN4m+KX0ZAZb1+jtbATdYb5oZpqMfASOB8X8IBGfsHFuhjHrgpsmJcuZtwaKmlh\n\tHAsxXKhRTn1O+EOXLEH9aPRzjC9TLdg3oiV6/HK/CJoVl/aWinFXW6m3AEo2ZtqQxL\n\tQI9vs2Uf1dyqq6FKCquH79KCmlB395HYnvSS6/X73I9/JYiCAOGj4nc2otGvDpvI+x\n\tLoTwZjwxkA9jg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=JpO4KM67IDVW3tNGmALv7h4/iatJGTjwtytTMopFnkA=;\n\tb=xLfjPOF8MnILcT3w556LpyJw3UVpxSRaGPPkl5oSjVun7DZRoPxFDNta61KI1TMIJh\n\tsPqJs2qlk6S07sXogIgYvMbQvdJm+RGEyEGuTJOd83VNN5ciVfId/wyet6m6YhTi169S\n\tXPLQvmaBVXSNWHep4i82nD2ynL3EcmO7vlpeAuyJxeFeocbmJCY6vMMhu1N/eMVMcQWx\n\t6SRJ9rCzvCk/1sAdR5cbhf45seIB5Z2UWNPCVdMtO9TNgMbB7dpjD/8IIt5TrNp308Tq\n\txCWq8BDS3cmf56E0gBApykb3fWKWlBkDxCJaN4/fgcQ6KlummvjVSMtw8LZ0GDb2GawU\n\tC1ng==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"xLfjPOF8\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=JpO4KM67IDVW3tNGmALv7h4/iatJGTjwtytTMopFnkA=;\n\tb=XBnCLsZxktP7AXIEf49V4Z13PhbEeHuwwel8ZREPBsOxUMs0EkI9bGOHcYj2GgV3VK\n\t9GUr744ZmqUftL38LFF7F1ZE4Coc1shnqnEDO71h2JvdhblnYDd+2bzeAHBp9ptdBg1G\n\tpgoJ3OmCo38z5X3//Y+N5b+DWMkPy29CwYMENTSyXUIW++PvUzpGUsOc+TDnv3eAMzx5\n\tp0NEFiDTMNM2ZaEU5XKAHcOlKqds1ws2FFKMSYoaAjFxLHCotQC2TnvWqVJZMEhsPu6S\n\tFf21p9JwEgHcT26KBclNJRRw6X71bHbsKIDSlYo2W/H82fEqkMCOluzkg/X4rZrIKkEG\n\th3aA==", "X-Gm-Message-State": "AJIora+6VYJUF8iUGQl92UXVHANsY/dknt4xdP06MFC+j5jy7Pp2Ug5I\n\tdqGijpXcB1BzD4X0LDHdC70aYWl4EfT2hw==", "X-Google-Smtp-Source": "AGRyM1tGT9hQWX7iz39420v0oBkgyQxOdG1ybSbzl86sJ1tpLs9J3GzUoEr0iz8tT9LHP2S5ehh4pQ==", "X-Received": "by 2002:a05:600c:34c9:b0:3a0:5072:9abe with SMTP id\n\td9-20020a05600c34c900b003a050729abemr10244078wmq.8.1656599757689; \n\tThu, 30 Jun 2022 07:35:57 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Jun 2022 16:35:39 +0200", "Message-Id": "<20220630143543.39599-5-dse@thaumatec.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220630143543.39599-1-dse@thaumatec.com>", "References": "<20220630143543.39599-1-dse@thaumatec.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/8] pipeline: rkisp1: Add basic AF\n\tcontrols to the supported controls list", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Semkowicz via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Semkowicz <dse@thaumatec.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This will expose the AF controls and will allow controlling them using\nthe top level API.\n\nSigned-off-by: Daniel Semkowicz <dse@thaumatec.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 7ee80192..99d66b1d 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -958,10 +958,12 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \tstd::unique_ptr<RkISP1CameraData> data =\n \t\tstd::make_unique<RkISP1CameraData>(this, &mainPath_, &selfPath_);\n \n-\tControlInfoMap::Map ctrls;\n-\tctrls.emplace(std::piecewise_construct,\n-\t\t std::forward_as_tuple(&controls::AeEnable),\n-\t\t std::forward_as_tuple(false, true));\n+\tControlInfoMap::Map ctrls({\n+\t\t{ &controls::AeEnable, ControlInfo(false, true) },\n+\t\t{ &controls::AfMode, ControlInfo(controls::AfModeValues) },\n+\t\t{ &controls::AfTrigger, ControlInfo(controls::AfTriggerValues) },\n+\t\t{ &controls::AfPause, ControlInfo(controls::AfPauseValues) }\n+\t});\n \n \tdata->controlInfo_ = ControlInfoMap(std::move(ctrls),\n \t\t\t\t\t controls::controls);\n", "prefixes": [ "libcamera-devel", "4/8" ] }