Patch Detail
Show a patch.
GET /api/patches/16470/?format=api
{ "id": 16470, "url": "https://patchwork.libcamera.org/api/patches/16470/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16470/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220630133902.321099-12-jacopo@jmondi.org>", "date": "2022-06-30T13:38:50", "name": "[libcamera-devel,v3,11/23] libcamera: camera_sensor: Expose DelayedControls interface", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "00ae5d70528ae6dab2690bfda69937f3248baf14", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16470/mbox/", "series": [ { "id": 3238, "url": "https://patchwork.libcamera.org/api/series/3238/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3238", "date": "2022-06-30T13:38:39", "name": "Internal controls, sensor delays and IPA rework", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3238/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16470/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16470/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9ED01BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jun 2022 13:39:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A56E65654;\n\tThu, 30 Jun 2022 15:39:39 +0200 (CEST)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A901365698\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 15:39:32 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 5245524000E;\n\tThu, 30 Jun 2022 13:39:30 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656596379;\n\tbh=e6CA81XgDG0jDFZRuz9A0qOZSqW4ZunScIBZranHz68=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=pN7+FEk54iuBCiJG0FTqbC0kYyItI6scp546Vucuy0qSWrS0bCGeye2t+JUao8AsE\n\thed4cjqwevePfzLyx/9W45M1JbKhjkqm5ziTRriCyeFl+d4BnNxtbzhG0fj2JLnJyk\n\tsnDOq55pIQVruGfIjkpw3P23l/Q651ZcRyk7YoyXb0JviamY4z6WTc+MHH0onRYovv\n\tCg1arSh2/femxPuYDx4DclGByZsfzIO1BFGehtxgbmcL/fHNp/TWexfVmGC7mAazDr\n\tvtjvylG0mZooSWgBXem5mylHMxNMfT7QsBBnQynu9/XQrKybsaxzACtQH/PejLey4a\n\tux0CsrvSpiovg==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Jun 2022 15:38:50 +0200", "Message-Id": "<20220630133902.321099-12-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.36.1", "In-Reply-To": "<20220630133902.321099-1-jacopo@jmondi.org>", "References": "<20220630133902.321099-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 11/23] libcamera: camera_sensor: Expose\n\tDelayedControls interface", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that the CameraSensor class has an instance of delayed controls\nexpose its interface for pipeline handlers to use it.\n\nThe interface towards DelayedControls still operates on lists of\nV4L2 controls.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/internal/camera_sensor.h | 4 +++\n src/libcamera/camera_sensor/camera_sensor.cpp | 31 +++++++++++++++++++\n 2 files changed, 35 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex bd5aa0dbc27d..a606bc5d1cb5 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -71,6 +71,10 @@ public:\n \n \tCameraLens *focusLens() { return focusLens_.get(); }\n \n+\tvoid frameStart(uint32_t sequence);\n+\tvoid pushControls(const ControlList &ctrls);\n+\tControlList getControls(uint32_t sequence);\n+\n protected:\n \tstd::string logPrefix() const override;\n \ndiff --git a/src/libcamera/camera_sensor/camera_sensor.cpp b/src/libcamera/camera_sensor/camera_sensor.cpp\nindex 211c7461f5c6..e1770e8fa130 100644\n--- a/src/libcamera/camera_sensor/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor/camera_sensor.cpp\n@@ -1043,6 +1043,37 @@ void CameraSensor::updateControlInfo()\n \tupdateControls();\n }\n \n+/**\n+ * \\brief Signal to the camera sensor class that a new frame has start exposing\n+ * \\param[in] sequence The frame sequence number\n+ */\n+void CameraSensor::frameStart(uint32_t sequence)\n+{\n+\t/* A new capture session requires to start in a clean state. */\n+\tif (sequence == 0)\n+\t\tdelayedCtrls_->reset();\n+\n+\tdelayedCtrls_->applyControls(sequence);\n+}\n+\n+/**\n+ * \\brief Push a new set of controls to the CameraSensor\n+ * \\param[in] ctrls The list of controls to push to the sensor\n+ */\n+void CameraSensor::pushControls(const ControlList &ctrls)\n+{\n+\tdelayedCtrls_->push(ctrls);\n+}\n+\n+/**\n+ * \\brief Get the list of controls applied at frame \\a sequence\n+ * \\param[in] sequence The frame sequence number\n+ */\n+ControlList CameraSensor::getControls(uint32_t sequence)\n+{\n+\treturn delayedCtrls_->get(sequence);\n+}\n+\n /**\n * \\fn CameraSensor::focusLens()\n * \\brief Retrieve the focus lens controller\n", "prefixes": [ "libcamera-devel", "v3", "11/23" ] }