Patch Detail
Show a patch.
GET /api/patches/16451/?format=api
{ "id": 16451, "url": "https://patchwork.libcamera.org/api/patches/16451/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16451/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220630095521.23723-1-laurent.pinchart@ideasonboard.com>", "date": "2022-06-30T09:55:21", "name": "[libcamera-devel] libcamera: framebuffer: Turn the cookie into a 64-bit integer", "commit_ref": "d5b0cec83940b7965bc215383c247da25304ebca", "pull_url": null, "state": "accepted", "archived": false, "hash": "04f6de47e0d56294595b5905958ca1c81c2745ab", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16451/mbox/", "series": [ { "id": 3236, "url": "https://patchwork.libcamera.org/api/series/3236/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3236", "date": "2022-06-30T09:55:21", "name": "[libcamera-devel] libcamera: framebuffer: Turn the cookie into a 64-bit integer", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3236/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16451/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16451/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 797CFBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jun 2022 09:55:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0CE66564E;\n\tThu, 30 Jun 2022 11:55:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2029C6054C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 11:55:45 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F5A345F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 11:55:43 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656582946;\n\tbh=8NKSDjts2csYZNzAuU2hSlph6ojdLm2cg2+dpWvqTXg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=y9Nrt36VAF+Xo871nil7YNGNNBZhA2T+oWGnER2JzKHjQtE7Tsi/YM94P56ucTlzn\n\t0qcOIEy3RUA45qrHz+Yqu3ukA97EvuVXM3MHr0fUoJV40Ur/Y1vhHWkoXfsXmico89\n\tykf4ccP5GZ9IxBhI+4Rv+gqKJU9YIHcijgMWk/97g/VmuSZGPLKnny5tgJecO2exMA\n\ttGof2q8xFcDgSwNe/QzxIT2VzDmN36gOEBuu9bbEJEW+y4C9SbDasT3zilQDX59q3t\n\tZYhW4sibW9/T3GL+tojzNnlbe9XXAqPQGgie7dFBUKUaVFPHc+XyNCpzrZU5OeDTR7\n\tWl0mYDVMrriCA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656582944;\n\tbh=8NKSDjts2csYZNzAuU2hSlph6ojdLm2cg2+dpWvqTXg=;\n\th=From:To:Subject:Date:From;\n\tb=ceIbacP318lWjr4IOpmFbH0FxajCYDc/wokmJkcysUyT5IV4wPtnxflnSzrjB8y71\n\tIEizrxayLrNH3oH2kHzm9xkP9ZiMGfEYt72Ltdk0k2uzCoiw4OHLtjQWcO5OTxoH+g\n\t93cXHMsTB879vR/wVqDsyxRY16Hgm4lDs2VZyqXQ=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ceIbacP3\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Jun 2022 12:55:21 +0300", "Message-Id": "<20220630095521.23723-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: framebuffer: Turn the cookie\n\tinto a 64-bit integer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To allow associating pointers with FrameBuffer instances, turn the\ncookie into a 64-bit integer. This matches the Request cookie with is\nalso a uint64_t.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/framebuffer.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\n\nbase-commit: 3fa79cc688b540e27f954f156b5ad4bb172ba222", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 3b1118d1f06b..36b91d11ed79 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -66,8 +66,8 @@ public:\n \tRequest *request() const;\n \tconst FrameMetadata &metadata() const { return metadata_; }\n \n-\tunsigned int cookie() const { return cookie_; }\n-\tvoid setCookie(unsigned int cookie) { cookie_ = cookie; }\n+\tuint64_t cookie() const { return cookie_; }\n+\tvoid setCookie(uint64_t cookie) { cookie_ = cookie; }\n \n \tstd::unique_ptr<Fence> releaseFence();\n \n@@ -80,7 +80,7 @@ private:\n \n \tFrameMetadata metadata_;\n \n-\tunsigned int cookie_;\n+\tuint64_t cookie_;\n };\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel" ] }