Patch Detail
Show a patch.
GET /api/patches/16444/?format=api
{ "id": 16444, "url": "https://patchwork.libcamera.org/api/patches/16444/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16444/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220630000251.31295-6-laurent.pinchart@ideasonboard.com>", "date": "2022-06-30T00:02:44", "name": "[libcamera-devel,v2,05/12] gstreamer: Rename queued requests queue to queuedRequests_", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7e4ce79ab358544ee9c3432432b896db143bce35", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16444/mbox/", "series": [ { "id": 3234, "url": "https://patchwork.libcamera.org/api/series/3234/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3234", "date": "2022-06-30T00:02:39", "name": "gstreamer: Queue multiple requests", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3234/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16444/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16444/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D366BBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jun 2022 00:03:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6591065647;\n\tThu, 30 Jun 2022 02:03:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33F0E6563F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 02:03:17 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1FE06D1;\n\tThu, 30 Jun 2022 02:03:16 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656547410;\n\tbh=cqISnPxLu396AkxqcxXMBX2VVrZrc2x5mzNe5IcBhIk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mDjntka9ZLjOUJsezYlimhJfT/dW2kLLS3XLjISuwTyiaDYB9W70p6jRnMG0mEeEG\n\taKEat5JOO4YlMVXKUhszWSuwnCxO1FOrf81TaP+hma0PZkpnaRWbB0QP0CGHNBGECn\n\twn7go33ZaD/Y3sytHjDIxw3HhNq2vt5NkM5G4RkoaEpxn+fREumaSkFik1oNefc3c3\n\tVlx3xMAz0Cu9tKx2Ny3wcleDtyWzUiXFsQNHNRju9+k5Kv2bdQEbqX9etvcyJ7Ux2y\n\tVdTALoL4S43a9FyTv0930hRdzF3+p8WmwQQ2dOw/MSUlR3Y9L89VzyRBhPrzv6EqwD\n\tgztXEPflAWRhg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656547397;\n\tbh=cqISnPxLu396AkxqcxXMBX2VVrZrc2x5mzNe5IcBhIk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=n2AWoTRKYFs9vgheaKN2tD/FRvLDX2QYevuLYSikgPjWiMPAjOhyM93Rd2QfCP3QY\n\twQ6Zjzm7S/sDpAlKeFPnZ6WcnbjD82OKNAbZ4zXwmD+CGgaAc5z+1/ciewe48XWckV\n\txGpwi0tFpRbBJgE/g2IRtGVtx3eM9rXz2gPaqYt4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"n2AWoTRK\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Jun 2022 03:02:44 +0300", "Message-Id": "<20220630000251.31295-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220630000251.31295-1-laurent.pinchart@ideasonboard.com>", "References": "<20220630000251.31295-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 05/12] gstreamer: Rename queued\n\trequests queue to queuedRequests_", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To prepare for the addition of a completed requests queue, rename the\nexisting queued requests queue from requests_ to queuedRequests_.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 37f201e89828..f2f48d53991a 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -108,7 +108,7 @@ struct GstLibcameraSrcState {\n \tstd::shared_ptr<Camera> cam_;\n \tstd::unique_ptr<CameraConfiguration> config_;\n \tstd::vector<GstPad *> srcpads_;\n-\tstd::queue<std::unique_ptr<RequestWrap>> requests_;\n+\tstd::queue<std::unique_ptr<RequestWrap>> queuedRequests_;\n \tguint group_id_;\n \n \tvoid requestCompleted(Request *request);\n@@ -155,8 +155,8 @@ GstLibcameraSrcState::requestCompleted(Request *request)\n \n \tGST_DEBUG_OBJECT(src_, \"buffers are ready\");\n \n-\tstd::unique_ptr<RequestWrap> wrap = std::move(requests_.front());\n-\trequests_.pop();\n+\tstd::unique_ptr<RequestWrap> wrap = std::move(queuedRequests_.front());\n+\tqueuedRequests_.pop();\n \n \tg_return_if_fail(wrap->request_.get() == request);\n \n@@ -311,7 +311,7 @@ gst_libcamera_src_task_run(gpointer user_data)\n \t\tGLibLocker lock(GST_OBJECT(self));\n \t\tGST_TRACE_OBJECT(self, \"Requesting buffers\");\n \t\tstate->cam_->queueRequest(wrap->request_.get());\n-\t\tstate->requests_.push(std::move(wrap));\n+\t\tstate->queuedRequests_.push(std::move(wrap));\n \n \t\t/* The RequestWrap will be deleted in the completion handler. */\n \t}\n", "prefixes": [ "libcamera-devel", "v2", "05/12" ] }