Patch Detail
Show a patch.
GET /api/patches/16392/?format=api
{ "id": 16392, "url": "https://patchwork.libcamera.org/api/patches/16392/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16392/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220627162732.33160-12-jacopo@jmondi.org>", "date": "2022-06-27T16:27:28", "name": "[libcamera-devel,11/15] libcamera: IPACameraSensorInfo: Add VBLANK", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "9214d476e542b5d7f3c561def2da4ea814ebdec2", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16392/mbox/", "series": [ { "id": 3224, "url": "https://patchwork.libcamera.org/api/series/3224/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3224", "date": "2022-06-27T16:27:17", "name": "Internal controls, sensor delays and IPA init/configure rework", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3224/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16392/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16392/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96E5DBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Jun 2022 16:28:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C83D6563A;\n\tMon, 27 Jun 2022 18:28:00 +0200 (CEST)", "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D5506563F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Jun 2022 18:27:51 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id C32D220004;\n\tMon, 27 Jun 2022 16:27:50 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656347280;\n\tbh=0CFR/QE0UmHxV/v04KGzFbyK814o/lukdYYX8q5xPDA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=GClNktlvW+XcVqBAVdp/kv29B4D/DOCZHSY6Wx+NHLhToXfLpsjz2Ks33uG9wXfri\n\tHQ5lBOjgo/V7YUih0AlGmq7S0V+/B+d3csPcxUp4ITNduZrWID0/vJNzTO1/5IU8xJ\n\tMzObH4Eh4Erdbs7tiwDMe7hxccACSOxIheGvcg1HgCDME0hug0FvYkGRZr2IXAemXB\n\tbhp47pkJf7l2G/p5w/LG2B8wwAtW0CRG+fzvNLOXPjQkNed0VCoid4HpF/Aqqv2JRO\n\ttY0JFNYjXpJSfQP0CrXA2keA5jynGiL3zAkwpwTe40WfwTjCcg7jHZ5mZio7qdIXFH\n\tuMViQl0MFLx/g==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Jun 2022 18:27:28 +0200", "Message-Id": "<20220627162732.33160-12-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.36.1", "In-Reply-To": "<20220627162732.33160-1-jacopo@jmondi.org>", "References": "<20220627162732.33160-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 11/15] libcamera: IPACameraSensorInfo: Add\n\tVBLANK", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPA modules need the V4L2_CID_VBLANK value to calculate the\ntotal frame size for the current sensor configuration.\n\nIn order to prepare removing usage of V4L2_CID_VBLANK in IPA modules,\nadd the vblank value to the IPACameraSensorInfo structure.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/ipa/core.mojom | 6 ++++++\n src/libcamera/camera_sensor.cpp | 1 +\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom\nindex 74f3339e56f2..d122fb7add4d 100644\n--- a/include/libcamera/ipa/core.mojom\n+++ b/include/libcamera/ipa/core.mojom\n@@ -178,6 +178,11 @@ module libcamera;\n * The total line length in pixel clock periods, including blanking.\n */\n \n+/**\n+ * \\var IPACameraSensorInfo::vblank\n+ * \\brief The vertical blanking, expressed in number of lines\n+ */\n+\n /**\n * \\var IPACameraSensorInfo::minFrameLength\n * \\brief The minimum allowable frame length in units of lines\n@@ -218,6 +223,7 @@ struct IPACameraSensorInfo {\n \n \tuint64 pixelRate;\n \tuint32 lineLength;\n+\tuint32 vblank;\n \n \tuint32 minFrameLength;\n \tuint32 maxFrameLength;\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 82e51272cccc..e8db9da84e6a 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -1004,6 +1004,7 @@ int CameraSensor::sensorInfo(IPACameraSensorInfo *info) const\n \tint32_t hblank = ctrls.get(V4L2_CID_HBLANK).get<int32_t>();\n \tinfo->lineLength = info->outputSize.width + hblank;\n \tinfo->pixelRate = ctrls.get(V4L2_CID_PIXEL_RATE).get<int64_t>();\n+\tinfo->vblank = ctrls.get(V4L2_CID_VBLANK).get<int32_t>();\n \n \tconst ControlInfo vblank = ctrls.infoMap()->at(V4L2_CID_VBLANK);\n \tinfo->minFrameLength = info->outputSize.height + vblank.min().get<int32_t>();\n", "prefixes": [ "libcamera-devel", "11/15" ] }