Patch Detail
Show a patch.
GET /api/patches/16378/?format=api
{ "id": 16378, "url": "https://patchwork.libcamera.org/api/patches/16378/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16378/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220627122806.29586-3-dse@thaumatec.com>", "date": "2022-06-27T12:28:06", "name": "[libcamera-devel,v3,2/2] cam: capture_script: Check parseFrames() return value for errors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "58f04f52f2dc77f2d4dd2027f846adf25c97e370", "submitter": { "id": 126, "url": "https://patchwork.libcamera.org/api/people/126/?format=api", "name": "Daniel Semkowicz", "email": "dse@thaumatec.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16378/mbox/", "series": [ { "id": 3222, "url": "https://patchwork.libcamera.org/api/series/3222/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3222", "date": "2022-06-27T12:28:04", "name": "cam: Add Rectangle type parsing in capture script", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3222/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16378/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16378/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FB09BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Jun 2022 12:28:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D58265635;\n\tMon, 27 Jun 2022 14:28:20 +0200 (CEST)", "from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 426EB6563E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Jun 2022 14:28:18 +0200 (CEST)", "by mail-wr1-x42a.google.com with SMTP id i1so8336394wrb.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Jun 2022 05:28:18 -0700 (PDT)", "from localhost.localdomain (ip092042140082.rev.nessus.at.\n\t[92.42.140.82]) by smtp.gmail.com with ESMTPSA id\n\tm18-20020a05600c4f5200b0039748be12dbsm17836401wmq.47.2022.06.27.05.28.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 27 Jun 2022 05:28:17 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656332900;\n\tbh=pbGE7XDHq7hmIovBQ67Z7J+nbZQ3s/V86Bz2EQmPyvg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=C6GvFwKf+gK+TSJWAOMSIcLgKsHSNeSuTnJC9FJ7ofH2MFMbww3trnHPe/37pwGI4\n\tlUw2gaGVyztJ630A1JEdBjUiRRKtJnBZiNwec03jes1SxDc/yFdZ1acFQbWdVKvleq\n\tglIv9wC2kV4PSoAU7JhKfhUM+0/tFeY+MUNAh8Up4yjFNKcwKC2rtvNIEpv3IF5L1t\n\tD6ejD4/mpNV+YJz8rlUqS+nasBT126k+bZ9i5y87kVbhPY5MWa6aN78DQcb7Zn/ZXH\n\t5Hbe7oHEYgTVnDfZM0CodYkqaePV2fUrHRV521iXLiffLAj0n/IxD4hkXM8NyzRZwO\n\t0KKET6ctRIaZA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=xSx4ScA8h3SC/iW39LYmFSYICgHD/QB4pZyoECSENYo=;\n\tb=0JuvJclk/C7XS8pPeYikNbu+Rn+5XmCpslmdb0YHJm2ERrZEo47ekKb6f0R5jEmz7i\n\tZu+ACzsI9KTmssILYTf6D2vHdLVy5reeN+jF5I8ObjE29QPYlBwhHyZ0O9PYLLi5Cja+\n\tQ4aCBaGcTlaF4f4bY47jgfXdVruD9JeqoHbHgTObYIRsnwVWGnK+oTKN4elsn4ANgnIc\n\tUmeu18NnMf8Uc7L1MywmK11bPBO5Bu4PZrouvMfb1/xMkvJa+b0vhvEWbmFXrQ5Yg3Mg\n\tvGYyy6v2ICvRpneGhN+P1veRKck8SB/YoEMMpvW92SAySyU86v7LenMUbPQScTTlsK5g\n\tpr/g==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"0JuvJclk\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=xSx4ScA8h3SC/iW39LYmFSYICgHD/QB4pZyoECSENYo=;\n\tb=M1579vfkMOeGlCzXzyFIZvpg8x9g6HJ3X1S2rWynoRP6nlsIBial9waGcSd6iLDblt\n\t62hcnihatVyiNTCRJ2AQaCRBQVAw5yq0mqbW18UIMkn2FKiUgaWQw4vQrpvDSD8hYrav\n\t6oiMHIohIqf3bs8ZuqISG1Wl+H2xeVh/oqVIAup6FbMLcuXRFlkPPDIDQjEC9o2tkdpl\n\tkVtWCqRqGAhwK2YrggCHTiVbwQeEqx/4fvk/9OQwrGBEo9ezSli7Vr/B5jgp/fIhYLtd\n\tz7nQaeuhZOkGhqAsFg1LlGNrHZv22JE9n2KPtJL0sgZskyynHrjuu7hEhJL2yv95Hxt3\n\twMYQ==", "X-Gm-Message-State": "AJIora/M12ssIGd4Cfg6xdSyyaMF/dJiYedb/enVGy90Ztj2jLIplkCW\n\tMceBZNofaesMg8Pccy2FSxyqC/jCPcwxWg==", "X-Google-Smtp-Source": "AGRyM1uCDKbFFs12vYQf/IwsxZ6gudr++KAm69ILEVMr6U5nkYcDf0zHxuytTWe6IiJHHgtkRKGVVw==", "X-Received": "by 2002:a05:6000:993:b0:21b:8f16:5b3f with SMTP id\n\tby19-20020a056000099300b0021b8f165b3fmr11633510wrb.628.1656332897856; \n\tMon, 27 Jun 2022 05:28:17 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Jun 2022 14:28:06 +0200", "Message-Id": "<20220627122806.29586-3-dse@thaumatec.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220627122806.29586-1-dse@thaumatec.com>", "References": "<20220627122806.29586-1-dse@thaumatec.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 2/2] cam: capture_script: Check\n\tparseFrames() return value for errors", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Semkowicz via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Semkowicz <dse@thaumatec.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "parseFrames() return value was ignored. If there was an error during\nframe parsing, parsing was not stopped correctly.\n\nSigned-off-by: Daniel Semkowicz <dse@thaumatec.com>\n---\n src/cam/capture_script.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/cam/capture_script.cpp b/src/cam/capture_script.cpp\nindex 6278a152..695de37b 100644\n--- a/src/cam/capture_script.cpp\n+++ b/src/cam/capture_script.cpp\n@@ -150,7 +150,9 @@ int CaptureScript::parseScript(FILE *script)\n \t\tstd::string section = eventScalarValue(event);\n \n \t\tif (section == \"frames\") {\n-\t\t\tparseFrames();\n+\t\t\tret = parseFrames();\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n \t\t} else {\n \t\t\tstd::cerr << \"Unsupported section '\" << section << \"'\"\n \t\t\t\t << std::endl;\n", "prefixes": [ "libcamera-devel", "v3", "2/2" ] }