Patch Detail
Show a patch.
GET /api/patches/16351/?format=api
{ "id": 16351, "url": "https://patchwork.libcamera.org/api/patches/16351/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16351/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220623232210.18742-7-laurent.pinchart@ideasonboard.com>", "date": "2022-06-23T23:22:03", "name": "[libcamera-devel,06/13] gstreamer: Rename queued requests queue to queuedRequests_", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7e4ce79ab358544ee9c3432432b896db143bce35", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16351/mbox/", "series": [ { "id": 3214, "url": "https://patchwork.libcamera.org/api/series/3214/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3214", "date": "2022-06-23T23:21:57", "name": "gstreamer: Queue multiple requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3214/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16351/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16351/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3365BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jun 2022 23:22:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 451C665651;\n\tFri, 24 Jun 2022 01:22:39 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A0F065641\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jun 2022 01:22:31 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22693DD;\n\tFri, 24 Jun 2022 01:22:31 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656026559;\n\tbh=ppGZ8deBlgpt1OXy2Tb99DwXpDsPR0U5NBjBV5Lby2U=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RbILLX4Ae3LAhiTkpeVBhMQLFg35BC93hIKiRcLJje9M0N6CjOpG7Qugpk85H30iC\n\tXoB+cz6Ak8u8bExJ3D9Tv7D8df8eC1oxCi7EHuOS4Nx3/ggoR9XZH4O3NwZ/diD6kx\n\tbPBZ3SPaeT0mb3gR6rmTTfmcF/Hc8pWeowGFanIIqv19D3eGheGWzL7qYgkr5DNQhW\n\tAnuX0che6rjd7Sz8ofUmP15HTuBtONPel3BTvmu/nE0M80jLJvZtP7KpiK3ShYZAwX\n\tdV1UZHF8hCnstHGkutlDnRGzNmgxg1YtkcaULzG7cOFNiwwnAZlNxIfdM6/tvjSH/I\n\tYtf92fvquAtZg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656026551;\n\tbh=ppGZ8deBlgpt1OXy2Tb99DwXpDsPR0U5NBjBV5Lby2U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cfiKYLh2BcKdhqPHkAtHrKFluEFOB3P3393ljDLZKChyxn71DjZ9ZKAlKhOc9oBtg\n\tAJfntpoDD5H9Dy/uKMbbBrnNdZ8c+3rHnT77vZ4td1h+5aBz0yS+rrolBv1Q12pobN\n\t0scBhhZ9jnLYyUFRWW3SHLGi+xndzKaj7TmSm/JQ=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cfiKYLh2\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jun 2022 02:22:03 +0300", "Message-Id": "<20220623232210.18742-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220623232210.18742-1-laurent.pinchart@ideasonboard.com>", "References": "<20220623232210.18742-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 06/13] gstreamer: Rename queued requests\n\tqueue to queuedRequests_", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tVedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To prepare for the addition of a completed requests queue, rename the\nexisting queued requests queue from requests_ to queuedRequests_.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex a1fab71d4f09..02fc913764f8 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -108,7 +108,7 @@ struct GstLibcameraSrcState {\n \tstd::shared_ptr<Camera> cam_;\n \tstd::unique_ptr<CameraConfiguration> config_;\n \tstd::vector<GstPad *> srcpads_;\n-\tstd::queue<std::unique_ptr<RequestWrap>> requests_;\n+\tstd::queue<std::unique_ptr<RequestWrap>> queuedRequests_;\n \tguint group_id_;\n \n \tvoid requestCompleted(Request *request);\n@@ -155,8 +155,8 @@ GstLibcameraSrcState::requestCompleted(Request *request)\n \n \tGST_DEBUG_OBJECT(src_, \"buffers are ready\");\n \n-\tstd::unique_ptr<RequestWrap> wrap = std::move(requests_.front());\n-\trequests_.pop();\n+\tstd::unique_ptr<RequestWrap> wrap = std::move(queuedRequests_.front());\n+\tqueuedRequests_.pop();\n \n \tg_return_if_fail(wrap->request_.get() == request);\n \n@@ -311,7 +311,7 @@ gst_libcamera_src_task_run(gpointer user_data)\n \t\tGLibLocker lock(GST_OBJECT(self));\n \t\tGST_TRACE_OBJECT(self, \"Requesting buffers\");\n \t\tstate->cam_->queueRequest(wrap->request_.get());\n-\t\tstate->requests_.push(std::move(wrap));\n+\t\tstate->queuedRequests_.push(std::move(wrap));\n \n \t\t/* The RequestWrap will be deleted in the completion handler. */\n \t}\n", "prefixes": [ "libcamera-devel", "06/13" ] }