Patch Detail
Show a patch.
GET /api/patches/16339/?format=api
{ "id": 16339, "url": "https://patchwork.libcamera.org/api/patches/16339/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16339/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220623144736.78537-2-tomi.valkeinen@ideasonboard.com>", "date": "2022-06-23T14:47:30", "name": "[libcamera-devel,RFC,v1,1/7] py: cam.py: Fix multi camera capture without -C", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "24d97a3c618c9821153a9addb6af56de54d9ef52", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16339/mbox/", "series": [ { "id": 3213, "url": "https://patchwork.libcamera.org/api/series/3213/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3213", "date": "2022-06-23T14:47:29", "name": "Python bindings event handling", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3213/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16339/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16339/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93E75BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jun 2022 14:48:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F40965636;\n\tThu, 23 Jun 2022 16:48:02 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2EDB56048F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jun 2022 16:47:58 +0200 (CEST)", "from deskari.lan (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 577B06BB;\n\tThu, 23 Jun 2022 16:47:57 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655995682;\n\tbh=OK+Gtkm8vVSc70bwKYeTSCzxUdJjJrN89szkRE52YsM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=VFptnshIQC8aiPtiw3ndPLpq3tE0SGjiC4rCPkLjAJkikKIA8v841Ku90s1UM6MYG\n\t0f9R3lk47YLikHfnNQNgKoFsm1QSEyJnXg+KpG+bfGQWznSZv8ur1K+3kOkHjOnahM\n\tpGrEFLyIcr3kY0AM6T9PnivDzxcjBwaFbdgpv3Wc6Ki+OvpuKJCgp4bAdPW1RjXHpO\n\tN7dcRKdnGiEVLtG8E6mJBsxBXf8XZYoB+dZa5GOj8Ge+qxgX0i4FqTnO1xqe943Ftt\n\tEWl7Lr4nxXWyEKbTKRQNyeX3u+WyAvIXTzLRiYMYya+J2JdpFQwJFPtoBxEscH2dqH\n\tfA65EBRy+esTw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655995677;\n\tbh=OK+Gtkm8vVSc70bwKYeTSCzxUdJjJrN89szkRE52YsM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o5s79w2jQwgFDqol4AARzU6kbbTYN/lrcdMFTgXteMfHmL9/ltDKlYr0LeR9WFMtN\n\tked7jMDXtsjj+xlKrcMTGrwtiltH1IwG08bZRa7sxI2B4aDomu/fBH9bULEdhxv4jG\n\tILtEBaSBZhofhVJWOElZo9/x2Sz6rat9Siw9eNqI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"o5s79w2j\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Thu, 23 Jun 2022 17:47:30 +0300", "Message-Id": "<20220623144736.78537-2-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220623144736.78537-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220623144736.78537-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC v1 1/7] py: cam.py: Fix multi camera capture\n\twithout -C", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "-C flag is supposed to affect only the camera that was previously\ndefined in the arguments. That's not the case, and, e.g.:\n\ncam.py -c2 -C -c3\n\ncauses camera 3 to start capturing, but it stops after the initial\nRequests have been completed.\n\nFix the issue by filtering out camera contexts that do not have -C\ndefined.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/cam/cam.py | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex 2ae89fa8..733e9ae5 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -434,6 +434,8 @@ def main():\n if args.info:\n ctx.do_cmd_info()\n \n+ contexts = [ctx for ctx in contexts if ctx.opt_capture > 0]\n+\n if args.capture:\n state = CaptureState(cm, contexts)\n \n", "prefixes": [ "libcamera-devel", "RFC", "v1", "1/7" ] }