Patch Detail
Show a patch.
GET /api/patches/16333/?format=api
{ "id": 16333, "url": "https://patchwork.libcamera.org/api/patches/16333/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16333/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220623124140.610241-1-javierm@redhat.com>", "date": "2022-06-23T12:41:40", "name": "[libcamera-devel] py: Honour the pycamera meson option", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "49c3e30002c7c9f1d6b119d96255863b70d0bbf3", "submitter": { "id": 95, "url": "https://patchwork.libcamera.org/api/people/95/?format=api", "name": "Javier Martinez Canillas", "email": "javierm@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16333/mbox/", "series": [ { "id": 3211, "url": "https://patchwork.libcamera.org/api/series/3211/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3211", "date": "2022-06-23T12:41:40", "name": "[libcamera-devel] py: Honour the pycamera meson option", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3211/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16333/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16333/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DB83BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jun 2022 12:41:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75F0165632;\n\tThu, 23 Jun 2022 14:41:52 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 409D56048F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jun 2022 14:41:50 +0200 (CEST)", "from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-635-DqbVtH33OBeb8sLbzEVbXg-1; Thu, 23 Jun 2022 08:41:48 -0400", "by mail-wm1-f69.google.com with SMTP id\n\tk15-20020a7bc40f000000b0039c4b7f7d09so1367348wmi.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jun 2022 05:41:47 -0700 (PDT)", "from minerva.home (205.pool92-176-231.dynamic.orange.es.\n\t[92.176.231.205]) by smtp.gmail.com with ESMTPSA id\n\tz14-20020a056000110e00b0021b93a483dbsm10002412wrw.32.2022.06.23.05.41.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 23 Jun 2022 05:41:45 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655988112;\n\tbh=Om5f50DzL1yhUL7KQHBwH/bwf0tcyBN6v/y4WeNOKcU=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=wptC7LuW+YO7sY44uqo8de7Jvw/CZu2zma+CMjfnqh3MNlS+uTbgvVABKAnnRSLoP\n\tCXv+dNhG8o/gBD+nGPjbciZR1mfgK8S1zaOuwSrgr+Zr9mdZoUtxwp311bpZboIi59\n\tSzlRW4jZ2CHJ1TmWJlqrmmokn2nHExLArl5IcGppn0AcpDo9Ik02Pv1YBdCU9IvzNR\n\t7a5QPrIF6wrSWc3huYGRaky0OWCgLs0BRwea10Oq0FRwB+usv2p4Wv4UBodo7ugj8a\n\tIqGMl5v0Ie/OTYm0vkRjExiAWU47mD50XKqvLV21qejDInPpxGRrfmbRwnUm4VSp1y\n\tfgntLWhAZZX3A==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1655988109;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=4BwhNfyyaMHwKCsNF1g8+7HI10ar8InJ+ydPD9GS64c=;\n\tb=NDxkaU5q58vvwZ3ttJhf+MIL/Q3ftK1nw6PDy3BWmrrgKThLFmP2YgwxEZ9IS1ujn4vXIM\n\tTYoiHi8C/5KNqsOMNc/mOdWJFUmIsvqI/cjOOU1AHiF5eJli1BZl12CNzrDDG7IWaPjgVo\n\thTnAp/7HHmsL7XHGEVamvbl++AZs+mo=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"NDxkaU5q\"; \n\tdkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com" ], "X-MC-Unique": "DqbVtH33OBeb8sLbzEVbXg-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=4BwhNfyyaMHwKCsNF1g8+7HI10ar8InJ+ydPD9GS64c=;\n\tb=LZA0oH7Jw+0XLwNzFjyHQ8Ky2dhCbsp+qtbcMV5fycBKy/dihNXItL1ulXqJ+oKP8z\n\tIEna1wHuVTSIFji3GmABG+uj3RSa3YAVQvbtb6sN3LCeB1kXDPzr08IEStKOMEd/RS+O\n\tTMz39/0T2riW95CrG888l16ZlvfCi/fPBUKzaJNBMy0zYTkTPuVVR2FUh53KhtSendAg\n\t+aPaD8mGpxNxcCRegV+ypIo9W1RnsOxvq2spGQDJfuV+ddxN+7JpVgFZ5i2yQPGJ3xhB\n\t1yJdIrL3p4Otg0lf1oHub4mtLTR6kLy46rc0x7iMnNGPnKm9/Zy2poyKb28S7NyZW5H7\n\tp30A==", "X-Gm-Message-State": "AJIora8+grmpn607xhjW8arq4/wXc2ETtkla2EUqcjGUA/Jrgmjo7m9f\n\trH4t0eo2j8deMgdhVkF5nDwSiyHqQq/AtrBAp2BJmJK9Tijqr3bIF3++DSd+sKZwoDU/7XhB3fk\n\tIEsAIX/FIsc1ws34in3o2mS0MfcUIwDNbGi9+Kzf8n/rEFUtftwBdS5HriH7cepTbHZQZmpOSJw\n\tco+vBMCi/j", "X-Received": [ "by 2002:a05:6000:12c3:b0:21a:3795:70ac with SMTP id\n\tl3-20020a05600012c300b0021a379570acmr7915564wrx.175.1655988105802; \n\tThu, 23 Jun 2022 05:41:45 -0700 (PDT)", "by 2002:a05:6000:12c3:b0:21a:3795:70ac with SMTP id\n\tl3-20020a05600012c300b0021a379570acmr7915550wrx.175.1655988105565; \n\tThu, 23 Jun 2022 05:41:45 -0700 (PDT)" ], "X-Google-Smtp-Source": "AGRyM1sovN57LPUCS3pYfgM1r+1mhTbGD7S589JFRajGGppV4sJv8GiyFbQ74hs2C8bZ/WSBrq6rHw==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 23 Jun 2022 14:41:40 +0200", "Message-Id": "<20220623124140.610241-1-javierm@redhat.com>", "X-Mailer": "git-send-email 2.36.1", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "Subject": "[libcamera-devel] [PATCH] py: Honour the pycamera meson option", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Javier Martinez Canillas via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Javier Martinez Canillas <javierm@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libcamera Python bindings are attempted to be built unconditionally,\neven when there is a meson feature option to disable it. Make the meson\nbuild file in the sub-dir to exit earlier if pycamera has been disabled.\n\nSigned-off-by: Javier Martinez Canillas <javierm@redhat.com>\n---\n\n src/py/libcamera/meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex eb8845388692..5efae1baec8c 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -2,7 +2,7 @@\n \n py3_dep = dependency('python3', required : get_option('pycamera'))\n \n-if not py3_dep.found()\n+if get_option('pycamera').disabled() or not py3_dep.found()\n pycamera_enabled = false\n subdir_done()\n endif\n", "prefixes": [ "libcamera-devel" ] }