Patch Detail
Show a patch.
GET /api/patches/16311/?format=api
{ "id": 16311, "url": "https://patchwork.libcamera.org/api/patches/16311/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16311/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220622123706.2946976-2-chenghaoyang@google.com>", "date": "2022-06-22T12:37:01", "name": "[libcamera-devel,v5,1/6] Allow inheritance of FrameBuffer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d78749ed8f4bce5d76dcf6ebd520776e9ce97bdb", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16311/mbox/", "series": [ { "id": 3203, "url": "https://patchwork.libcamera.org/api/series/3203/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3203", "date": "2022-06-22T12:37:00", "name": "Add CrOS JEA implementation", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3203/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16311/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16311/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41004BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 22 Jun 2022 12:37:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08A8C65638;\n\tWed, 22 Jun 2022 14:37:21 +0200 (CEST)", "from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com\n\t[IPv6:2607:f8b0:4864:20::62b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F768633A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Jun 2022 14:37:19 +0200 (CEST)", "by mail-pl1-x62b.google.com with SMTP id k14so3796931plh.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Jun 2022 05:37:19 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(21.160.199.104.bc.googleusercontent.com. [104.199.160.21])\n\tby smtp.gmail.com with ESMTPSA id\n\tj3-20020a170903024300b0016378bfeb90sm12684038plh.227.2022.06.22.05.37.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 22 Jun 2022 05:37:15 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655901441;\n\tbh=PlvX2QWQRbicnMrHz9Z55Ms0++yLpMpOKgEWarYoELM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HuwSo1MJIcm1I592J8jgV6OoVeP2kVyDsbqce2PZTXUN83WLan/InaTd9TeXUYmy/\n\teaX9dX+0ymKW1CIvbYHQSKQINzgriyFsJnw1kZcMjNsmWAf+JnlQxdjHVkGdwS4v9j\n\t9lx1A2SntE7ttkv47isSclptFy47tSCsvt0nlxjtbNT7ltxHanVSvtqzLV1xYwk902\n\tXKTkO51niIDyVIRqznrYHb0jzaIc0RiaAhVTSjWrdC/lqe0bqTdXA0psLJAzh7pCcq\n\tnnBd9jgTV+gXwaz3hSZOz26QA9UxFlKd06ikf/wZXi+iMhghFbWdg0OpJDTkIvZtu6\n\tKRq1g+MgQaJgQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=x7CV/ccAxMp4SFNTCghxmX/NsH4mhEjOsWki4hGZhYw=;\n\tb=KuXks4S+qKouCnuW1C8wbJxvLbVztKWsCR+4ZMfl+22oJXfB68cTxWgs/ZOkJNbQvA\n\tmrZ3pxsOWnSHD8ho4GniTCRBwciuJVb5Q2To6cCCZJp2nh1eP/K6IX9qRstxBSUX1MDv\n\tvlsT+HtSnfAUj6cdO65Pf9/pBjTuC2cDeOX2w=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"KuXks4S+\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=x7CV/ccAxMp4SFNTCghxmX/NsH4mhEjOsWki4hGZhYw=;\n\tb=6OzhBPmsibgXnKscs6y7BlqF0JbSfE8NRh1ti6lz1LjLIIu5ZxYYQQ656HTz31TiGu\n\tGqYCYvjxFwYklb6QmB197kxZsfCagXyNBAy2Od8CAVv1tPn8EPFU+SOHEfYC4XpGYCuT\n\t6mWorcNFalgP1SSdgURoUoeXUCzXSpmrn+q30jALhaSU3K1TyKT8eQHHiJFjIXm7J/KR\n\tnLhWbnAoDU+BUNNa+1oEeNLPrVwTPbs7gM3dfLAF3TBJtJpJ+lor4/YJH75UsR1+4RIn\n\tIcU+CnP8jbLObS2Z1M3azQyQpaU02U3Z1mXb9NU2B8q8fIr37usTE3cLJC9OIvdloEE+\n\twSOA==", "X-Gm-Message-State": "AJIora96iJ7XDPFEMyex/7dBSHnXWqdjmgpFFpx3oBECs1XXavLsJa4b\n\tdaD19QSTGDFsQ1E9ojmaySieSSCXYJbiqg==", "X-Google-Smtp-Source": "AGRyM1vvyCeHisjG+T9KD/OXfKINxZrc3j32JfEM2PU5JLXg221sieVu0i6B90PJJtD5ep3fzxlA5w==", "X-Received": "by 2002:a17:90a:dc82:b0:1ea:c77d:c9a4 with SMTP id\n\tj2-20020a17090adc8200b001eac77dc9a4mr48179951pjv.197.1655901437652; \n\tWed, 22 Jun 2022 05:37:17 -0700 (PDT)", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 22 Jun 2022 12:37:01 +0000", "Message-Id": "<20220622123706.2946976-2-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.37.0.rc0.104.g0611611a94-goog", "In-Reply-To": "<20220622123706.2946976-1-chenghaoyang@google.com>", "References": "<20220622123706.2946976-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 1/6] Allow inheritance of FrameBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nTo add buffer_handle_t access in android, this patch allows inheritance\nof FrameBuffer to add a derived class in android.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/framebuffer.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 3b1118d1..e6c769b4 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -46,7 +46,7 @@ private:\n \tstd::vector<Plane> planes_;\n };\n \n-class FrameBuffer final : public Extensible\n+class FrameBuffer : public Extensible\n {\n \tLIBCAMERA_DECLARE_PRIVATE()\n \n@@ -61,6 +61,7 @@ public:\n \tFrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);\n \tFrameBuffer(std::unique_ptr<Private> d,\n \t\t const std::vector<Plane> &planes, unsigned int cookie = 0);\n+\tvirtual ~FrameBuffer() {}\n \n \tconst std::vector<Plane> &planes() const { return planes_; }\n \tRequest *request() const;\n", "prefixes": [ "libcamera-devel", "v5", "1/6" ] }