Patch Detail
Show a patch.
GET /api/patches/16227/?format=api
{ "id": 16227, "url": "https://patchwork.libcamera.org/api/patches/16227/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16227/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220616080744.548995-2-fsylvestre@baylibre.com>", "date": "2022-06-16T08:07:40", "name": "[libcamera-devel,v2,1/5] pipeline: rkisp1: Support IPA tuning file", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "df7810f0f8e31c7896898afd410dccef3db25f60", "submitter": { "id": 123, "url": "https://patchwork.libcamera.org/api/people/123/?format=api", "name": "Florian Sylvestre", "email": "fsylvestre@baylibre.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16227/mbox/", "series": [ { "id": 3177, "url": "https://patchwork.libcamera.org/api/series/3177/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3177", "date": "2022-06-16T08:07:39", "name": "Add tuning file support for rkisp1 blc algo", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3177/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16227/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16227/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC4D6C3273\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 16 Jun 2022 08:07:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4EF0F65639;\n\tThu, 16 Jun 2022 10:07:53 +0200 (CEST)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3983165631\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 16 Jun 2022 10:07:52 +0200 (CEST)", "by mail-wr1-x42c.google.com with SMTP id o16so793691wra.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 16 Jun 2022 01:07:52 -0700 (PDT)", "from localhost.localdomain (lfbn-nic-1-76-188.w2-15.abo.wanadoo.fr.\n\t[2.15.166.188]) by smtp.gmail.com with ESMTPSA id\n\tr15-20020adff70f000000b002185d79dc7fsm1098868wrp.75.2022.06.16.01.07.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 16 Jun 2022 01:07:50 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655366873;\n\tbh=euV/yF39BpOuZjaJiVY+D+yithOOLhpNiqE2vnFqKmk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wpUeRqrWZwYTPBeY2SJmERPr3VbEPjSIqznbMtoBzlAf+cM5SaxAoENtWIbGteZd0\n\t0fGlTW1vgNH/6xm64bx4v3QePslBRd0Kex3CREM3qlKdQqihv/I9JYifGm2oe+hHdq\n\tRy87tolIpTWIRw975zLuEV6kPZItLwa+Qrl/GVvtmrvwugdg3jv66XpD/r7GPt55+1\n\tcYAaUtnJKC1d64TXu6KNQNAXzob+/w+9fxH54bY0osRXNT86NiaWisbgVXvNDjTKPg\n\tBSGlCvq79Z0QjC6LslAdbuqEvGud8idheCNxXqpfkVvI2sKFgTL7kzwE7rgqoTDX1S\n\t9vkyZCh1nG5TA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=CICC5cmHc9FKneMsR0VtXcUkA4dvYwBf2I3BKGorhfM=;\n\tb=nYFHuv26jQFLi7bRzFs4GsgMfm8WqnCPud8PKSW7o+LWztaitV1/l+jMazNQ57so+M\n\te+jHtaqG/FJcqo5gytJEo1whDR7zqfFBVMUrxBGqpt/dQxu26fSSpxU8VeaJLIXwYb7v\n\t9fdOuFz3kgZjN+64b5OZfVdHrfAXuxA+HQOEvmk3fe/waf/WVYZobrgPNO5QfTIakonp\n\tsa92cN8qn4ZnFkeJZHdrHYrQBqLLrE72AC3Gdk772f2TlzQ9LPegH/bJp9oJwLSoq8UL\n\tiUJJHYBqFYL5uwyI0LySzSTXDqP7S0HZeKpQM2tOpajqewcC7IPcLbG4rCnVfm2/nVOc\n\tQbvA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"nYFHuv26\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=CICC5cmHc9FKneMsR0VtXcUkA4dvYwBf2I3BKGorhfM=;\n\tb=glampjfant9CGUyQORgXr3nZw5h6R96P1oT29hPU6awMN3bdqErWXaB6RJM/W0ypry\n\tZ2PJ7qN7V3W6WPcA7USKYPC/ovllqlZl2dvZAHZM5yWbxd2d3zlnwhDmRDemr/HJ9xLB\n\t0M+PLxLPjumBWZEoiMz7gHPvO9WQNfBD1yOBX/IklPw6QyTSwhgjwaP72e8qahI0PyYG\n\tvzHfry59XsUJwLlcU3qab0vRJadRa6FZOS9KsJlx0dOQNJ1VL8w5qyyeujPM6fPZe8bH\n\thUShCFJMtQ7tem8imd+vlQH7UAh7kN92j0U4dmLjydhT2iVKZ6lX8oLp8mwnhKUhMykX\n\twJ9Q==", "X-Gm-Message-State": "AJIora8o4wPbGnuSGyIlopeSVJArPL7GOzrgn2WAwtp1vypoZShXjwpC\n\tc4Gb+tQxfhfEXsN+CViW91SaMIg82PW2HA==", "X-Google-Smtp-Source": "AGRyM1uxt2lpJVZ8JDd3fLpYHvLI/hPw7BNor+bFkLo+P1gMtAJSPbY7/NdxMGbwsFulmI0ar+LVrw==", "X-Received": "by 2002:a5d:6608:0:b0:21a:374d:786a with SMTP id\n\tn8-20020a5d6608000000b0021a374d786amr1298994wru.418.1655366871456; \n\tThu, 16 Jun 2022 01:07:51 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 16 Jun 2022 10:07:40 +0200", "Message-Id": "<20220616080744.548995-2-fsylvestre@baylibre.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220616080744.548995-1-fsylvestre@baylibre.com>", "References": "<20220616080744.548995-1-fsylvestre@baylibre.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/5] pipeline: rkisp1: Support IPA\n\ttuning file", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Florian Sylvestre via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Florian Sylvestre <fsylvestre@baylibre.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Allow the usage of a Yaml IPA tuning file that is either defined by\nthe sensor name (sensor_name.yaml) or defined by\nLIBCAMERA_RKISP1_TUNING_FILE environment variable.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 4b3d2cf7..96bf09e3 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -322,7 +322,18 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n \tipa_->paramsBufferReady.connect(this, &RkISP1CameraData::paramFilled);\n \tipa_->metadataReady.connect(this, &RkISP1CameraData::metadataReady);\n \n-\tint ret = ipa_->init(IPASettings{ \"\", sensor_->model() }, hwRevision);\n+\t/*\n+\t * The API tuning file is made from the sensor name unless\n+\t * the environment variable overrides it.\n+\t */\n+\tstd::string IPATunigFile;\n+\tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RKISP1_TUNING_FILE\");\n+\tif (!configFromEnv || *configFromEnv == '\\0')\n+\t\tIPATunigFile = ipa_->configurationFile(sensor_->model() + \".yaml\");\n+\telse\n+\t\tIPATunigFile = std::string(configFromEnv);\n+\n+\tint ret = ipa_->init({ IPATunigFile, sensor_->model() }, hwRevision);\n \tif (ret < 0) {\n \t\tLOG(RkISP1, Error) << \"IPA initialization failure\";\n \t\treturn ret;\n", "prefixes": [ "libcamera-devel", "v2", "1/5" ] }