Patch Detail
Show a patch.
GET /api/patches/16198/?format=api
{ "id": 16198, "url": "https://patchwork.libcamera.org/api/patches/16198/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16198/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220612152311.8408-2-laurent.pinchart@ideasonboard.com>", "date": "2022-06-12T15:23:07", "name": "[libcamera-devel,v2,1/5] libcamera: pipeline: simple: Improve debug message on config failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7e7ec6b11199c08936a42e88031fe3a2adb2f6c8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16198/mbox/", "series": [ { "id": 3170, "url": "https://patchwork.libcamera.org/api/series/3170/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3170", "date": "2022-06-12T15:23:06", "name": "libcamera: pipeline: simple: Support scaling on the camea sensor", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3170/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16198/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16198/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7846CC3273\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 12 Jun 2022 15:23:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 944FC6563B;\n\tSun, 12 Jun 2022 17:23:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5412D600F4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 12 Jun 2022 17:23:24 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9083825;\n\tSun, 12 Jun 2022 17:23:23 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655047405;\n\tbh=VyiVX0meUYlRNfln26J7Lo+8p7G4tVTwjxezjqGQMdc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=kd/8CQc67/Q6CiAcddELdhoyHdzg3GAVKhisQ5k+qHf9foTFUANdCPY09YF0FSbWn\n\t9i8FP3nsB+y50KEpHbNWG4hpdQajOvqi3q9SFCP0AMYKYglrlThZDeFyiti8JwW4K3\n\tBlrYat60C62u/nxPkSCbeLyuJyuBo526CWffE19yXzZ+zmMFm/w+RniwSrMu9OH1/W\n\t7nL9SYa7RCa3iqM25T+bDSQ1yjPdTU+loEF8syaEt+WmGvCGXtkPVl1MkukW/hyEYU\n\tgLE4W837Yb8/rGi+hJiYxUSyLuFNYTvBWqMANxMQgjln6H6mt0Tt/Hef9VDZFYK5n5\n\thiWAoOnQE3RPw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655047404;\n\tbh=VyiVX0meUYlRNfln26J7Lo+8p7G4tVTwjxezjqGQMdc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=stO5Ekg1OIP/nxqJC3MkLWywuCWJJsj1TYfvOWXckk0oDHecf1HMF/ZaLCvGbDhM1\n\tYMigVGn7t4IQNDgMwQMxvL91Bwb4WrOKnzP2jfF9aOCo4N42iXerJRFqWtYhb0nJXa\n\tLBy0v5cycDFQuRL4PHH07kqSZzlr69ZMimBTjiAk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"stO5Ekg1\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 12 Jun 2022 18:23:07 +0300", "Message-Id": "<20220612152311.8408-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220612152311.8408-1-laurent.pinchart@ideasonboard.com>", "References": "<20220612152311.8408-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/5] libcamera: pipeline: simple:\n\tImprove debug message on config failure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tBenjamin Schaaf <ben.schaaf@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When pipeline configuration fails, print the format returned by the\nkernel in addition to the one requested by libcamera, to ease debugging.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex de75465eb3b5..efb28ccd97e8 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -939,7 +939,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \t captureFormat.size != pipeConfig->captureSize) {\n \t\tLOG(SimplePipeline, Error)\n \t\t\t<< \"Unable to configure capture in \"\n-\t\t\t<< pipeConfig->captureSize << \"-\" << videoFormat;\n+\t\t\t<< pipeConfig->captureSize << \"-\" << videoFormat\n+\t\t\t<< \" (got \" << captureFormat << \")\";\n \t\treturn -EINVAL;\n \t}\n \n", "prefixes": [ "libcamera-devel", "v2", "1/5" ] }