Patch Detail
Show a patch.
GET /api/patches/16192/?format=api
{ "id": 16192, "url": "https://patchwork.libcamera.org/api/patches/16192/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16192/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220610120338.96883-4-Rauch.Christian@gmx.de>", "date": "2022-06-10T12:03:37", "name": "[libcamera-devel,v8,3/4] libcamera: controls: Generate fixed- and variable-sized Span Controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "abbda95a9e49e6401aeb5995bb1b3e26a6a73a0c", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16192/mbox/", "series": [ { "id": 3168, "url": "https://patchwork.libcamera.org/api/series/3168/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3168", "date": "2022-06-10T12:03:34", "name": "generate and use fixed-sized Span Control types", "version": 8, "mbox": "https://patchwork.libcamera.org/series/3168/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16192/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16192/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15633BD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Jun 2022 12:03:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF5B16563E;\n\tFri, 10 Jun 2022 14:03:46 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D54565635\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Jun 2022 14:03:42 +0200 (CEST)", "from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1M1Ygt-1o10wI3Azr-0031az; Fri, 10 Jun 2022 14:03:41 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654862626;\n\tbh=UqwmX7+yMaOqSyR96KduBQpxFaCTOfHvdMO6MxtFX8g=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dXeJayueG2dOtv9W0Xq54FHYZm1W1BSnDPLAaHiMffBdNid4p3TU5BXu+oRcMLxkr\n\t5IzeJR6P6bHdkA+5fzcvTJhZdbpYsfBgUX5SOFhGkmGCPlSlnLQp7CXH9Us4lI1aZN\n\tOFiBqiNJNZLoDz+sUlfCQp8HFD7I6KvfyvA4uNbBGwsggcqWpVBQkunQfo3oIFMhyI\n\thLGh97U7b+xiX6NOB/LuxcHZZk/cVrL4AtKCcvo8wsm/Q20fxub0ImrxhF6pXT07yC\n\tXGN71FumkWE89OHq3mxZa72VhTZuiMF1Vh5XHi/8kYzSuKms0nqJ17pPyVg6B61/Ey\n\t5XThRgmxX2JYg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1654862622;\n\tbh=UqwmX7+yMaOqSyR96KduBQpxFaCTOfHvdMO6MxtFX8g=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=YeRheBFekjIUDYppK2setFQbTgYj1n4uFZyzPI5yJzvnSB3kF06nyzb/Jv+D4jpwK\n\t5br2J1fOcdlvThohRf8XpogMVxchX74QUBWcAyqQBaXsXgH6aCDwADwY/DIUq1nif1\n\twT3F9HsM1vze77Livmjgcashl1OoCruHYPOznW5E=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"YeRheBFe\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 10 Jun 2022 13:03:37 +0100", "Message-Id": "<20220610120338.96883-4-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220610120338.96883-1-Rauch.Christian@gmx.de>", "References": "<20220610120338.96883-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:BTulCx1S+bFhonHqBTaBanSOVXgY3fdkv7aDzDlABF7hSnZjF2F\n\tIlGlrouEh3yCj7oetaqcNal9MCYgxfzGEunTICCLoqBssxaIT4CRXo5pTdpk/uZPe0OPjdP\n\tubTKsfJjwyHv9N1mZfPyhx2A4D2HpTWEUaH1g0z5EYqSIz6hH9+OekcJBAwjXaRIzo+PtR7\n\t2N2of5Zd/I2uVZpk+vCTQ==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:Hjhxtm99Vo8=:qgNSD+dI6AJhhwbyQOHi2t\n\tbG6fw4TG7pmCOevStFAcG7oXMDkssr3ED921JY0VgRf+29fXGjQK76JCd+j09dykeCa4C3Sau\n\t/2RFgboWRNFBIsLzlaMd+75aiwdIzs4nMCcIoeIsM8uImJuKUn0Iv5S25WplrHdkq7swAS5K3\n\tPWSMOrlr+v5yAqA/rReuhiuQ9J54sgUFiqo+ueekkbLaxsXOpkFjPZdMW5fFEP+dtGZW1HIl/\n\tyODO3xiQOVxgS1pBdikvg/5oS8XDAXXSfyLLeUhhMfmqYqinxna5qS2U3A954gVSK2Zc6Vwxe\n\tFh/1Zgb2TbkwztTwn2RfkvroPwL/qBmq5CkneVgxvftMsHHfUMuR99T1vaVwUDyCuVtqqnOY9\n\tiZHzBNhp5es9tR/XlO2bTWITeGI5m8gALhzCapJT5rsPxfRT46RcYABxNITIG82QE14IqPzyM\n\tu55od1l5Bcv1GNI7h0smwzqmdIeekU6kG8IIMTqLs+xweqet1a85JO4amCasQWZ904gcz925R\n\tBsCjDl/mHktEbEa0Wz1shhjKvy9Dawa0VtN8R8Q8dIxHFwc3Rst2gpyZmLhdREwp+1wLqqEAv\n\tCm8a2dtBhsxDqWPzk6xAHfA41Jp8C6A1QwIG5tsgjKf1RTTxnxXBW3cRgHfZD/odntmPGXTht\n\tVuy9mdo1ices3n4IFgUvqr+0N77Bw46Jm4qGXHY54UJj6eJQWRUgG1/kCvWmtPwpphYLXPirK\n\trO6MfHyK5bBl1NbxzYNDaWPfjgfBsZlQNKaQIz4nDPvi+sCUdz5P6kG2L7mVBp83lNCtcVhp2\n\tWVKnr4w8kXlHmcb2rrECWnHcxRigu5a6HK0JkKKkF+FMRWjhjD7bfjaZsLrsvViGOGniMGQlv\n\tx4jsGsysVHuSq5jLGYGb6ZnLmeWUDVPdDrCCkfqKyUsC2+gxaAihE6zAThWwsmamEgD8/Lxcb\n\ti3OunYPrsGXQo9+hWV02QxMXEat/6Y3mvxRHDjxa/mpnFqSxLDUfB34LXCrIPVZEIVCGGfKJx\n\t3Wo+WOz1C8Lh0jIcEXFwcUa+ydQ0Br82Psz8v/MomBT3UA0gCgTqmeGSVnE5/AAeZzH6e4m/y\n\tofKDjeEsrLWIqxcaaEszOu6XvVqQ8uWskNOQeJhPkPq3C7jtX0Cz/4G6Q==", "Subject": "[libcamera-devel] [PATCH v8 3/4] libcamera: controls: Generate\n\tfixed- and variable-sized Span Controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This defines Controls with a 'size' as either variable-sized Span<T> or as\nfixed-sized Span<T,N>.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n utils/gen-controls.py | 32 ++++++++++++++++++++++----------\n 1 file changed, 22 insertions(+), 10 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 3f99b5e2..46ba4394 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -7,6 +7,8 @@\n # gen-controls.py - Generate control definitions from YAML\n\n import argparse\n+from functools import reduce\n+import operator\n import string\n import sys\n import yaml\n@@ -22,6 +24,24 @@ def format_description(description):\n return '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n\n\n+def get_ctrl_type(ctrl):\n+ ctrl_type = ctrl['type']\n+ ctrl_size_arr = ctrl.get('size')\n+\n+ if ctrl_type == 'string':\n+ return 'std::string'\n+ elif ctrl_size_arr is not None:\n+ if len(ctrl_size_arr) > 0:\n+ # fixed-sized Span\n+ ctrl_span_size = reduce(operator.mul, ctrl_size_arr)\n+ return f\"Span<const {ctrl_type}, {ctrl_span_size}>\"\n+ else:\n+ # variable-sized Span\n+ return f\"Span<const {ctrl_type}>\"\n+ else:\n+ return ctrl_type\n+\n+\n def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n * \\\\enum ${name}Enum\n@@ -50,11 +70,7 @@ ${description}\n name, ctrl = ctrl.popitem()\n id_name = snake_case(name).upper()\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span<const %s>' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n@@ -135,11 +151,7 @@ def generate_h(controls):\n\n ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span<const %s>' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n", "prefixes": [ "libcamera-devel", "v8", "3/4" ] }