Patch Detail
Show a patch.
GET /api/patches/16168/?format=api
{ "id": 16168, "url": "https://patchwork.libcamera.org/api/patches/16168/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16168/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220604185939.29163-14-laurent.pinchart@ideasonboard.com>", "date": "2022-06-04T18:59:38", "name": "[libcamera-devel,RFC,v2,13/14] ipa: raspberrypi: Replace tabs with spaces in tuning data files", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "e5ea42059c8f912924c244a2825de92aad5d9d91", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16168/mbox/", "series": [ { "id": 3161, "url": "https://patchwork.libcamera.org/api/series/3161/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3161", "date": "2022-06-04T18:59:25", "name": "Replace boost JSON parser with libyaml in Raspberry Pi IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3161/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16168/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16168/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5AAC3C326B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jun 2022 19:00:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D028B65648;\n\tSat, 4 Jun 2022 21:00:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B4CD65648\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jun 2022 21:00:19 +0200 (CEST)", "from pendragon.ideasonboard.com (85-76-79-203-nat.elisa-mobile.fi\n\t[85.76.79.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D07266D4;\n\tSat, 4 Jun 2022 21:00:17 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654369221;\n\tbh=Glf9pjjGnzIfbfULE+Zq+A8HaL9XSI9VV/ERWec7nYo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=FxC+Ire+6k32uaEtmJes+s22yFj+zwlreFuqt0lWC1XEV8Wxxar13WiI2WOYv2dRv\n\t8XRAsPLBZVabQPp4OivGZM9lvUE4FIGNrJVsPGipgGs6AYgCQFZK9rK388T3X+Ic60\n\tcw1hCHFjb7RPCk2yQU7U2skZ+kBPGuhzOh1/4UMubrABaphFAZL/OmYNCO4fs2ywgl\n\tOnhIA4zo6itslHjimBdE6xQkGEgx2Fg71k0naLCquMUOkrYYKLr06aJ4owj95i62B4\n\tLKxcJJYi8WOnqaWtMUMu60nGoDgCGqPEHKlI2gCFnPadUQqX9N+9VBz2LMFnnBqY93\n\t1RQpsRVRnaMdg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1654369218;\n\tbh=Glf9pjjGnzIfbfULE+Zq+A8HaL9XSI9VV/ERWec7nYo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Of3r0K1SMKQ0HlEjC1jvqlL8Mh4WHkDJBHL863BWmuhGirUjs0URD0qth4g/SrOh8\n\tJnKKxoq8CTOP9rUAJsXwudyw2fPEfXTqYPV/YiDTGsaWXijrt35+Oh/ACxhm6lFCa9\n\t14rVLsbg/WU9Y7h/qtt1sIq4JoxZ+I0FZv1+zxYI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Of3r0K1S\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jun 2022 21:59:38 +0300", "Message-Id": "<20220604185939.29163-14-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220604185939.29163-1-laurent.pinchart@ideasonboard.com>", "References": "<20220604185939.29163-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v2 13/14] ipa: raspberrypi: Replace\n\ttabs with spaces in tuning data files", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Tuning data files mostly use spaces for indentation, with occasional\nstray tabs. Use spaces consistently. This allows parsing the tuning\nfiles with libyaml, preparing to replace the dependency on boost.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/data/imx219.json | 8 ++++----\n src/ipa/raspberrypi/data/imx219_noir.json | 10 +++++-----\n src/ipa/raspberrypi/data/imx290.json | 18 +++++++++---------\n src/ipa/raspberrypi/data/imx477.json | 8 ++++----\n src/ipa/raspberrypi/data/imx477_noir.json | 10 +++++-----\n src/ipa/raspberrypi/data/ov5647.json | 10 +++++-----\n src/ipa/raspberrypi/data/ov5647_noir.json | 12 ++++++------\n src/ipa/raspberrypi/data/se327m12.json | 6 +++---\n 8 files changed, 41 insertions(+), 41 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\nindex de59d9363be4..4e24c5d57da1 100644\n--- a/src/ipa/raspberrypi/data/imx219.json\n+++ b/src/ipa/raspberrypi/data/imx219.json\n@@ -189,10 +189,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/imx219_noir.json b/src/ipa/raspberrypi/data/imx219_noir.json\nindex 9a3f03ec86f4..1835ec3df63b 100644\n--- a/src/ipa/raspberrypi/data/imx219_noir.json\n+++ b/src/ipa/raspberrypi/data/imx219_noir.json\n@@ -31,7 +31,7 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n@@ -121,10 +121,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/imx290.json b/src/ipa/raspberrypi/data/imx290.json\nindex 20b45c1684c2..1363bab71340 100644\n--- a/src/ipa/raspberrypi/data/imx290.json\n+++ b/src/ipa/raspberrypi/data/imx290.json\n@@ -29,11 +29,11 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n-\t\"speed\": 0.2,\n+ \"speed\": 0.2,\n \"metering_modes\":\n {\n \"matrix\":\n@@ -150,14 +150,14 @@\n \"rpi.ccm\":\n {\n \"ccms\":\n-\t[\n+ [\n {\n-\t\t\"ct\": 3900, \"ccm\":\n-\t\t[\n-\t\t 1.54659, -0.17707, -0.36953, -0.51471, 1.72733, -0.21262, 0.06667, -0.92279, 1.85612\n-\t\t]\n-\t }\n-\t]\n+ \"ct\": 3900, \"ccm\":\n+ [\n+ 1.54659, -0.17707, -0.36953, -0.51471, 1.72733, -0.21262, 0.06667, -0.92279, 1.85612\n+ ]\n+ }\n+ ]\n },\n \"rpi.focus\":\n {\ndiff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\nindex d07febd283ed..0f389661c246 100644\n--- a/src/ipa/raspberrypi/data/imx477.json\n+++ b/src/ipa/raspberrypi/data/imx477.json\n@@ -189,10 +189,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/imx477_noir.json b/src/ipa/raspberrypi/data/imx477_noir.json\nindex 7d4fc7dab9fd..a379d780d966 100644\n--- a/src/ipa/raspberrypi/data/imx477_noir.json\n+++ b/src/ipa/raspberrypi/data/imx477_noir.json\n@@ -31,7 +31,7 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n@@ -121,10 +121,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\nindex 24bc06fb6114..e65f9385d970 100644\n--- a/src/ipa/raspberrypi/data/ov5647.json\n+++ b/src/ipa/raspberrypi/data/ov5647.json\n@@ -189,10 +189,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\n@@ -203,7 +203,7 @@\n [\n 0, 0.16, 1000, 0.165, 10000, 0.17\n ],\n-\t\"base_ev\": 1.25\n+ \"base_ev\": 1.25\n },\n \"rpi.alsc\":\n {\ndiff --git a/src/ipa/raspberrypi/data/ov5647_noir.json b/src/ipa/raspberrypi/data/ov5647_noir.json\nindex 1c628ed13f19..dad73a5e8cd9 100644\n--- a/src/ipa/raspberrypi/data/ov5647_noir.json\n+++ b/src/ipa/raspberrypi/data/ov5647_noir.json\n@@ -31,7 +31,7 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n@@ -121,10 +121,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\n@@ -135,7 +135,7 @@\n [\n 0, 0.16, 1000, 0.165, 10000, 0.17\n ],\n-\t\"base_ev\": 1.25\n+ \"base_ev\": 1.25\n },\n \"rpi.alsc\":\n {\ndiff --git a/src/ipa/raspberrypi/data/se327m12.json b/src/ipa/raspberrypi/data/se327m12.json\nindex 94af2239f700..5b1ac2ce3bf8 100644\n--- a/src/ipa/raspberrypi/data/se327m12.json\n+++ b/src/ipa/raspberrypi/data/se327m12.json\n@@ -334,8 +334,8 @@\n },\n \"rpi.sharpen\":\n {\n-\t\"threshold\": 2.0,\n-\t\"strength\": 0.5,\n-\t\"limit\": 0.5\n+ \"threshold\": 2.0,\n+ \"strength\": 0.5,\n+ \"limit\": 0.5\n }\n }\n", "prefixes": [ "libcamera-devel", "RFC", "v2", "13/14" ] }