Patch Detail
Show a patch.
GET /api/patches/16129/?format=api
{ "id": 16129, "url": "https://patchwork.libcamera.org/api/patches/16129/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16129/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220601231802.16735-4-Rauch.Christian@gmx.de>", "date": "2022-06-01T23:18:01", "name": "[libcamera-devel,v5,3/4] libcamera: controls: Generate fixed- and variable-sized Span Controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e9cbc895d2a50e978afebbdb8545736153ffb9af", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16129/mbox/", "series": [ { "id": 3152, "url": "https://patchwork.libcamera.org/api/series/3152/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3152", "date": "2022-06-01T23:17:58", "name": "generate and use fixed-sized Span Control types", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3152/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16129/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16129/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79CE1C326E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Jun 2022 23:18:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C370E65641;\n\tThu, 2 Jun 2022 01:18:19 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FAA165632\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Jun 2022 01:18:16 +0200 (CEST)", "from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1MfYPY-1nKzrL3JtI-00fzHs; Thu, 02 Jun 2022 01:18:15 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654125499;\n\tbh=ATeKyqRnHw9iVa0bTgA+UNdA5iARog/YOYpAYY2+Gv0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=w/Bwbl2oBcYQMJZbOJudJKCs2wyGQAoZSaxa46aZxIaD3UUbPE032fmN2k71G2eQm\n\tSSNzRt46wdG/unfcbbnSWKPc8uh2bxd+qPoVhyQMnyBUb+rZlEG1I77ujHXFJn+Uph\n\taje0oomV09w/aWFd4LRjcWOQpkbwW0xbSnV9I4HUOTS8mdqorgYmqD0sPT/riqoRsb\n\t/RXoDPi6YU56yhg3Y1Ol1Wm/YjMCz1InhCdaKhak8BngxEPMSvbotuNBEWWlFALoH+\n\tq0132JAXJ+ssN92gLRMLeWCQWIuHRal5HfR+uZ7nUb/GM+2YVuNVS5RRaed/g+SCGj\n\tkcRMhr9v0cV5w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1654125496;\n\tbh=ATeKyqRnHw9iVa0bTgA+UNdA5iARog/YOYpAYY2+Gv0=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=ED6AoOGmKmjE/qfhSJwV2ACzqDIZ3eDxTap0UnEUtKr6nNLp9+8IY3ovKqf5t29+7\n\toPod3HNTMui8dHbO18hUr8J0Vz0R3G43Kdeonjk7D2RZjf2aN7nhFC80qORwoghZs2\n\t2Yg9BR4N/yLR5w9EHFxHwCvgASlggFNvYSZIx9lY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"ED6AoOGm\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Jun 2022 00:18:01 +0100", "Message-Id": "<20220601231802.16735-4-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220601231802.16735-1-Rauch.Christian@gmx.de>", "References": "<20220601231802.16735-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:khRDyhaHiqHSr2y8aNEkv0c27ogfUhr32bCokD3fpXQbhYx8ORC\n\tImGdYdaDRuhSGyKvcZLhXLbKGs0XhkXvcAFpGKW5UL1MAl2B1CLeUvX/aHsUhM8YAzTn23O\n\tjfvC8awfxYqpXH1oSDMDdw8fvBg8qZQy/AIrXRBUMS73uXF5pn/HYhSlsRCHF7HsGuGqEbU\n\tdf/ZwUDVbVJRhy+YJUk1w==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:/g4I5oSw5/s=:AdIhL/1EBP39/x1yd27y8N\n\t0U6G8Xbqqj9Kp1GfRWm2ekMvXqYaNzJF9NE1KAhRcmjA0dJMMYylfhtdTTATlXo5Be1QDCPDz\n\to7f661cjIrBmOKDFnt052WC1EhZa61DfBExCV92EaxdFC+DJrMN5gwQ+2Hd4+NW5aX9lFYQqD\n\t5ExqCKboDW4BwOUXzC9iRJdbf/7bWFaRdU65Y2kSqIfw2VwIZnqlLcjAcarhShoWzVtofervY\n\t59wJWL/1pt7NkDdbo/FAbsQJP4kvy6l/Lcm+S7wKYrF4rnuksJJeakS3XNHzrt1UcNSyKJnBS\n\t1bicsKR8sbM+WlL7n8RZ837nLFinH0o571Poej4R0j8Y88TPC4AnNgdBn3VDGPFHISqDDlW7U\n\tbBxrsDRrOuz1bjf5Id6L2Zf6aOK3jmIgh6pl3bZBpzwR4GjQE8o0oBYz4P7rrNclyLTf7fliL\n\toQhY5YNlSdm5W2HnzHfo2iNnKm67fdh6c9aCmXsQfjO/lZxwYn7HY2Aa1a2qTVUFNUU7gByK4\n\tYadbblYWbE0rBBQWZy5Ez3XQ87evB1n3zhzm7l7K+baR8P2QHo4rd0G/BfOGFfzfOM2BodDlT\n\tJbn3tQsFEz0vv3DtgHbUSbStuHsjRZuoquCwKWqXdtA/i7tHBpobZGbWkuH7ajdkeZ22ymZ09\n\tUwJz/qdvSSOv8XuvTNvKpzkeIGKiY8cMcK2zR4yH8stqlJ/EPMtRuJAyDxmKtCjbcsp2C6pNC\n\tcs3/5UbZtH/ekf7jhy9OGWWG+QchuRa+yz2p2cNVfUgB1TSqA4e7lIJ/VLzKWqF4K2XTgL/ah\n\tcZ0VtAgFPCDz3cuN8KnzvzWy+a5pIP5xdqjyp675jadrKRe3ho3nwU6nT5qL8SFAlm/o4V8jN\n\t9kqIMl421jOXVkqcMXbsLNOgrN3GIoJ51sFzYeUvFFoQ80vrQsbkraBk4Dy2KqIcEqWnX+F6O\n\ttcARSj1CnVe8XerGtU2FOlAeXIU3dTzP9ogEwhQk/bOHIdxxs+Yd+QVrLE4O/fPxlXK0BHvh9\n\t+2CUFNzIvQRnLwjYkORei0oZ6ALbQHqRhxmIUSzB+iKMpD4f3u4V1DD3iPj+KIHKpTaFcdzPA\n\tmJzTvjRP0V3sdYLvjxeeSBpZYU3aduGTfZitPTcqUbGif8CeoRn97quvA==", "Subject": "[libcamera-devel] [PATCH v5 3/4] libcamera: controls: Generate\n\tfixed- and variable-sized Span Controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This defines Controls with a 'size' as either variable-sized Span<T> or as\nfixed-sized Span<T,N>.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n utils/gen-controls.py | 32 ++++++++++++++++++++++----------\n 1 file changed, 22 insertions(+), 10 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 3f99b5e2..c9e79a22 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -7,6 +7,7 @@\n # gen-controls.py - Generate control definitions from YAML\n\n import argparse\n+import math\n import string\n import sys\n import yaml\n@@ -22,6 +23,25 @@ def format_description(description):\n return '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n\n\n+def get_ctrl_type(ctrl):\n+ ctrl_type = ctrl['type']\n+ ctrl_size_arr = ctrl.get('size')\n+ ctrl_is_span = ctrl_size_arr is not None\n+\n+ if ctrl_type == 'string':\n+ return 'std::string'\n+ elif ctrl_is_span:\n+ ctrl_span_size = math.prod(ctrl_size_arr) if len(ctrl_size_arr) > 0 else None\n+ if ctrl_span_size:\n+ # fixed-sized Span\n+ return f\"Span<const {ctrl_type}, {ctrl_span_size}>\"\n+ else:\n+ # variable-sized Span\n+ return f\"Span<const {ctrl_type}>\"\n+ else:\n+ return ctrl_type\n+\n+\n def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n * \\\\enum ${name}Enum\n@@ -50,11 +70,7 @@ ${description}\n name, ctrl = ctrl.popitem()\n id_name = snake_case(name).upper()\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span<const %s>' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n@@ -135,11 +151,7 @@ def generate_h(controls):\n\n ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span<const %s>' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n", "prefixes": [ "libcamera-devel", "v5", "3/4" ] }