Patch Detail
Show a patch.
GET /api/patches/16090/?format=api
{ "id": 16090, "url": "https://patchwork.libcamera.org/api/patches/16090/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16090/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220527144447.94891-19-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-27T14:44:35", "name": "[libcamera-devel,v3,18/30] py: unittests: Fix test_select()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "89b4c65ef9fc5898242bf33d12eb42412199d910", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16090/mbox/", "series": [ { "id": 3146, "url": "https://patchwork.libcamera.org/api/series/3146/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3146", "date": "2022-05-27T14:44:17", "name": "More misc Python patches", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3146/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16090/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16090/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D112BD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 May 2022 14:45:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C99636564E;\n\tFri, 27 May 2022 16:45:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7E5465651\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 May 2022 16:45:13 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B4A33C16;\n\tFri, 27 May 2022 16:45:13 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653662731;\n\tbh=H/Jb8v2zc35+zHkHqMvpT5G28m2rg6O/MIcSOu1mjLo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=mQA4iUZ11tNCHCLTPciYZYErv99z0C3wZHtC8nuDFEqpd//tRWg4xjnVONusd2Dhf\n\tccmWCH+vThcVhB2HwikMjoyruHRCGAjiOSvizU6O3vpusHNLSNEUJ8shHqRLd0EUQv\n\t8lJO3jJjhbhXtu+KsW4CDHUh6eG0UqXvmn48bLpeTcv/tCYJNLhU9wy+aKH2jJIdSZ\n\tipkM6lEr9anaUjC3sXHCOtuC9/95/FjYIu5homC+LbRfr861SHC6Cmw8vZ6QIdi6ZS\n\tmkfhCDPYcWoWOaxHT3HWnPa3y0Ej5iXqO1LyfAxrSOXFvb0B0Qe/WcLOXHUELg7oHB\n\tHS3yeDikkO77w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653662713;\n\tbh=H/Jb8v2zc35+zHkHqMvpT5G28m2rg6O/MIcSOu1mjLo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=D82FgnI2vMm6k3pKCA4HJC1aTI2CsuOBFnejOn1Ek2ac36eTp3Tvo05wkJDhcOOLU\n\tiaXg3pePMBgUQs9DLmf93FcYqDjCpduqwchXJOrFTSPGHaIFUb9IM7NMEyrNy99GnK\n\tY/cpT+j/77vyxEwfOh//Sm0t3wvaHmPyZFODcYQg=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"D82FgnI2\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Fri, 27 May 2022 17:44:35 +0300", "Message-Id": "<20220527144447.94891-19-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 18/30] py: unittests: Fix test_select()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The test_select() current uses self.assertTrue(len(ready_reqs) > 0) to\nsee that cm.get_ready_requests() returns something. This is not always\nthe case, as there may be two eventfd events queued, and the first call\nto cm.get_ready_requests() returns all the requests, and thus the second\ncall returns none.\n\nRemove the self.assertTrue(len(ready_reqs) > 0) assert.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n test/py/unittests.py | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 45b35223..33b35a0a 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -287,8 +287,6 @@ class SimpleCaptureMethods(CameraTesterBase):\n \n ready_reqs = cm.get_ready_requests()\n \n- self.assertTrue(len(ready_reqs) > 0)\n-\n reqs += ready_reqs\n \n if len(reqs) == num_bufs:\n", "prefixes": [ "libcamera-devel", "v3", "18/30" ] }