Patch Detail
Show a patch.
GET /api/patches/16076/?format=api
{ "id": 16076, "url": "https://patchwork.libcamera.org/api/patches/16076/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16076/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220527144447.94891-6-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-27T14:44:22", "name": "[libcamera-devel,v3,05/30] py: Fix None value in ControlType enum", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9441ebe2a9791898cb2095d0596d6d2f9813a14c", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16076/mbox/", "series": [ { "id": 3146, "url": "https://patchwork.libcamera.org/api/series/3146/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3146", "date": "2022-05-27T14:44:17", "name": "More misc Python patches", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3146/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16076/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16076/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F95DBD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 May 2022 14:45:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 586196564D;\n\tFri, 27 May 2022 16:45:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E95A65637\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 May 2022 16:45:07 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8855EFD1;\n\tFri, 27 May 2022 16:45:06 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653662713;\n\tbh=gB8wORxbh5RCxUzoZ/j9CClyLL96wF3CiB0KpQy77Fw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=JOOW3pCOqAa9dr7YKMFzKdp9YhV6G2ZfOVMhOjNyq7fO9ACVKZOfMQCQkLW3PNd1E\n\tB8zWo05TP4rb+CXRa5zlVOADbBb2FH0gngfRwMVV06XY+getYvm4cqjjnIt92VPgYZ\n\tm8vy6wrA/P4SVNIro0xtEk7ryDVeUGykYx/7VbCZqYIFO4Xhr6NymNDOZtMQnyFtSy\n\t085Qq1xY0dZNSmtxep3r3qJlJ4f594oxSYq5uXh7r3ARCHVPsC0ld393h31K8kjYik\n\tttHoCBtPhi5IUmflhS8knkQoX+nz/6GoEjxi4lDGYMkq0at1jmRS56laQY7I4zPoj3\n\tdDHeWCh7e9Jpw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653662706;\n\tbh=gB8wORxbh5RCxUzoZ/j9CClyLL96wF3CiB0KpQy77Fw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HK2kAtBBKCLS0LPZZUH9sooKYhbHt6BRZfOoGaNWyhU8D+x9zzMcB/Ph32WVp2V+Y\n\tjzbT3ZQG0StPLAr9hBn1I/0x7Vho5ECbJus5j9FhcFoSPrUa/Ts76V8H/kh60/Icsf\n\toFSNCxnyui9b96tkOsB2RbCWT40qLisIohT5d5fw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HK2kAtBB\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Fri, 27 May 2022 17:44:22 +0300", "Message-Id": "<20220527144447.94891-6-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 05/30] py: Fix None value in\n\tControlType enum", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "\"None\" is not a valid name for an enum value, so change it to \"Null\".\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/libcamera/py_enums.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/py/libcamera/py_enums.cpp b/src/py/libcamera/py_enums.cpp\nindex e55318f1..96d4beef 100644\n--- a/src/py/libcamera/py_enums.cpp\n+++ b/src/py/libcamera/py_enums.cpp\n@@ -22,7 +22,7 @@ void init_py_enums(py::module &m)\n \t\t.value(\"Viewfinder\", StreamRole::Viewfinder);\n \n \tpy::enum_<ControlType>(m, \"ControlType\")\n-\t\t.value(\"None\", ControlType::ControlTypeNone)\n+\t\t.value(\"Null\", ControlType::ControlTypeNone)\n \t\t.value(\"Bool\", ControlType::ControlTypeBool)\n \t\t.value(\"Byte\", ControlType::ControlTypeByte)\n \t\t.value(\"Integer32\", ControlType::ControlTypeInteger32)\n", "prefixes": [ "libcamera-devel", "v3", "05/30" ] }