Patch Detail
Show a patch.
GET /api/patches/16060/?format=api
{ "id": 16060, "url": "https://patchwork.libcamera.org/api/patches/16060/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16060/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220526110009.13874-2-laurent.pinchart@ideasonboard.com>", "date": "2022-05-26T11:00:07", "name": "[libcamera-devel,1/3] utils: checkstyle: Run the ClangFormatter last", "commit_ref": "c58ac2f4984f63e8b9cbbdfea04fb3d8ecfccac1", "pull_url": null, "state": "accepted", "archived": false, "hash": "995bc7b03cbe71ea844dab27b7caade56944c8a6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16060/mbox/", "series": [ { "id": 3142, "url": "https://patchwork.libcamera.org/api/series/3142/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3142", "date": "2022-05-26T11:00:06", "name": "libcamera: checkstyle: Improve header formatter", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3142/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16060/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16060/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59F86C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 May 2022 11:00:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FB3265668;\n\tThu, 26 May 2022 13:00:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5273D65660\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 May 2022 13:00:19 +0200 (CEST)", "from pendragon.lan (unknown [37.120.212.14])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E2A53898\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 May 2022 13:00:18 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653562821;\n\tbh=LvRr4TI/9314rdTW4KMcUAJ33PEj+tUuERzn4R7Ick8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=O4+39/JZr79DW9yW++xDMZkrxldFHXTH4QXQzunwDTXqr6ZduxIJURrueIeaJ2S+n\n\tzmVuooHGoBnN4Bvg7qp1fx79fOBQtr1hNnqK0ma1CMEPSlBDH5D+CF09NOkSin2WGt\n\tOt5KxaprmaogcZOIhzyE52U6wju8b8mvieA7d6KYc3MIB31dbMOWBK4ULsrWgD43t2\n\tdebWpJHSs1W6rjftQfhVNh7KZhfscv36Kl4XIiQiwFRjCdbzBMmvAARp7DCMelFWPg\n\t23nT8974v2qq6ob0/xYnoGvpugg6T45fDTR0hc74kxl3R/NqSQj1/ZO9AGY/rIi/I8\n\tOHx+W08UK+VbQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653562819;\n\tbh=LvRr4TI/9314rdTW4KMcUAJ33PEj+tUuERzn4R7Ick8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=jm7Bf4qf5bV6EjZ2OW0sNTw4UfpJbdsfgAslbASW7zUP/WOJGWBDSUWBjeI8jDbGG\n\taZh28f/akjsmHIuiR4EHyNbVr7pa8Ec9uE6pxQ1X+FJAH8Ogf5e8p1boBreXta1okX\n\tLgsUTJruTOQzOUe3NaVPTscw8jg4cp32vUx1uQXo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jm7Bf4qf\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 26 May 2022 14:00:07 +0300", "Message-Id": "<20220526110009.13874-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220526110009.13874-1-laurent.pinchart@ideasonboard.com>", "References": "<20220526110009.13874-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] utils: checkstyle: Run the\n\tClangFormatter last", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IncludeOrderFormatter will be extended with more formatting rules\nthat should be applied before clang-format gets run, as it will\ninfluence its output.\n\nAdd a priority mechanism for formatters, and give a negative priority to\nthe ClangFormatter to make it run last.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/checkstyle.py | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 835f2a9fcd71..66af96abd402 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -279,6 +279,8 @@ class ClassRegistry(type):\n newclass = super().__new__(cls, clsname, bases, attrs)\n if bases:\n bases[0].subclasses.append(newclass)\n+ bases[0].subclasses.sort(key=lambda x: getattr(x, 'priority', 0),\n+ reverse=True)\n return newclass\n \n \n@@ -568,6 +570,7 @@ class Formatter(metaclass=ClassRegistry):\n \n class CLangFormatter(Formatter):\n patterns = ('*.c', '*.cpp', '*.h')\n+ priority = -1\n \n @classmethod\n def format(cls, filename, data):\n", "prefixes": [ "libcamera-devel", "1/3" ] }