Patch Detail
Show a patch.
GET /api/patches/1605/?format=api
{ "id": 1605, "url": "https://patchwork.libcamera.org/api/patches/1605/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1605/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190704130347.9372-3-kieran.bingham@ideasonboard.com>", "date": "2019-07-04T13:03:40", "name": "[libcamera-devel,3/4] qcam: Add the version string to the title", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a10c4bb74fbe4b30e33f9e835d423f83be3867ba", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1605/mbox/", "series": [ { "id": 399, "url": "https://patchwork.libcamera.org/api/series/399/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=399", "date": "2019-07-04T13:03:38", "name": "[libcamera-devel,1/4] Documentation: Make the project brief more expressive", "version": 1, "mbox": "https://patchwork.libcamera.org/series/399/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1605/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1605/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E9B861569\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jul 2019 15:03:52 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18C18E21;\n\tThu, 4 Jul 2019 15:03:52 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562245432;\n\tbh=kPRmPVpIuL84OkffCwEfKcOsAHxi5Nm7ZfvAeUM88XQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hp9wf1WyXxNGBaFsb53lU5X/gxfP3jQpQS6OQZGjmsxRAMd828jfm5LNkWWIP0jgq\n\tSrsSkBDsKO2e9C34P9f1o0WUlse2VN+T5LcuQw/4FBtOLefzoH4t838nIeTTiycYm6\n\tSAm7VNypfIiTVbcLdpQkGCsskaCO7G45FFoThReA=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 4 Jul 2019 14:03:40 +0100", "Message-Id": "<20190704130347.9372-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190704130347.9372-1-kieran.bingham@ideasonboard.com>", "References": "<20190704130347.9372-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/4] qcam: Add the version string to the\n\ttitle", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 04 Jul 2019 13:03:52 -0000" }, "content": "Provide the version string reported by the libcamera library on the qcam\ntest utility.\n\nThis helps confirm the exact version of the library that is being used\nwhile testing.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 8 ++++++++\n src/qcam/main_window.h | 2 ++\n 2 files changed, 10 insertions(+)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 16b123132dd9..61d7aa9469f0 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -14,6 +14,7 @@\n #include <QTimer>\n \n #include <libcamera/camera_manager.h>\n+#include <libcamera/version.h>\n \n #include \"main_window.h\"\n #include \"viewfinder.h\"\n@@ -25,6 +26,7 @@ MainWindow::MainWindow(const OptionsParser::Options &options)\n {\n \tint ret;\n \n+\tsetWindowTitle();\n \tviewfinder_ = new ViewFinder(this);\n \tsetCentralWidget(viewfinder_);\n \tviewfinder_->setFixedSize(500, 500);\n@@ -50,6 +52,12 @@ MainWindow::~MainWindow()\n \tCameraManager::instance()->stop();\n }\n \n+void MainWindow::setWindowTitle()\n+{\n+\tQMainWindow::setWindowTitle(\"QCam : \"\n+\t\t+ QString::fromStdString(libcamera::version.toString()));\n+}\n+\n int MainWindow::openCamera()\n {\n \tCameraManager *cm = CameraManager::instance();\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex fe565cbcb460..b30a86768efc 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -33,6 +33,8 @@ public:\n \t~MainWindow();\n \n private:\n+\tvoid setWindowTitle();\n+\n \tint openCamera();\n \n \tint startCapture();\n", "prefixes": [ "libcamera-devel", "3/4" ] }