Patch Detail
Show a patch.
GET /api/patches/16045/?format=api
{ "id": 16045, "url": "https://patchwork.libcamera.org/api/patches/16045/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16045/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220525222503.6460-3-laurent.pinchart@ideasonboard.com>", "date": "2022-05-25T22:25:00", "name": "[libcamera-devel,2/5] libcamera: base: log: Replace stderr with std::cerr in documentation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3681350ea7306ec0d1c838429924f8b8af16fde9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16045/mbox/", "series": [ { "id": 3140, "url": "https://patchwork.libcamera.org/api/series/3140/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3140", "date": "2022-05-25T22:24:58", "name": "libcamera: Add colors to the log", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3140/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16045/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16045/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AC0CC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 May 2022 22:25:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7FFD6566C;\n\tThu, 26 May 2022 00:25:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CBFD60422\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 May 2022 00:25:12 +0200 (CEST)", "from pendragon.ideasonboard.com (ip-109-40-242-63.web.vodafone.de\n\t[109.40.242.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17BF7BB3;\n\tThu, 26 May 2022 00:25:12 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653517516;\n\tbh=PoqoB8GftOOmh7JVMbF/JdLM/JKTkM537VnYpQ2xOhI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=cx9COkJn/fXljPwwhIq1kgfzjSzg+X1PXezMWEKMz8kUUsC2uHJyvKar0ixWVgBYd\n\tuc7N1mPrAjiR/+60XsakoNcZpg5CxZadsNBlvU7qB/0hvMcpdEDvK4Sq8ANB5Faq8s\n\t0BpSRTrKCd/JULmX3bLQFOpyMnhbFPMgZHq1ZADmemcEEGVyzw3KU/BIE2gAdw2ghN\n\tGSv8349gfzzeUjPgK/kSvZRr7QjsNQ4EHKaMV2e18XyiK+34W1LDheAiUe1Kh11phL\n\tLOIZvbpOf3imZuZbqj9vY65vILpa0WTcxcvZA0n7P0RoJf84VXrHse9ydBpGL5HrUj\n\tiCQbJNHasQ1Wg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653517512;\n\tbh=PoqoB8GftOOmh7JVMbF/JdLM/JKTkM537VnYpQ2xOhI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YB5Va64/h0kR1sD3ydLkCHb9yflLBOOFTB9BMbNIyJmt6Hy115mHrx7wrQ0ZxMUxz\n\tULtZEmrpE51HvGtUywvOxJjMxMqFMpqa8bfiIlKoKiQmjl5qhaZ4BMUErCv4wF+Smx\n\tuVpMeACUhBTwyzvjO5yNQ/An/wiAIX1+Zx0ZQTd4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YB5Va64/\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 26 May 2022 01:25:00 +0300", "Message-Id": "<20220525222503.6460-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220525222503.6460-1-laurent.pinchart@ideasonboard.com>", "References": "<20220525222503.6460-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/5] libcamera: base: log: Replace stderr\n\twith std::cerr in documentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "While std::cerr and stderr both target the same file by default, this\nmay be overridden by applications. Update the documentation to use\nstd::cerr instead of stderr to be accurate.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/base/log.cpp | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex df84ba4e8328..9ae62368a54d 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -46,11 +46,11 @@\n * their category are output to the log, while other messages are silently\n * discarded.\n *\n- * By default log messages are output to stderr. They can be redirected to a log\n- * file by setting the LIBCAMERA_LOG_FILE environment variable to the name of\n- * the file. The file must be writable and is truncated if it exists. If any\n+ * By default log messages are output to std::cerr. They can be redirected to a\n+ * log file by setting the LIBCAMERA_LOG_FILE environment variable to the name\n+ * of the file. The file must be writable and is truncated if it exists. If any\n * error occurs when opening the file, the file is ignored and the log is output\n- * to stderr.\n+ * to std::cerr.\n */\n \n /**\n@@ -527,7 +527,8 @@ Logger::Logger()\n * If the LIBCAMERA_LOG_FILE environment variable is set, open the file it\n * points to and redirect the logger output to it. If the environment variable\n * is set to \"syslog\", then the logger output will be directed to syslog. Errors\n- * are silently ignored and don't affect the logger output (set to stderr).\n+ * are silently ignored and don't affect the logger output (set to std::cerr by\n+ * default).\n */\n void Logger::parseLogFile()\n {\n", "prefixes": [ "libcamera-devel", "2/5" ] }