Patch Detail
Show a patch.
GET /api/patches/16025/?format=api
{ "id": 16025, "url": "https://patchwork.libcamera.org/api/patches/16025/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16025/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220524114610.41848-20-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-24T11:46:10", "name": "[libcamera-devel,v2,19/19] py: Use ln --relative to create symlinks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6bca7d66cf769a7029e18d4c8cd604074d92f102", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16025/mbox/", "series": [ { "id": 3134, "url": "https://patchwork.libcamera.org/api/series/3134/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3134", "date": "2022-05-24T11:45:51", "name": "More misc Python patches", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3134/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16025/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16025/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0AAFC3278\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 May 2022 11:46:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AB2965694;\n\tTue, 24 May 2022 13:46:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E20B065688\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 May 2022 13:46:40 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B17BAEC;\n\tTue, 24 May 2022 13:46:39 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653392816;\n\tbh=7pmVMp5PW1ecMtR5ggP9gGJEZqiuysjK3w7X+uzXjzg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=HYkoEsaw2U3xF8XNUqglTgq7sXwnS7jL64DtnlU16DXpjJgv4dUMchKS1j49qyEFv\n\tjirRbzI+iOxwVp95gP6jZebh5F4ZOvSMzvGYn3Htx1Cmd5BHiDDgj20Ov40oGto0cu\n\tOWfngh9In2cYGvPlA5bUgi0P9Sjv0Rm+VmEru6uQ4IXvbsMIfwZighfLa2DSDt7Wmn\n\tOSMDz+BHzIA9b8I7Ww+tK5ERFgNo0jNua8YYam/Vav3ec09GrUmvlJRqTyE5QCz1Wx\n\tB789dJtun+hpCiWhfLhBLrBHoStsag7upNKxlvt/CTx4CKX/UW61M1ScQj8fSLS4ac\n\t5TVH+qOHYtzKQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653392799;\n\tbh=7pmVMp5PW1ecMtR5ggP9gGJEZqiuysjK3w7X+uzXjzg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AeEFjaVOw+u1/1GuwctIpHio/k8X47ipPWONlVLF1NikrQGquqjHn5Dlt82EpqFX5\n\tvmMhK0Tzeum3zqoQVhrlU/dYTXBrxwaXmoAF3YdE16iaezPBjSvhViwZdBcB4atclR\n\tkZZ1t+JvJuJjLk2eZY9SRBUrFOUEQS607HpoQ9xg=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AeEFjaVO\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Tue, 24 May 2022 14:46:10 +0300", "Message-Id": "<20220524114610.41848-20-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 19/19] py: Use ln --relative to create\n\tsymlinks", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We create symlinks from the Python bindings build dir to the source dir\nso that 1) the build dir can be used to use the bindings, and 2) to\nallow modifications of the source .py files to be used right away\nwithout rebuilding.\n\nThe symlinks were recently fixed and changed to use absolute paths.\nHowever, absolute paths ruin one main use case I have: using the\nbindings from the build dir via nfs from an ARM device.\n\nSo move back to relative paths, but accomplish this with the --relative\nparameter for ln, instead of guessing the right relative path as was\ndone before the above-mentioned fix.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/libcamera/meson.build | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex e0010353..3219d3df 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -84,11 +84,11 @@ pycamera = shared_module('_libcamera',\n # Create symlinks from the build dir to the source dir so that we can use the\n # Python module directly from the build dir.\n \n-run_command('ln', '-fsT', files('__init__.py'),\n+run_command('ln', '-fsrT', files('__init__.py'),\n meson.current_build_dir() / '__init__.py',\n check: true)\n \n-run_command('ln', '-fsT', meson.current_source_dir() / 'utils',\n+run_command('ln', '-fsrT', meson.current_source_dir() / 'utils',\n meson.current_build_dir() / 'utils',\n check: true)\n \n", "prefixes": [ "libcamera-devel", "v2", "19/19" ] }