Patch Detail
Show a patch.
GET /api/patches/16016/?format=api
{ "id": 16016, "url": "https://patchwork.libcamera.org/api/patches/16016/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16016/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220524114610.41848-10-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-24T11:46:00", "name": "[libcamera-devel,v2,09/19] py: cam: Drop WA_ShowWithoutActivating", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3683a766a3a03a87f8027dae8ffe7ffe6f19aea6", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16016/mbox/", "series": [ { "id": 3134, "url": "https://patchwork.libcamera.org/api/series/3134/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3134", "date": "2022-05-24T11:45:51", "name": "More misc Python patches", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3134/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16016/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16016/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63508C3271\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 May 2022 11:46:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21F0C65671;\n\tTue, 24 May 2022 13:46:45 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2BF965662\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 May 2022 13:46:34 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 281E7A16;\n\tTue, 24 May 2022 13:46:34 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653392805;\n\tbh=98Tl2l7nSb5jbMU+doXcvRwG06fg31CD540El0/whyg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=lIso8v+Ahc/dKVfshL90KvU5c4dPS7CRd7p8inFZbcGoPqace3Bz876vfB69+o6qI\n\tBK3cKf6zrrMXrvoe78ZquhmM7Y13hhBC1oEj4KvFa/SStQ5FNSBObAibDzTerlWtFK\n\t6bjKA+ltWJMaknlhe/v59e0ay1oY9rhwxzApmKCpDtJ/nmxR7dlrwoigwm48t1foNW\n\tA6zh7f3sohCy+CNiqpZqYQnxXGIF+CdDhmA29HUQUXyknENP0Y9Bu3KSmOU7vJwWSq\n\tkGd874GH9A4M6a7day1/P+7JFYoqs8axsewac8j4BY7oyegKDyNyE36f3BTsyp0HRj\n\tDJtHoI+c7RUJw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653392794;\n\tbh=98Tl2l7nSb5jbMU+doXcvRwG06fg31CD540El0/whyg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W3nxvUBToiq2MzSr9nwhdofq3TckokrB7dQvv1rWbeRnvYqwpd8ePYU7721XYjOGM\n\tJvztgWbAq6OrIhKj+LOfcZ5nUBPTIs816Wp4cbwRCpY/GYmM8GCIfA/Zvrsq0bHGjl\n\tJQ2qDepBAR6f+zR2rmo2XZCuxbGBwlF8anipgyUY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"W3nxvUBT\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Tue, 24 May 2022 14:46:00 +0300", "Message-Id": "<20220524114610.41848-10-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 09/19] py: cam: Drop\n\tWA_ShowWithoutActivating", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Drop WA_ShowWithoutActivating from the Qt renderers. I added the flag\nduring development phase as I didn't want the window to take the focus,\nbut it should be removed now.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/cam/cam_qt.py | 1 -\n src/py/cam/cam_qtgl.py | 1 -\n 2 files changed, 2 deletions(-)", "diff": "diff --git a/src/py/cam/cam_qt.py b/src/py/cam/cam_qt.py\nindex 70bdb7bb..03096920 100644\n--- a/src/py/cam/cam_qt.py\n+++ b/src/py/cam/cam_qt.py\n@@ -187,7 +187,6 @@ class QtRenderer:\n for ctx in self.contexts:\n for stream in ctx['streams']:\n window = MainWindow(ctx, stream)\n- window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)\n window.show()\n windows.append(window)\n \ndiff --git a/src/py/cam/cam_qtgl.py b/src/py/cam/cam_qtgl.py\nindex 3fb7dde3..c9e367a2 100644\n--- a/src/py/cam/cam_qtgl.py\n+++ b/src/py/cam/cam_qtgl.py\n@@ -137,7 +137,6 @@ class QtRenderer:\n self.app = QtWidgets.QApplication([])\n \n window = MainWindow(self.state)\n- window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)\n window.show()\n \n self.window = window\n", "prefixes": [ "libcamera-devel", "v2", "09/19" ] }