Patch Detail
Show a patch.
GET /api/patches/15996/?format=api
{ "id": 15996, "url": "https://patchwork.libcamera.org/api/patches/15996/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15996/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220520190106.425386-2-ecurtin@redhat.com>", "date": "2022-05-20T19:01:03", "name": "[libcamera-devel,v9,1/4] cam: event_loop: Rename addEvent to addFdEvent", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "97710b88b9ac0d8859e048c3298f5d02622e2858", "submitter": { "id": 101, "url": "https://patchwork.libcamera.org/api/people/101/?format=api", "name": "Eric Curtin", "email": "ecurtin@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15996/mbox/", "series": [ { "id": 3132, "url": "https://patchwork.libcamera.org/api/series/3132/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3132", "date": "2022-05-20T19:01:02", "name": "Add SDL Sink", "version": 9, "mbox": "https://patchwork.libcamera.org/series/3132/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15996/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15996/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1354C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 May 2022 19:02:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC3E265668;\n\tFri, 20 May 2022 21:02:07 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 200C560440\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 May 2022 21:02:06 +0200 (CEST)", "from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-85-tgzC3h3aPxi42ajCYhBpGA-1; Fri, 20 May 2022 15:02:04 -0400", "by mail-wm1-f70.google.com with SMTP id\n\te9-20020a05600c4e4900b00394779649b1so6488662wmq.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 May 2022 12:02:03 -0700 (PDT)", "from p1.Home ([2001:8a0:6724:4500:a69c:e66f:828e:b340])\n\tby smtp.gmail.com with ESMTPSA id\n\tu30-20020adfa19e000000b0020d10a249eesm3337016wru.13.2022.05.20.12.02.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 20 May 2022 12:02:01 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653073327;\n\tbh=r0VndMyAzdRVOz0AwPsURz1bdZLxlL4mF3KHsbRrKA0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=2/ddTDiBTd0GHtK8QoAvCSFIDyJMK5EB10+jHnpAEpmnXd/To6jRvIzYT34ks3qFu\n\tMd28+XJho0i7JWDWIvX/CSZlzQQaZDtItlnqAEScyGm+IO7OuElaoPxjzjAS7Z7NHo\n\tsrwzKK2pM09qYA+zLak+icLBPuPN70L0X4OPmB7S+ZsPKD8CTubTVlm42Q5R2Gpb+p\n\t22wM+jwJ0EjfYq0/FCqULEagi+y3BKaykZv+kCX+z9yFqK4uRcer0+rdKY2+W3aZbs\n\tJzXcFK2T3MqGv/MUNk7OGCha1pjfe4gs7hoPlRD9U7jUkiFyFsijI+wKwUKiKnJ3aV\n\tesT3L494YlpVQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1653073325;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Q0ZKnWxQTh5EMFLbQWkWKhTE3WuJvgfJ/LJIrH00cN4=;\n\tb=TQf1Xura4aGBbeLbJjaNQIO6SAYSWCeyVrsk38QFsBfvGRe00i8/tBVq0plIkl01KbFrcN\n\t2wBlgwzDaxWypqwlJTuiYkKs2JaIh2hm760x9gt6Tbawyuz1cWLb6QAMFfPwWv/HaPBRSL\n\tCI49vsZN/2sjEIzRRsPN+Mwqm60nb4w=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"TQf1Xura\"; \n\tdkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com" ], "X-MC-Unique": "tgzC3h3aPxi42ajCYhBpGA-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Q0ZKnWxQTh5EMFLbQWkWKhTE3WuJvgfJ/LJIrH00cN4=;\n\tb=51qz+ni7m9RN2cv4dSDVhw87JXRJ2ZlepQbzVTgF1CBUB8w5J9igpSlrkc+JFvaUyh\n\t+vp+rnjWXwK+DAOLoW5H68seau1XxzW3kQDaIjhwjBFqFmNELLr3BJrZegvreRN/GJnd\n\tWTd+Z+6bPu2CeQRmph/BhenQrLaUnQQWuqpB+A1agMZpwwJUCpqEWjZmNYPr+0vtdmDv\n\tHA9JIgY+nCS4CKZyyy+w3Ej/UPSOrMZh+1H1fbzRHJC+ZMMOJen3jwPxnRS3z47CE2TZ\n\txvOEMvFUGRIzAxtUnMgZeLhK4zj2YzYqvkh3LZC7jHSBgvyIBBAnwWJpoUL0jnoI7OCJ\n\t6naw==", "X-Gm-Message-State": "AOAM532StK1idsPgbA0Xyc2JYHNnhj9MDr6fnTbpqsHuaGgU6gXr+8sV\n\tpbxPFkjbsBDImTcSCRThPjMe1sVgXk/rInfNJm9ZOshYwL0crwIvgjT3TTDZOv+vrTBa5fFea74\n\tBtrxPMUJWer74SVJl6q+LjrE5n403Im/EMxoL+15AbPRwKcsX8Cax3gj1GAofUGtpZEzxKslEBh\n\tyItBcMZDE3", "X-Received": [ "by 2002:a7b:cf11:0:b0:397:33e3:87b2 with SMTP id\n\tl17-20020a7bcf11000000b0039733e387b2mr6796248wmg.152.1653073322431; \n\tFri, 20 May 2022 12:02:02 -0700 (PDT)", "by 2002:a7b:cf11:0:b0:397:33e3:87b2 with SMTP id\n\tl17-20020a7bcf11000000b0039733e387b2mr6796231wmg.152.1653073322227; \n\tFri, 20 May 2022 12:02:02 -0700 (PDT)" ], "X-Google-Smtp-Source": "ABdhPJx7zKlobN4ImtziXCN1ORC6T1thLx6eao4L3X0gNaq/inRsO0gcfdQI8scI5aezGnIOvgpDHQ==", "To": "libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com, \n\tkieran.bingham@ideasonboard.com, jacopo@jmondi.org, javierm@redhat.com", "Date": "Fri, 20 May 2022 20:01:03 +0100", "Message-Id": "<20220520190106.425386-2-ecurtin@redhat.com>", "X-Mailer": "git-send-email 2.35.3", "In-Reply-To": "<20220520190106.425386-1-ecurtin@redhat.com>", "References": "<20220520190106.425386-1-ecurtin@redhat.com>", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "Subject": "[libcamera-devel] [PATCH v9 1/4] cam: event_loop: Rename addEvent\n\tto addFdEvent", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Eric Curtin via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Eric Curtin <ecurtin@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the addition of addTimerEvent, the naming of addEvent is specific\nto the management of an fd, while the naming is generic.\n\nUpdate the name to make the naming scheme consistent in specifying the\ntype of event to be added.\n\nSigned-off-by: Eric Curtin <ecurtin@redhat.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nTested-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/cam/drm.cpp | 4 ++--\n src/cam/event_loop.cpp | 4 ++--\n src/cam/event_loop.h | 4 ++--\n 3 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/cam/drm.cpp b/src/cam/drm.cpp\nindex 46e34eb5..42c5a3b1 100644\n--- a/src/cam/drm.cpp\n+++ b/src/cam/drm.cpp\n@@ -432,8 +432,8 @@ int Device::init()\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tEventLoop::instance()->addEvent(fd_, EventLoop::Read,\n-\t\t\t\t\tstd::bind(&Device::drmEvent, this));\n+\tEventLoop::instance()->addFdEvent(fd_, EventLoop::Read,\n+\t\t\t\t\t std::bind(&Device::drmEvent, this));\n \n \treturn 0;\n }\ndiff --git a/src/cam/event_loop.cpp b/src/cam/event_loop.cpp\nindex e25784c0..2e3ce995 100644\n--- a/src/cam/event_loop.cpp\n+++ b/src/cam/event_loop.cpp\n@@ -60,8 +60,8 @@ void EventLoop::callLater(const std::function<void()> &func)\n \tevent_base_once(base_, -1, EV_TIMEOUT, dispatchCallback, this, nullptr);\n }\n \n-void EventLoop::addEvent(int fd, EventType type,\n-\t\t\t const std::function<void()> &callback)\n+void EventLoop::addFdEvent(int fd, EventType type,\n+\t\t\t const std::function<void()> &callback)\n {\n \tstd::unique_ptr<Event> event = std::make_unique<Event>(callback);\n \tshort events = (type & Read ? EV_READ : 0)\ndiff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\nindex a4613eb2..79902d87 100644\n--- a/src/cam/event_loop.h\n+++ b/src/cam/event_loop.h\n@@ -34,8 +34,8 @@ public:\n \n \tvoid callLater(const std::function<void()> &func);\n \n-\tvoid addEvent(int fd, EventType type,\n-\t\t const std::function<void()> &handler);\n+\tvoid addFdEvent(int fd, EventType type,\n+\t\t\tconst std::function<void()> &handler);\n \n private:\n \tstruct Event {\n", "prefixes": [ "libcamera-devel", "v9", "1/4" ] }