Patch Detail
Show a patch.
GET /api/patches/1598/?format=api
{ "id": 1598, "url": "https://patchwork.libcamera.org/api/patches/1598/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1598/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<c13f13bb8e0c2fcd35ccac5d78d489add30c54c3.1562185292.git.helen.koike@collabora.com>", "date": "2019-07-03T20:21:54", "name": "[libcamera-devel,2/2] libcamera: pipeline: RKISP1 configure isp output pad", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b51a628b1289f429fccd7572ad32be0ea77dd195", "submitter": { "id": 20, "url": "https://patchwork.libcamera.org/api/people/20/?format=api", "name": "Helen Koike", "email": "helen.koike@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1598/mbox/", "series": [ { "id": 394, "url": "https://patchwork.libcamera.org/api/series/394/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=394", "date": "2019-07-03T20:21:53", "name": "[libcamera-devel,1/2] libcamera: pipeline: RKISP1 remove rockchip-sy-mipi-dphy", "version": 1, "mbox": "https://patchwork.libcamera.org/series/394/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1598/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1598/checks/", "tags": {}, "headers": { "Return-Path": "<helen.koike@collabora.com>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4040D6101B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 Jul 2019 22:22:11 +0200 (CEST)", "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: koike) with ESMTPSA id 9C90928AAFB" ], "From": "Helen Koike <helen.koike@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "laurent.pinchart@ideasonboard.com, kernel@collabora.com,\n\tHelen Koike <helen.koike@collabora.com>", "Date": "Wed, 3 Jul 2019 17:21:54 -0300", "Message-Id": "<c13f13bb8e0c2fcd35ccac5d78d489add30c54c3.1562185292.git.helen.koike@collabora.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<ad664ad979c72b809821f47d5755256d615a17a8.1562185292.git.helen.koike@collabora.com>", "References": "<ad664ad979c72b809821f47d5755256d615a17a8.1562185292.git.helen.koike@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: pipeline: RKISP1 configure\n\tisp output pad", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 03 Jul 2019 20:22:11 -0000" }, "content": "ISP output pad should be set to YUYV8_2X8 for non-bayer output format.\nBayer formats are not listed in RkISP1CameraConfiguration::validate(),\nonly non-bayer are listed, so we can set YUYV8_2X8 directly.\nThis need to be changed if we add support for bayer output with\nlibcamera.\n\nSigned-off-by: Helen Koike <helen.koike@collabora.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 358e2c8..fc04cf8 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -279,13 +279,23 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \n \tLOG(RkISP1, Debug) << \"Sensor configured with \" << format.toString();\n \n-\tLOG(RkISP1, Debug) << \"Configuring ISP with \" << format.toString();\n+\tLOG(RkISP1, Debug) << \"Configuring ISP input pad with \" << format.toString();\n \n \tret = isp_->setFormat(0, &format);\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tLOG(RkISP1, Debug) << \"ISP configured with \" << format.toString();\n+\tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n+\n+\t/* YUYV8_2X8 is required in ISP pad 1 for non-bayer output */\n+\tformat.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8;\n+\tLOG(RkISP1, Debug) << \"Configuring ISP output pad with \" << format.toString();\n+\n+\tret = isp_->setFormat(2, &format);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tLOG(RkISP1, Debug) << \"ISP output pad configured with \" << format.toString();\n \n \tV4L2DeviceFormat outputFormat = {};\n \toutputFormat.fourcc = cfg.pixelFormat;\n", "prefixes": [ "libcamera-devel", "2/2" ] }