Patch Detail
Show a patch.
GET /api/patches/15958/?format=api
{ "id": 15958, "url": "https://patchwork.libcamera.org/api/patches/15958/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15958/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220518131329.66994-9-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-18T13:13:19", "name": "[libcamera-devel,v3,08/18] py: cam.py: exit on exception", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8db3cbce0707dc8a53e3554098b13442ca4fae88", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15958/mbox/", "series": [ { "id": 3122, "url": "https://patchwork.libcamera.org/api/series/3122/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3122", "date": "2022-05-18T13:13:11", "name": "Misc Python bindings patches", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3122/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15958/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15958/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D562C326F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 May 2022 13:14:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBAF565683;\n\tWed, 18 May 2022 15:14:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73D2A65664\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 May 2022 15:13:50 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E551021CB;\n\tWed, 18 May 2022 15:13:49 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652879643;\n\tbh=JZAVTew1P2MIk/cAWcOzxmQ+swz6krcVQuE6EV51mDc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=pMx14f2ls4PXUmZcpmC/kL9GJD2yngA7kDn/NHRRrQPDzCu4FBdwFgNDLy04SGZsC\n\ttE89LY5Mrj0VMyYq5UGxQissZEB0HcpvanebYQa+U25EHHYrADRpn0N1ihpM3pj0tM\n\t2mg4bAHxWMbZX/D9yFDZD7OOGUfq7zQrubiEP29+4fSdcPJxc22LhLsCRJgofmsoSc\n\trv7SbozWrV4wnpqgUHpPokIhM3Gy0ys1XVHdKiZB4K6Fv3sPmU1JmOK0/bwqGme/cx\n\t3oHP9aWk6ViernFYO67sHrWE7tUVswG2UTSBaAYMY4QRpxQgj18ZGB0TL/tdI2QDTs\n\toSg+pvPdjUXRA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652879630;\n\tbh=JZAVTew1P2MIk/cAWcOzxmQ+swz6krcVQuE6EV51mDc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=eWcpjvdOGHlgo2pqltvw4FCbzKkVF4vOLIyhaww1OeIMxlR6TQQHdKZ6f+nvE7udS\n\tCN2LvLtPBrXg/EFrJzre1jnGPo3tcVYkbNMhl4KtFCdJv+ZHRtQzf+ocZeYH7Fpz5p\n\tGfG6P7QlpNIOzKNdbH+TaLtb+hyMRAK6ykNqhlYo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eWcpjvdO\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Wed, 18 May 2022 16:13:19 +0300", "Message-Id": "<20220518131329.66994-9-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 08/18] py: cam.py: exit on exception", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Catch exceptions in the event_handler, as they would get ignored\notherwise. Print the exception and return False so that the main loop\nexits.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/py/cam/cam.py | 23 ++++++++++++++---------\n 1 file changed, 14 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex 012b191c..c7da97d7 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -11,6 +11,7 @@ import binascii\n import libcamera as libcam\n import os\n import sys\n+import traceback\n \n \n class CustomAction(argparse.Action):\n@@ -286,19 +287,23 @@ def capture_start(contexts):\n \n # Called from renderer when there is a libcamera event\n def event_handler(state):\n- cm = state['cm']\n- contexts = state['contexts']\n+ try:\n+ cm = state['cm']\n+ contexts = state['contexts']\n \n- os.read(cm.efd, 8)\n+ os.read(cm.efd, 8)\n \n- reqs = cm.get_ready_requests()\n+ reqs = cm.get_ready_requests()\n \n- for req in reqs:\n- ctx = next(ctx for ctx in contexts if ctx['idx'] == req.cookie)\n- request_handler(state, ctx, req)\n+ for req in reqs:\n+ ctx = next(ctx for ctx in contexts if ctx['idx'] == req.cookie)\n+ request_handler(state, ctx, req)\n \n- running = any(ctx['reqs-completed'] < ctx['opt-capture'] for ctx in contexts)\n- return running\n+ running = any(ctx['reqs-completed'] < ctx['opt-capture'] for ctx in contexts)\n+ return running\n+ except Exception as e:\n+ traceback.print_exc()\n+ return False\n \n \n def request_handler(state, ctx, req):\n", "prefixes": [ "libcamera-devel", "v3", "08/18" ] }