Patch Detail
Show a patch.
GET /api/patches/15928/?format=api
{ "id": 15928, "url": "https://patchwork.libcamera.org/api/patches/15928/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15928/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220517143325.71784-5-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-17T14:33:16", "name": "[libcamera-devel,v2,04/13] py: unittests: fix selector fd use", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5061c8ec01915fdaf1f8755c7b70770e5a94ba55", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15928/mbox/", "series": [ { "id": 3116, "url": "https://patchwork.libcamera.org/api/series/3116/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3116", "date": "2022-05-17T14:33:12", "name": "Misc Python bindings patches", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3116/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15928/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15928/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A723C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 May 2022 14:33:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D500365666;\n\tTue, 17 May 2022 16:33:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B07A06041E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 May 2022 16:33:53 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0ECDFD41;\n\tTue, 17 May 2022 16:33:52 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652798037;\n\tbh=YTNuPtMuA18Tsx5/GaoNG9fs4gImrS8u3Jjoehg356M=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tAu86gNoHb9IehrSf1Ktc0FrHezA38qVy2kGpaYOyDHDC0Qv8CWIOnx3aWuvSyJP+\n\tljM+rqq5bUKNfr7elE0h1eoLvQD+7N9jk2dinaKfjWITdcCdRRWW01WXzlokouI8S/\n\tZiUkkoAaO+ObmJ5qXYgPTOpWgFoU9HGgfLpO1F6kkgxStU3av0mC5XLRQRbffsFcCm\n\tp6ApXGigHmAi5ClpeKkWbAGGxxXLl4trHFONL9n07/ohH56Yq7py+VO6afZc1ncBi3\n\tH4P8rM6cysTWGaMZnZAExwXXnRi/aZnyDYOMQq/xIq7QuQUxM2N2yKhMNs4+ZKw0Pp\n\t5uUoC6M3GewkQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652798033;\n\tbh=YTNuPtMuA18Tsx5/GaoNG9fs4gImrS8u3Jjoehg356M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SXsV+pL6I0tGF/F6Ay+4Kt2RVZ9X0wrOzM8GqRl5GJLqUrF2bPxcbLggeVwxRBaie\n\tSo+YsewEgyY6BIKCA6J/0cZzHy5+si9XlnYTSb4sxlvgDxUE/9i90OMiHn1BpUsSwa\n\tPS9bb3kuPavXnHD0qlS/KlKzvN/xYmIpULareOIM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SXsV+pL6\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Tue, 17 May 2022 17:33:16 +0300", "Message-Id": "<20220517143325.71784-5-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220517143325.71784-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220517143325.71784-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 04/13] py: unittests: fix selector fd\n\tuse", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "pyright complains about passing fileobj to os.read. Indeed, the\nparameter should be an int, but I guess fileobj gets automatically\nconverted. In any case, using the fd is better.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/py/unittests.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex cbc00ff3..9326358d 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -262,8 +262,8 @@ class SimpleCaptureMethods(CameraTesterBase):\n running = True\n while running:\n events = sel.select()\n- for key, mask in events:\n- os.read(key.fileobj, 8)\n+ for key, _ in events:\n+ os.read(key.fd, 8)\n \n ready_reqs = cm.get_ready_requests()\n \n", "prefixes": [ "libcamera-devel", "v2", "04/13" ] }