Patch Detail
Show a patch.
GET /api/patches/15905/?format=api
{ "id": 15905, "url": "https://patchwork.libcamera.org/api/patches/15905/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15905/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220515170253.53075-1-aklhfex@gmail.com>", "date": "2022-05-15T17:02:53", "name": "[libcamera-devel] py: Use Meson python module", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "48e508470a4413cad21e140798a34a71574ba7f0", "submitter": { "id": 122, "url": "https://patchwork.libcamera.org/api/people/122/?format=api", "name": "Chris Mayo", "email": "aklhfex@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15905/mbox/", "series": [ { "id": 3112, "url": "https://patchwork.libcamera.org/api/series/3112/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3112", "date": "2022-05-15T17:02:53", "name": "[libcamera-devel] py: Use Meson python module", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3112/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15905/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15905/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 445D4C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 15 May 2022 17:03:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6085E6565A;\n\tSun, 15 May 2022 19:03:08 +0200 (CEST)", "from avasout-ptp-004.plus.net (avasout-ptp-004.plus.net\n\t[84.93.230.250])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94EFB65655\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 May 2022 19:03:06 +0200 (CEST)", "from mailserver ([84.92.36.196]) by smtp with ESMTP\n\tid qHdznWwSUAcBnqHe0nNfJi; Sun, 15 May 2022 18:03:05 +0100" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652634188;\n\tbh=Vxq8xhjVn04uCvDeWm8Mhuue+xDbqAKLEXWot7L7f3w=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=AWuJ+HhA906d7bQUROkDE9ASexGWZVZVm9aOLd70F4hBbMcqsTc2ENa7Crdar1ekX\n\tnv/Vpw+vFO9X5NVraRoAD8l2HcyGgE3MR/qdEYFJ162cKSbd+ohq9CQDubp2tZj6dS\n\tYxsXbswXyckadvM3McBKGTo++sAPTAEyQ0OXupxs/iCRKr6120r44C9veCNZXfMzy+\n\tGzDc8HsPZjxs22AqfFptCPT6hfLISc1BVDG8aLVan6tkWKRs7afmChT3b2/ekxE5H0\n\tRZWmPyXC0K9DQGXeVI8rpotLoEjsWTbXSYRZ5NR3su/7rHhuhEbJ/Fzxema75ypMkb\n\tAXoouQ30KUm/A==", "X-Clacks-Overhead": "\"GNU Terry Pratchett\"", "X-CM-Score": "0.00", "X-CNFS-Analysis": "v=2.4 cv=JPUoDuGb c=1 sm=1 tr=0 ts=62813249\n\ta=9joFju3sQCjqEQe1SErgvA==:117 a=9joFju3sQCjqEQe1SErgvA==:17\n\ta=x7bEGLp0ZPQA:10 a=YbTMELGUhT8A:10 a=pGLkceISAAAA:8 a=8AHkEIZyAAAA:8\n\ta=udgzeoR2GaE-y9cFH8cA:9", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 15 May 2022 18:02:53 +0100", "Message-Id": "<20220515170253.53075-1-aklhfex@gmail.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CMAE-Envelope": "MS4xfI85J8zw2u6ka3rqzjkOZAj7lopM1Rd+fxY0EM2HNGmxAXIEiDLnql50TWktl93LS9rBIZlIVSsrciiy5C0xYFImjfblBPuNdPciuPxdIdpM1IDSH333\n\tutLN4lwEfRO32g1tNPMuUCJoKnOKMJVq5wmqmkqjU57IDaWzqRGjMb9IxEWLEnRbmdQyrFye+0W4W4eHyMsqTv4BdtVxGYVYXwM=", "Subject": "[libcamera-devel] [PATCH] py: Use Meson python module", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Chris Mayo via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Chris Mayo <aklhfex@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Detection with dependency('python3') can fail because not all\ndistributions install python-3.pc. Installation is invalid if\nsite-packages is not below get_option('libdir').\n\nSigned-off-by: Chris Mayo <aklhfex@gmail.com>\n---\n src/py/libcamera/meson.build | 27 ++++++++++++---------------\n 1 file changed, 12 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex 0cd7c75b..130c1be6 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -1,6 +1,8 @@\n # SPDX-License-Identifier: CC0-1.0\n \n-py3_dep = dependency('python3', required : get_option('pycamera'))\n+pymod = import('python')\n+py3 = pymod.find_installation('python3')\n+py3_dep = py3.dependency(required : get_option('pycamera'))\n \n if not py3_dep.found()\n pycamera_enabled = false\n@@ -44,21 +46,16 @@ pycamera_args = [\n '-DLIBCAMERA_BASE_PRIVATE',\n ]\n \n-destdir = get_option('libdir') / ('python' + py3_dep.version()) / 'site-packages' / 'libcamera'\n+py3.extension_module('_libcamera',\n+ pycamera_sources,\n+ install : true,\n+ dependencies : pycamera_deps,\n+ cpp_args : pycamera_args,\n+ subdir : 'libcamera')\n \n-pycamera = shared_module('_libcamera',\n- pycamera_sources,\n- install : true,\n- install_dir : destdir,\n- name_prefix : '',\n- dependencies : pycamera_deps,\n- cpp_args : pycamera_args)\n-\n-run_command('ln', '-fsT', '../../../../src/py/libcamera/__init__.py',\n- meson.current_build_dir() / '__init__.py',\n- check: true)\n-\n-install_data(['__init__.py'], install_dir : destdir)\n+py3.install_sources('__init__.py',\n+ pure : false,\n+ subdir : 'libcamera')\n \n # \\todo Generate stubs when building. See https://peps.python.org/pep-0484/#stub-files\n # Note: Depends on pybind11-stubgen. To generate pylibcamera stubs:\n", "prefixes": [ "libcamera-devel" ] }