Patch Detail
Show a patch.
GET /api/patches/15892/?format=api
{ "id": 15892, "url": "https://patchwork.libcamera.org/api/patches/15892/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15892/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220511082346.18972-1-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-11T08:23:46", "name": "[libcamera-devel] py: meson: use files() for custom_target input files", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "91da065f51c565abfdffdd6e72e4680268930e8b", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15892/mbox/", "series": [ { "id": 3108, "url": "https://patchwork.libcamera.org/api/series/3108/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3108", "date": "2022-05-11T08:23:46", "name": "[libcamera-devel] py: meson: use files() for custom_target input files", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3108/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15892/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15892/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B903CC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 May 2022 08:24:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B5B665659;\n\tWed, 11 May 2022 10:24:06 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5EF26150F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 May 2022 10:24:03 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00FE5824;\n\tWed, 11 May 2022 10:24:02 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652257446;\n\tbh=z5kJAWgbqhYoijcQSB/bA9JmQTaxvugfOXrEMr9RxXM=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=I/cK5vwT01wkQbGYIPNp16Jl4JfDynVwvBeGq3QlCUBRig0n15SgrOiAOAJOAM7DC\n\tmmHfq13s8PkLK9lP9qmNeXOol4tv9YDRrFXSG+ABJX/+HdPLEPlHQtvKzX7aRifrY6\n\t+YPMKX9ORdC1ajKxahzYkXSCVTWTrlHp/sGfFzhDKuwz9AYYaaas780PRlsNCqDRDr\n\tg0JloIyX7FPff2IVxnN1s4ycsHrlI3MLNFJvpA3kAFef9rBfYLXFbxTadJaGl41kxz\n\tZHjy5foFGxXE5ckWKBEaTvMdNVxwEY9VYC5LOzihqVH1WKj0DM3PpxJDztBYV6FTyt\n\tfJoMaxvTUnyDA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652257443;\n\tbh=z5kJAWgbqhYoijcQSB/bA9JmQTaxvugfOXrEMr9RxXM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=PfZH8Fu3IrPCV4fy0IZ2HuPKmVn/yZavff5b7OmAcjfzHgIVUCImt4wsbIGkAgtzL\n\tkbndw/sB8oeN+IvHnoJPAkDQZjvwUiwSyUqwk6iUibHso4oD2YeyXNXYz8ypM4F265\n\tzRlWW5tcD+y7N10vO3jCldwO10alPkgOXBzD20co=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PfZH8Fu3\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Wed, 11 May 2022 11:23:46 +0300", "Message-Id": "<20220511082346.18972-1-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] py: meson: use files() for custom_target\n\tinput files", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use files() for the input files for the custom_target(). I believe the\ncurrent code works, but perhaps it is safer to use files() here.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/libcamera/meson.build | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex 0cd7c75b..3f7ddf1d 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -17,10 +17,10 @@ pycamera_sources = files([\n 'pymain.cpp',\n ])\n \n-gen_input_files = [\n- meson.project_source_root() / 'src' / 'libcamera' / 'control_ids.yaml',\n+gen_input_files = files(\n+ '../../libcamera/control_ids.yaml',\n 'pyenums_generated.cpp.in',\n-]\n+)\n \n gen_py_control_enums = files('gen-py-control-enums.py')\n \n", "prefixes": [ "libcamera-devel" ] }