Patch Detail
Show a patch.
GET /api/patches/15872/?format=api
{ "id": 15872, "url": "https://patchwork.libcamera.org/api/patches/15872/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15872/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220510115147.19360-33-laurent.pinchart@ideasonboard.com>", "date": "2022-05-10T11:51:29", "name": "[libcamera-devel,32/50] staging: media: imx: imx7-media-csi: Drop error message on alloc failure", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "00ef69f898b3469635de2cc6a9fce9e6bf9e600b", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15872/mbox/", "series": [ { "id": 3106, "url": "https://patchwork.libcamera.org/api/series/3106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3106", "date": "2022-05-10T11:50:57", "name": "staging: media: imx: Prepare destaging of imx7-media-csi", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15872/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15872/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D78FCC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 11:52:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77E416569F;\n\tTue, 10 May 2022 13:52:33 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 709AB6566A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 13:52:24 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81A66D18;\n\tTue, 10 May 2022 13:52:23 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183553;\n\tbh=uk7QSLv2qM0UlTKkUT4qWhdMuv+9FNoxBd4UtAMVX14=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cOjhzEKKS9csVH2hEj0RXHYCvTOpGZIxcvGeqbchqmYNcRRWX4SXrk/32+p3H4HSd\n\tVhSI0zaPyeR85E2ufYISOToNmZWak/D8V4yoMxHxVSwAT4pKGvVHT5HBpCBupjzDkn\n\tO/C5sqr0ENa8COVfCEOkmtO7SsrYxUUkxk8r3VA7FUXy18tTjFFys9jOd8esrg3Vc7\n\taPrb6FMCjktD4JnrT15k/Qa1/sMFsbHbxYds7jE12eST+HWp5F2a7HxMZO01HI7oV2\n\t4P9nMRB3LwXPK6Yyc0i9UqmvZkccopGDuNLLhBdiESmgAl0iUPglocbuYK9PA4et/A\n\tGga8Snm7WASsA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183544;\n\tbh=uk7QSLv2qM0UlTKkUT4qWhdMuv+9FNoxBd4UtAMVX14=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lnWZYK7GsmbTF8kuGsPZhrCgE2T+1B5Rkf6ianutoom90chzgz+Pb0vYKFIkFZ6gD\n\teKpSvL1ueUVepgB+HNZm1XEScL9Jiof4U6Rvr7GjwNRE7RLMJt2/clkZHhvH3VLElS\n\tPDfE481GeXeukVWapCT7U2gWQXwPhvSwq8fr2IEA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lnWZYK7G\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 May 2022 14:51:29 +0300", "Message-Id": "<20220510115147.19360-33-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "References": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 32/50] staging: media: imx:\n\timx7-media-csi: Drop error message on alloc failure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Martin Kepplinger <martin.kepplinger@puri.sm>, kernel@pengutronix.de,\n\tDorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tAlexander Stein <alexander.stein@ew.tq-group.com>,\n\tRui Miguel Silva <rmfrfs@gmail.com>,\n\tPhilipp Zabel <p.zabel@pengutronix.de>, \n\tSteve Longerbeam <slongerbeam@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The kernel memory allocators already complain loudly to the log when\nallocation fails. There's no need for an additional message.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n drivers/staging/media/imx/imx7-media-csi.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex 2106a72ebe85..e5dc9525fa52 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -442,10 +442,8 @@ static int imx7_csi_alloc_dma_buf(struct imx7_csi *csi,\n \tbuf->len = PAGE_ALIGN(size);\n \tbuf->virt = dma_alloc_coherent(csi->dev, buf->len, &buf->phys,\n \t\t\t\t GFP_DMA | GFP_KERNEL);\n-\tif (!buf->virt) {\n-\t\tdev_err(csi->dev, \"%s: failed\\n\", __func__);\n+\tif (!buf->virt)\n \t\treturn -ENOMEM;\n-\t}\n \n \treturn 0;\n }\n", "prefixes": [ "libcamera-devel", "32/50" ] }