Patch Detail
Show a patch.
GET /api/patches/1587/?format=api
{ "id": 1587, "url": "https://patchwork.libcamera.org/api/patches/1587/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1587/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190702232954.27816-3-laurent.pinchart@ideasonboard.com>", "date": "2019-07-02T23:29:54", "name": "[libcamera-devel,2/2] camera: Enable libcamera logging to /var/log/camera", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "634247e718b3780cce36a09c27f56fd9714e3cef", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/1587/mbox/", "series": [ { "id": 391, "url": "https://patchwork.libcamera.org/api/series/391/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=391", "date": "2019-07-02T23:29:52", "name": "Chromium OS platform2 changes for libcamera HAL", "version": 1, "mbox": "https://patchwork.libcamera.org/series/391/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1587/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1587/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51C38610C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 Jul 2019 01:30:21 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EAFBB24B;\n\tWed, 3 Jul 2019 01:30:20 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562110221;\n\tbh=NF++cVCRGvt6gQwe79Ubj17NCdYRR/Og0rWEvOWRk6c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GxL8llcMyfCK/KFFbZSPAYSu13Xp2PvxAlxqfiBOwYtW+J3A1UE+HZ0jlK6CsvCjN\n\tCA9qrAx04CiqcCmjHXSn2CQBL0scipO3aB0+t0sGRPtLA8vIct3aKxdysyiMCDq8Qj\n\tB3wEp+SvoJ43L9evG8W3HWk4wF4gT0BCCxsxRgxw=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 3 Jul 2019 02:29:54 +0300", "Message-Id": "<20190702232954.27816-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190702232954.27816-1-laurent.pinchart@ideasonboard.com>", "References": "<20190702232954.27816-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] camera: Enable libcamera logging to\n\t/var/log/camera", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 02 Jul 2019 23:30:21 -0000" }, "content": "Allow write access to /var/log/camera/ and set the libcamera logging\nenvironment variables to configure logging to\n/var/log/camera/libcamera.log. This requires creating a /var/log/camera/\ndirectory with write access for the arc-camera user.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n camera/hal_adapter/init/cros-camera.conf | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/camera/hal_adapter/init/cros-camera.conf b/camera/hal_adapter/init/cros-camera.conf\nindex e73b01da6610..58dd13f0feb8 100644\n--- a/camera/hal_adapter/init/cros-camera.conf\n+++ b/camera/hal_adapter/init/cros-camera.conf\n@@ -11,6 +11,8 @@ expect fork\n respawn\n respawn limit 5 30\n \n+env LIBCAMERA_LOG_FILE=/var/log/camera/libcamera.log\n+env LIBCAMERA_LOG_LEVELS=0\n env SECCOMP_POLICY_FILE=/usr/share/policy/cros-camera.policy\n env UVC_HWTIMESTAMPS_FILE=/sys/module/uvcvideo/parameters/hwtimestamps\n env UVC_CLOCK_FILE=/sys/module/uvcvideo/parameters/clock\n@@ -61,6 +63,7 @@ exec minijail0 -i -u arc-camera -g arc-camera -G \\\n -k 'tmpfs,/run,tmpfs,MS_NOSUID|MS_NODEV|MS_NOEXEC' \\\n -b /run/camera,,1 -b /run/systemd/journal -b /run/udev/data \\\n -b /var/lib/metrics,,1 \\\n+ -b /var/log/camera,,1 \\\n -R 13,40,40 \\\n -n -S \"${SECCOMP_POLICY_FILE}\" \\\n -- /usr/bin/cros_camera_service\n", "prefixes": [ "libcamera-devel", "2/2" ] }