Patch Detail
Show a patch.
GET /api/patches/15861/?format=api
{ "id": 15861, "url": "https://patchwork.libcamera.org/api/patches/15861/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15861/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220510115147.19360-22-laurent.pinchart@ideasonboard.com>", "date": "2022-05-10T11:51:18", "name": "[libcamera-devel,21/50] staging: media: imx: imx7-media-csi: Don't initialize unused fields", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "d55373e35f27f5601d08727e89b7936756cebc55", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15861/mbox/", "series": [ { "id": 3106, "url": "https://patchwork.libcamera.org/api/series/3106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3106", "date": "2022-05-10T11:50:57", "name": "staging: media: imx: Prepare destaging of imx7-media-csi", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15861/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15861/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 220D0C326D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 11:52:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6A5D65662;\n\tTue, 10 May 2022 13:52:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 160D565657\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 13:52:15 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B984B9A;\n\tTue, 10 May 2022 13:52:14 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183544;\n\tbh=R6JzINy4gD6TovfrdcP/5VdD1wSGdqHELXNnBkONj8c=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZZLyRJ9KK45A+VjYMwz4KHW/RX08wJdzCeeL29H90sfIr6ZgMirMaF4wu3vrGIr6r\n\t+mXcd8xngbK6OfP1vyY155WtiVIp/cX9TVR7nyXCWBfHPdo1MICDDI3UGrtIrVCxiO\n\trxXJ4LRD8SQGzIuwDcXVEwyVySsI8G4mlxbz5x4SBEiRlAhj0zOb5ImI2qYPNJyAj7\n\tlj4DQEY1qnMK5DeTZpDkdiAVjJwrCgbbu+4DJQFDg+y3/wRLkBxs4lnAc3WAm/chFn\n\tiiyv9fLqxOdeWRAUuE2o9YVr6zSPVqO7K+P8adlbGggFidtfSuMlS5tcIWqhqUCF5k\n\tIMc5rX8ta63bQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183534;\n\tbh=R6JzINy4gD6TovfrdcP/5VdD1wSGdqHELXNnBkONj8c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jGakV36xfs98cH7SaRJFTMQxLMeDKH1ao8k9mZ0ozBZlTYYnm3DKxtKhpnKdLIEeh\n\tUz84ZYrzL/pr4QZFhI/FSz/nAdofxekGFuhH6pNR53d2Vfy1/1SJ4rG75Z2waJ96LT\n\tUS5MVsKUpzEBY3d2pZ3i9vcHwR74JBkxTc4NAqE8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jGakV36x\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 May 2022 14:51:18 +0300", "Message-Id": "<20220510115147.19360-22-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "References": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 21/50] staging: media: imx:\n\timx7-media-csi: Don't initialize unused fields", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Martin Kepplinger <martin.kepplinger@puri.sm>, kernel@pengutronix.de,\n\tDorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tAlexander Stein <alexander.stein@ew.tq-group.com>,\n\tRui Miguel Silva <rmfrfs@gmail.com>,\n\tPhilipp Zabel <p.zabel@pengutronix.de>, \n\tSteve Longerbeam <slongerbeam@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The imx_media_dev structure contains three fields that are not used by\nthis driver or any helper code that it calls. Don't initialize them.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n drivers/staging/media/imx/imx7-media-csi.c | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex b6643952da25..7e932884fd02 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -1821,8 +1821,6 @@ static int imx7_csi_media_dev_init(struct imx7_csi *csi)\n \timxmd->md.ops = &imx7_csi_media_ops;\n \timxmd->md.dev = csi->dev;\n \n-\tmutex_init(&imxmd->mutex);\n-\n \timxmd->v4l2_dev.mdev = &imxmd->md;\n \tstrscpy(imxmd->v4l2_dev.name, \"imx-media\",\n \t\tsizeof(imxmd->v4l2_dev.name));\n@@ -1838,10 +1836,6 @@ static int imx7_csi_media_dev_init(struct imx7_csi *csi)\n \t\tgoto cleanup;\n \t}\n \n-\tINIT_LIST_HEAD(&imxmd->vdev_list);\n-\n-\tv4l2_async_nf_init(&imxmd->notifier);\n-\n \treturn 0;\n \n cleanup:\n", "prefixes": [ "libcamera-devel", "21/50" ] }