Patch Detail
Show a patch.
GET /api/patches/15775/?format=api
{ "id": 15775, "url": "https://patchwork.libcamera.org/api/patches/15775/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15775/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220504132154.9681-3-laurent.pinchart@ideasonboard.com>", "date": "2022-05-04T13:21:51", "name": "[libcamera-devel,2/5] libcamera: pipeline: simple: Document the pipeline traversal algorithm", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "342f61e178bf2e26814da66bedcc6eee992a4e20", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15775/mbox/", "series": [ { "id": 3090, "url": "https://patchwork.libcamera.org/api/series/3090/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3090", "date": "2022-05-04T13:21:49", "name": "libcamera: pipeline: simple: Support scaling on the camea sensor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3090/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15775/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15775/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4EE0C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 May 2022 13:22:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD82D6564C;\n\tWed, 4 May 2022 15:22:02 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59FE865641\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 May 2022 15:22:00 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00EF04A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 May 2022 15:21:59 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651670522;\n\tbh=n9gj6BTLGz9tumldNX/3y542S1gieNsp30b0qPBm8P4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=o+hC1VlS8XAhU0LfC/EbugqU+k4DalpmS1ZAqWOlozYw7BjZgS0Zz4Szp8jqmCX7F\n\ts1AnJtLaHxd9+q+5BWqffxS66Deb+N9fDdGyWwYXys0sQ0x/4DqOlU94tzKxhJDddX\n\t9Pn1o1SAtvX8uf7XaKaDlfVI/bHiBNDyGhjB6T2WGshFZj/jtDQdvbviXQFW1P8g6v\n\t102qnUSn05qPQ9yTd6oLiRbCGmnGZcq8QqSO/iWgwXOnjBQvALjzatJ6v0Gpl2Yn31\n\tkMeR9b2XHEZWMUFPaO/meWS+OCTcbPRXvhwy0qfNbknov4FJcWIi5kN0OUi5FPX1pL\n\tbFQ2+0cPTPdnw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651670520;\n\tbh=n9gj6BTLGz9tumldNX/3y542S1gieNsp30b0qPBm8P4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=NyQm/TS1SNevCv1IwFc/xbN+yVJu24sZRF2L09OCV0u6z24MraZdr+ML+0I//WSF9\n\tcuVTfm6YKamvXISntSQOnvMe1uGe+mybjXdkBMl2JZvBKou33fqd0d8MfuS29qm/Hi\n\tl4pYNKqyztNjzsEimYW3FqKTmuhwRYbZrC9/Oifo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NyQm/TS1\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 May 2022 16:21:51 +0300", "Message-Id": "<20220504132154.9681-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220504132154.9681-1-laurent.pinchart@ideasonboard.com>", "References": "<20220504132154.9681-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/5] libcamera: pipeline: simple: Document\n\tthe pipeline traversal algorithm", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a section to the documentation at the top of the file to describe in\na bit more details how the media graph is traversed.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 22efc8f498dc..4f963df16315 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -95,6 +95,21 @@ LOG_DEFINE_CATEGORY(SimplePipeline)\n * valid pipeline configurations are found, a Camera is registered for the\n * SimpleCameraData instance.\n *\n+ * Pipeline Traversal\n+ * ------------------\n+ *\n+ * During the breadth-first search, the pipeline is traversed from entity to\n+ * entity, by following media graph links from source to sink, starting at the\n+ * camera sensor. When reaching an entity (on its sink side), all its source\n+ * pads are considered to continue the graph traversal.\n+ *\n+ * The shortest path between the camera sensor and a video node is stored in\n+ * SimpleCameraData::entities_ as a list of SimpleCameraData::Entity structures,\n+ * ordered along the data path from the camera sensor to the video node. The\n+ * Entity structure stores a pointer to the MediaEntity, as well as information\n+ * about how it is connected in that particular path for later usage when\n+ * configuring the pipeline.\n+ *\n * Pipeline Configuration\n * ----------------------\n *\n", "prefixes": [ "libcamera-devel", "2/5" ] }