Patch Detail
Show a patch.
GET /api/patches/15695/?format=api
{ "id": 15695, "url": "https://patchwork.libcamera.org/api/patches/15695/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15695/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220421072848.6752-4-hpa@redhat.com>", "date": "2022-04-21T07:28:47", "name": "[libcamera-devel,RFC,v2,3/4] libcamera: pipeline: ipu3: Get and set VCM information", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "804d3e48d0a49c2c7b318b827f6e9571b9d052ea", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15695/mbox/", "series": [ { "id": 3062, "url": "https://patchwork.libcamera.org/api/series/3062/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3062", "date": "2022-04-21T07:28:44", "name": "Enabling AF algorithm to get the VCM attributes from the device driver", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3062/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15695/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15695/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A9EAC0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Apr 2022 07:29:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 399EC65643;\n\tThu, 21 Apr 2022 09:29:25 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93D63604AD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Apr 2022 09:29:23 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n\t[66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-652-cVr4P0diMqySHuSU_GuLPQ-1; Thu, 21 Apr 2022 03:29:14 -0400", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id F23202805339\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Apr 2022 07:29:13 +0000 (UTC)", "from fedora.redhat.com (unknown [10.39.194.88])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0C806C33AE9;\n\tThu, 21 Apr 2022 07:29:11 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650526165;\n\tbh=3brjNfEMVi4fNBM+q1GgveHOZLC3tl5UCUiJR9RL4Kk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=iQQ6OMfV9G8EOJ58r2I2VAPPkMgANbvZiEX1413ZGBL4AN0tgc+U3E397zo7hARGU\n\tEOhB0Mt6Y4BaauU1jHcm6ulNRyihzl3ICfRLGMI/gCpK2bfO0D1vsw+l2gE5KBwLzP\n\t4L8TBNBY0oOD3lGZnyJlTlDv6YS9ciOZnsw5QAz2LmoEHQMvzJmUTGnBkIXPzmWR3f\n\tmqI/ll826nZrU0xHc5ev4s43ApZ+g1YBWQSpcPVv7EpadbuWTTMf4Ohn55DeuOpyJk\n\tmBQJL1p7DeMY3F0mBKQ0xP8x/w/YhYHubaCnVG2uyu4facZjOD0gIOGdvnbf9syYM0\n\tU/rAG4bI0yXXA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1650526162;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=fjliiKMSaNBSJfgiA+GlP4iuFlsmfUhgwA7sTtmmodQ=;\n\tb=bWURX8fbgicwyE7DqFlENqYi0QIN395ie+OWWySXACNhjTaQiMQY8DeHxXFxvTKCuiwSit\n\tfK1a9Cfr4olgL02H60cQFlfguMlRgPpPUzr1Qh9T3r7jzSoks7WoLA43fZ84v0QMGTsHS1\n\tkmrlZAYN0Pla5lTdG9MaPFShkGt5ve8=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"bWURX8fb\"; \n\tdkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hpa@redhat.com" ], "X-MC-Unique": "cVr4P0diMqySHuSU_GuLPQ-1", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 21 Apr 2022 15:28:47 +0800", "Message-Id": "<20220421072848.6752-4-hpa@redhat.com>", "In-Reply-To": "<20220421072848.6752-1-hpa@redhat.com>", "References": "<20220421072848.6752-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.8", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "Subject": "[libcamera-devel] [RFC PATCH v2 3/4] libcamera: pipeline: ipu3: Get\n\tand set VCM information", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kate Hsuan via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Kate Hsuan <hpa@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It is an interface of CameraData to get the VCM steps. Also, the VCM step\nvalue is stored in ConfigInfo.\n\nSigned-off-by: Kate Hsuan<hpa@redhat.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex fd989e61..d1a1d21c 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -86,6 +86,8 @@ public:\n \n \tControlInfoMap ipaControls_;\n \n+\tint getMaxLensSteps();\n+\n private:\n \tvoid metadataReady(unsigned int id, const ControlList &metadata);\n \tvoid paramsBufferReady(unsigned int id);\n@@ -667,6 +669,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \tCameraLens *lens = data->cio2_.sensor()->focusLens();\n \tif (lens)\n \t\tconfigInfo.lensControls = lens->controls();\n+\tsensorInfo.maxVcmSteps = data->getMaxLensSteps();\n \n \tconfigInfo.sensorInfo = sensorInfo;\n \tconfigInfo.bdsOutputSize = config->imguConfig().bds;\n@@ -1272,6 +1275,18 @@ void IPU3CameraData::setSensorControls([[maybe_unused]] unsigned int id,\n \tfocusLens->setFocusPosition(focusValue.get<int32_t>());\n }\n \n+int IPU3CameraData::getMaxLensSteps()\n+{\n+\tint ret = 0;\n+\n+\tCameraLens *focusLens = cio2_.sensor()->focusLens();\n+\tif (!focusLens)\n+\t\treturn 0;\n+\n+\tret = focusLens->getMaxFocusStep();\n+\treturn ret;\n+}\n+\n void IPU3CameraData::paramsBufferReady(unsigned int id)\n {\n \tIPU3Frames::Info *info = frameInfos_.find(id);\n", "prefixes": [ "libcamera-devel", "RFC", "v2", "3/4" ] }