Patch Detail
Show a patch.
GET /api/patches/15675/?format=api
{ "id": 15675, "url": "https://patchwork.libcamera.org/api/patches/15675/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15675/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220414074342.7455-5-hpa@redhat.com>", "date": "2022-04-14T07:43:41", "name": "[libcamera-devel,RFC,v1,4/5] libcamera: pipeline: ipu3: Get VCM information", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5c42efe4f32b7fb1875620f1d6d5673c1985eb0a", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15675/mbox/", "series": [ { "id": 3052, "url": "https://patchwork.libcamera.org/api/series/3052/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3052", "date": "2022-04-14T07:43:37", "name": "Enabling AF algorithm to get the VCM attributes from the device driver", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3052/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15675/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15675/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DD55C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 14 Apr 2022 07:44:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D58CC65646;\n\tThu, 14 Apr 2022 09:44:24 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C361604B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Apr 2022 09:44:23 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n\t[66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-345-i0Ky0PrgMuSKBDcFyNuPEQ-1; Thu, 14 Apr 2022 03:44:21 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA6DB3C11C73\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Apr 2022 07:44:20 +0000 (UTC)", "from fedora.rhtw.internal (unknown [10.39.193.169])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2D16E111D3CC;\n\tThu, 14 Apr 2022 07:44:18 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649922264;\n\tbh=l4XnZBrTsOrJDZqmr7XhZrNOHW0j4uiGQmJ0T/jtQQY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qUNG539M4IQbOCM841EFAfUF5heWN0nbg4Og5ZaIULi6Cw+jKY/VfxL595AQqjZV0\n\tQ7W041smQAYWH1UGaqj6B88IukRkYEmfmAU+Un3SGvNQD5ah/+iN9OQIK8r09nupng\n\tXoWCkbW2mCVChcEKEc/V37v9RT7+pZFQynCCgaIdg3Nxyf9sSKNstF+rhK4jVMQAaK\n\tLru4+OgFHL6LdTX3qByodMY/cTiQcaPWsXorXSRBZ/+8Qdr/GVIzcQD0qakdAI43LT\n\tY0jm4A1Oa2UAW7w2sJyvnmCqFuql0c17Qgw7Zi50ahw0iOeO0zFAJPiT6VGg+ct5kZ\n\tfhO2ASOXxZtMg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1649922262;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=kx0RgqLy/pWaTJbhrBn1BMiLaOpK1EP6tVd6cMmj48Y=;\n\tb=AQm/irHQuUwziuK5ML2mb2YawmRQvpVIzoWc6Yb3V9OG5lkQnYBGVYqwYAKmoIaHkV60Ek\n\tqpqfHhR+pt/ww+sVgAdfN5NhSt8YBekDiSvEp7Wxx3gvKZ0eqRBb7i8NSZ57QySSUmg/s+\n\tQfdSpqZXBdqcQTiRtNC7B5I0oCh5IcI=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"AQm/irHQ\"; \n\tdkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hpa@redhat.com" ], "X-MC-Unique": "i0Ky0PrgMuSKBDcFyNuPEQ-1", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 14 Apr 2022 15:43:41 +0800", "Message-Id": "<20220414074342.7455-5-hpa@redhat.com>", "In-Reply-To": "<20220414074342.7455-1-hpa@redhat.com>", "References": "<20220414074342.7455-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "Subject": "[libcamera-devel] [RFC v1 4/5] libcamera: pipeline: ipu3: Get VCM\n\tinformation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kate Hsuan via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Kate Hsuan <hpa@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It is an interface of CameraData to get the VCM steps. Also, the VCM step\nvalue is stored in ConfigInfo.\n\nSigned-off-by: Kate Hsuan<hpa@redhat.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 9f113171..9cc12e4c 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -85,6 +85,8 @@ public:\n \n \tControlInfoMap ipaControls_;\n \n+\tint getSensorControls();\n+\n private:\n \tvoid metadataReady(unsigned int id, const ControlList &metadata);\n \tvoid paramsBufferReady(unsigned int id);\n@@ -670,6 +672,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \tconfigInfo.sensorInfo = sensorInfo;\n \tconfigInfo.bdsOutputSize = config->imguConfig().bds;\n \tconfigInfo.iif = config->imguConfig().iif;\n+\tconfigInfo.sensorInfo.maxVcmSteps = data->getSensorControls();\n \n \tret = data->ipa_->configure(configInfo, &data->ipaControls_);\n \tif (ret) {\n@@ -1271,6 +1274,18 @@ void IPU3CameraData::setSensorControls([[maybe_unused]] unsigned int id,\n \tfocusLens->setFocusPosition(focusValue.get<int32_t>());\n }\n \n+int IPU3CameraData::getSensorControls()\n+{\n+\tint ret = 0;\n+\n+\tCameraLens *focusLens = cio2_.sensor()->focusLens();\n+\tif (!focusLens)\n+\t\treturn 0;\n+\n+\tret = focusLens->getFocusCapabilityies();\n+\treturn ret;\n+}\n+\n void IPU3CameraData::paramsBufferReady(unsigned int id)\n {\n \tIPU3Frames::Info *info = frameInfos_.find(id);\n", "prefixes": [ "libcamera-devel", "RFC", "v1", "4/5" ] }