Patch Detail
Show a patch.
GET /api/patches/15653/?format=api
{ "id": 15653, "url": "https://patchwork.libcamera.org/api/patches/15653/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15653/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220408014231.231083-2-Rauch.Christian@gmx.de>", "date": "2022-04-08T01:42:28", "name": "[libcamera-devel,v3,1/4] libcamera: controls: Define size of array controls as a shape vector", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e31b9dbd324d50218e82105b64f6aaaa23d22c05", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15653/mbox/", "series": [ { "id": 3045, "url": "https://patchwork.libcamera.org/api/series/3045/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3045", "date": "2022-04-08T01:42:28", "name": "generate and use fixed-sized Span Control types", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3045/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15653/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15653/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B538C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 8 Apr 2022 01:42:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7C416564C;\n\tFri, 8 Apr 2022 03:42:37 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FE6B65640\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 Apr 2022 03:42:35 +0200 (CEST)", "from localhost.localdomain ([92.10.251.63]) by mail.gmx.net\n\t(mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1MPGVx-1nLvbq00kv-00Phu2; Fri, 08 Apr 2022 03:42:35 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649382157;\n\tbh=JuVzSB5dB/GwkXEWP3cFR31HptSzBMeuKMg5Yu3wvVM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=W0DQ1Rwax/DJlUqt/LcEj1OGyQ3L6ErCfR+RqdcaMD2mxW2160yf+Fxa9WlAMzizo\n\tQirYdlbEDaujiABYdBol6qMKQXy1/vAhEAZ1bPtq9GmUfDdD3gJwpML07qC9xV8/6Z\n\t09yCPPk02kJx6ty5O4Vjdd1oMGvtdSujBM+IitgPfZ9u6t1jiGPbI+YeCq3Us68MKg\n\twhifBYxDYZSoQ7rmhepesOp03hGsr315TMsFpBUcW5ZIhknldFnU1dDFIJPR+G6JWu\n\tAMeOXQe3kn3o3RqDUQFYSCNqxtOjgwU0+kN/EySf4jbTRGzFKUV+FMyAERjq7xzCSF\n\tE1+BuXfzs6FtA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1649382155;\n\tbh=JuVzSB5dB/GwkXEWP3cFR31HptSzBMeuKMg5Yu3wvVM=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=IRAz6ke64AmY/u7RSXwIKAdsFwpB3Ed+3dDYYWnDr3haYvlUVCj3jQXq11oOaqqlf\n\tP/BPnviIKl20saDVRtuUVpOYthBUfZ4VCBf51akVCHCzgXX4MXejr/q0T1i8I48hNG\n\tOTYXADbnW4aiBJ9RLFDHARRb4Oh4NIQDcwJ6q9m4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"IRAz6ke6\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 8 Apr 2022 02:42:28 +0100", "Message-Id": "<20220408014231.231083-2-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220408014231.231083-1-Rauch.Christian@gmx.de>", "References": "<20220408014231.231083-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:7C/t91Wh8awYzE9Q+JBQjaRL8kV5YHU9oFbjukf8ZD/K0qVdfQk\n\tHq9uUAjWQ80SWl/kI0BQD91e8nA5fPs+PwQpzlJFGKMw3D7yGA+ivmQdii7G5P1LcsFyisH\n\tTUS3YAH2W+4zkQcuL+lGtcaKzuvgt8AvkGLErFaMzTGy4zxwoglb+m9u/UIItg33hGoTocO\n\tC8Mnr/Nbcxz63XYCOG+ow==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:JF2Mz7U4et0=:H4KsLwrARDRm0ik3NugqLF\n\teA0zcP5cIpSCX+Ii7L7truzh4WztUZgysdymk9nwboY5bpk1ZZ+xplikyu2rL2MoyRW4gu+7t\n\tSKBeP5YbAZuySpIZ11tGaqmiJ+tkE/upXu/sJIg1zsSd5nrGZMEKKMRU0dRNotNo/SbsZdenH\n\t2giB/Xa0H70gdjbv0+lKIdrVV6AZ5zkI03cro0rFgwixVQs4uG4z81i+cnNYRXi6wFKWCzpAr\n\taUO3CiyeViB6IBWrdIBK8xt8NpD77wm7WygYJS/3R30Hch6S/QTxvRsVbpR7eOW5cqhcWOA9O\n\t/O9mmxRompPW8g9sKLhYTe3422z8etif2nH8Aef2nGk6OLn1FQWzFX2nPTa65pnrbaxHusN80\n\tTLlQ1Ub9qCMNx7dLI5OJk19WNTVnRSg50z63HUp5LJtCHX+s2Qfcej6WKA9D3W/2x7fYe/iPV\n\tg/6A80xXa5PDRsKJ9x+kEcuDTV2AUpWZBRLb0nsAvzZB5/TGrLkrW6R6XMvYkgFyW19KwzJU4\n\tvWaiHai6BBZ3YpsfBycwaRIOE6HiQ8hleeeOGhkX0v1noAh1FF79R/K/NSMF3CBimvHCsh6aZ\n\tpIAp9pe/krm+FZuCy+ExaYzuYGdcn92rETvX6Slc6nHo40zNOSAXgLEQrmBsKLbAPHkLzndAE\n\tUO30f5YCT0drvFszmwyEhDKBTTLU0fw9wJ1rTME/Z1EnCyWulT1UBTrRcXWe81BYW3jE46TwL\n\t0kL3ZN4QRMpKdqrh5nP2o4FJDUAfev7EwarUHhqc7a1/UtHfICOKtPK8TC8+FUp5K8BXTIgTt\n\tIZq6AbszU2o4bpw01cxpIr5/BBq4+fITW8LGNHjFZ5Urj0ikTE1QtGPor0B/PBTFBTBz9o4M9\n\t/QiH27dVQvTimSRlTjGfs/4dosyQSG/txLv/VbyE1TWuSplLTD9UpJAdSX7ldFdEr9B96bqcV\n\tVDlhOtMQ5TqSf+iU3ogF1uMGL732KkX4ZXYmsRkxQNEIJ2dbJ4NFczZ1P1SfVOVpYVSg7bTf+\n\taTfPlhGFEUjA0fwWoehUlo3wmx+MwmPrl5chruwYflezLig/OJpdmE6XwLlxMuqvpIAbWpnGt\n\tGFj3BQ69RPXBPQ=", "Subject": "[libcamera-devel] [PATCH v3 1/4] libcamera: controls: Define size\n\tof array controls as a shape vector", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This follows the convention in other Tensor APIs. Since all tensors are\nrepresented as a Span with a single dimension, values provided in 'size'\nare interpreted as fixed-size Spans, while an empty array (\"[]\") will be\ninterpreted as variable-sized Span.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n src/libcamera/control_ids.yaml | 2 +-\n src/libcamera/property_ids.yaml | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)\n\n--\n2.25.1", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 9d4638ae..c3f593a1 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -291,7 +291,7 @@ controls:\n transformation. The 3x3 matrix is stored in conventional reading\n order in an array of 9 floating point values.\n\n- size: [3x3]\n+ size: [3,3]\n\n - ScalerCrop:\n type: Rectangle\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 12ecbce5..47c350ed 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -497,7 +497,7 @@ controls:\n\n - PixelArrayOpticalBlackRectangles:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The pixel array region(s) which contain optical black pixels\n considered valid for calibration purposes.\n@@ -592,7 +592,7 @@ controls:\n\n - PixelArrayActiveAreas:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The PixelArrayActiveAreas property defines the (possibly multiple and\n overlapping) portions of the camera sensor readable pixel matrix\n", "prefixes": [ "libcamera-devel", "v3", "1/4" ] }