Patch Detail
Show a patch.
GET /api/patches/15650/?format=api
{ "id": 15650, "url": "https://patchwork.libcamera.org/api/patches/15650/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15650/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220407132101.33140-1-ecurtin@redhat.com>", "date": "2022-04-07T13:21:00", "name": "[libcamera-devel,v6,1/2] cam: event_loop: Add timer events to event loop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "55187179c800df8834966e2c57deba402cfae887", "submitter": { "id": 101, "url": "https://patchwork.libcamera.org/api/people/101/?format=api", "name": "Eric Curtin", "email": "ecurtin@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15650/mbox/", "series": [ { "id": 3043, "url": "https://patchwork.libcamera.org/api/series/3043/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3043", "date": "2022-04-07T13:21:00", "name": "[libcamera-devel,v6,1/2] cam: event_loop: Add timer events to event loop", "version": 6, "mbox": "https://patchwork.libcamera.org/series/3043/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15650/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15650/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48836C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Apr 2022 13:21:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F64965642;\n\tThu, 7 Apr 2022 15:21:17 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5C956563F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Apr 2022 15:21:15 +0200 (CEST)", "from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-489--yYrI10mMcGE8DDfRK708A-1; Thu, 07 Apr 2022 09:21:13 -0400", "by mail-wm1-f69.google.com with SMTP id\n\th205-20020a1c21d6000000b0038e9ce3b29cso14906wmh.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 07 Apr 2022 06:21:13 -0700 (PDT)", "from p1.Home ([2001:8a0:6724:4500:a69c:e66f:828e:b340])\n\tby smtp.gmail.com with ESMTPSA id\n\tm18-20020a05600c4f5200b0038e8f9d7b57sm1789575wmq.42.2022.04.07.06.21.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 07 Apr 2022 06:21:11 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649337677;\n\tbh=39TTu31F6IWn1IhidMb9LjoGbN7uxwMkGvIwOoAYiSg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Omd57hxfOcwsIhXuACqf4aSiwqNrUciq79IzsuUrNdggWLH6lMbmm+lFcIq/XTvyl\n\tlOLQ3gObHM+avm/AGMQ53xxb/4uMJuGukOVr3Z+KmLrK3hGykppac2FzMohd2vVygx\n\tnw45rooxIN5Fm5CuPeBPhW77xNI5aKO2uUZHTJecNwKSRoxS8RQozCvOyVpMBFUpn8\n\tMnupNpF7huVHkSxs3Ekz0Jy3EFu+Ov0f92saO3CJpVxF518EI5Gbzn2B6Pncj/vID7\n\tjQdYYP/WYdbPzt31ydSVNzG9g0ZQkgrSeeytWOokXWI682Emm5FPUOpNWr4KVdEunJ\n\tJ+r2M4882JgIA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1649337674;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=uUzjs17hCGVsCj1b3oArrT45VOxKw8/vUjWEopdaK+0=;\n\tb=NdMNBiaWnQfnj6pGhc9Kyn7/kXUPAaYBXv2MtJZDmH6Dd7TuXKfmRrDz/fx/TEpWjMONA/\n\tcKvcwB/8y8f1xUOWMp4pf9W60UOMwhluG5k+ONNra75z9UeTZ0Qd4nqmmhpxU6bkDU8YgZ\n\tvZb2KSJkZYXN3QcMn/5sTgxjXN9/EnQ=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"NdMNBiaW\"; \n\tdkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com" ], "X-MC-Unique": "-yYrI10mMcGE8DDfRK708A-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=uUzjs17hCGVsCj1b3oArrT45VOxKw8/vUjWEopdaK+0=;\n\tb=O73PkservewG7Ka4GPmuC1BtXupE5cQ7A+2J9W2PWLBJrhikKrwXZBR3rQyGK81KlX\n\tGHQQvhjlSTbvKWj1S5dvItV9tkQQSMTIlL7uAwlKDJTAmmTCwqFW23AvgPdWHJWhyhrs\n\tcS0cVJNAzm9SgQ/X3FF2Fv3nlnBXTo9ErM7RKIXbPP3rWaAp0BHnr+s1tAz7wxyFy8J+\n\txeYDve/y2KVCtWIsXXrrfyk3FzZqlhlUAAB6WfNiUYGj4OwOTv3L5D7J+SY42QNk9Wvs\n\tJtR/Y+dq6baATKh3OvRrIDbb0YmMHFrDi5OQCu02bl1cm1Ukqihy0SaSoYqoa7coHAYY\n\tzVXQ==", "X-Gm-Message-State": "AOAM533D4x+H7dNwe/3vQCUUEDa18zQv2jvAkTdTY28OqNNABl+veLfc\n\tUt4p2OkZ++eSBi7MQpfeWsXVg8wxDBMyR+v82unA8di7d6yyb8a3cpx2jqtrw2XvdaknIwU+K05\n\tq9xybBUrlLY6Ll0LyQhGhrY+UUwJYt2BgNvqFcTYtlNozXIGiUUe5l7G4i+RIuXgC1/A/BlwEg8\n\t46L7suMGPY", "X-Received": [ "by 2002:a1c:4e01:0:b0:38c:b316:e6f5 with SMTP id\n\tg1-20020a1c4e01000000b0038cb316e6f5mr12266347wmh.93.1649337671795; \n\tThu, 07 Apr 2022 06:21:11 -0700 (PDT)", "by 2002:a1c:4e01:0:b0:38c:b316:e6f5 with SMTP id\n\tg1-20020a1c4e01000000b0038cb316e6f5mr12266324wmh.93.1649337671510; \n\tThu, 07 Apr 2022 06:21:11 -0700 (PDT)" ], "X-Google-Smtp-Source": "ABdhPJxH926Wj30IKvetJ2aOlDGuY6rj0ANy/+bhERg+DvKdHrUWsyzjTmsx/D9nxFdgrZBA0DkKZQ==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 7 Apr 2022 14:21:00 +0100", "Message-Id": "<20220407132101.33140-1-ecurtin@redhat.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "Subject": "[libcamera-devel] [PATCH v6 1/2] cam: event_loop: Add timer events\n\tto event loop", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Eric Curtin via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Eric Curtin <ecurtin@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Extend the EventLoop class to support periodic timer events. This can be\nused to run tasks periodically, such as handling the event loop of SDL.\n\nSigned-off-by: Eric Curtin <ecurtin@redhat.com>\n---\n src/cam/event_loop.cpp | 37 +++++++++++++++++++++++++++++++++----\n src/cam/event_loop.h | 3 +++\n 2 files changed, 36 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/cam/event_loop.cpp b/src/cam/event_loop.cpp\nindex e25784c0..1e1a4269 100644\n--- a/src/cam/event_loop.cpp\n+++ b/src/cam/event_loop.cpp\n@@ -60,6 +60,17 @@ void EventLoop::callLater(const std::function<void()> &func)\n \tevent_base_once(base_, -1, EV_TIMEOUT, dispatchCallback, this, nullptr);\n }\n \n+int EventLoop::eventNew(const std::unique_ptr<Event> &event, const int fd, const short events)\n+{\n+\tevent->event_ = event_new(base_, fd, events, &EventLoop::Event::dispatch, event.get());\n+\tif (!event->event_) {\n+\t\tstd::cerr << \"Failed to create event for fd \" << fd << std::endl;\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n void EventLoop::addEvent(int fd, EventType type,\n \t\t\t const std::function<void()> &callback)\n {\n@@ -68,10 +79,7 @@ void EventLoop::addEvent(int fd, EventType type,\n \t\t | (type & Write ? EV_WRITE : 0)\n \t\t | EV_PERSIST;\n \n-\tevent->event_ = event_new(base_, fd, events, &EventLoop::Event::dispatch,\n-\t\t\t\t event.get());\n-\tif (!event->event_) {\n-\t\tstd::cerr << \"Failed to create event for fd \" << fd << std::endl;\n+\tif (eventNew(event, fd, events)) {\n \t\treturn;\n \t}\n \n@@ -84,6 +92,27 @@ void EventLoop::addEvent(int fd, EventType type,\n \tevents_.push_back(std::move(event));\n }\n \n+void EventLoop::addTimerEvent(const suseconds_t period,\n+\t\t\t const std::function<void()> &callback)\n+{\n+\tstd::unique_ptr<Event> event = std::make_unique<Event>(callback);\n+\tif (eventNew(event, -1, EV_PERSIST)) {\n+\t\treturn;\n+\t}\n+\n+\tstruct timeval tv;\n+\ttv.tv_sec = 0;\n+\ttv.tv_usec = period;\n+\n+\tint ret = event_add(event->event_, &tv);\n+\tif (ret < 0) {\n+\t\tstd::cerr << \"Failed to add timer event\" << std::endl;\n+\t\treturn;\n+\t}\n+\n+\tevents_.push_back(std::move(event));\n+}\n+\n void EventLoop::dispatchCallback([[maybe_unused]] evutil_socket_t fd,\n \t\t\t\t [[maybe_unused]] short flags, void *param)\n {\ndiff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\nindex a4613eb2..3d3561e5 100644\n--- a/src/cam/event_loop.h\n+++ b/src/cam/event_loop.h\n@@ -36,6 +36,8 @@ public:\n \n \tvoid addEvent(int fd, EventType type,\n \t\t const std::function<void()> &handler);\n+\tvoid addTimerEvent(const suseconds_t period,\n+\t\t\t const std::function<void()> &handler);\n \n private:\n \tstruct Event {\n@@ -60,4 +62,5 @@ private:\n \tstatic void dispatchCallback(evutil_socket_t fd, short flags,\n \t\t\t\t void *param);\n \tvoid dispatchCall();\n+\tint eventNew(const std::unique_ptr<Event> &event, const int fd, const short events);\n };\n", "prefixes": [ "libcamera-devel", "v6", "1/2" ] }