Patch Detail
Show a patch.
GET /api/patches/15642/?format=api
{ "id": 15642, "url": "https://patchwork.libcamera.org/api/patches/15642/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15642/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220406144553.193858-1-umang.jain@ideasonboard.com>", "date": "2022-04-06T14:45:53", "name": "[libcamera-devel] libcamera: v4l2_videodevice: Fix uninitialised watchdogDuration_", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3ccb067d442c9ce309c502f688fc3bda9e64f1dc", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15642/mbox/", "series": [ { "id": 3038, "url": "https://patchwork.libcamera.org/api/series/3038/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3038", "date": "2022-04-06T14:45:53", "name": "[libcamera-devel] libcamera: v4l2_videodevice: Fix uninitialised watchdogDuration_", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3038/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15642/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15642/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86CB4C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Apr 2022 14:46:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B91B6604B8;\n\tWed, 6 Apr 2022 16:46:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C000604B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Apr 2022 16:46:17 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [27.57.186.178])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9620B482;\n\tWed, 6 Apr 2022 16:46:15 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649256378;\n\tbh=2GLdwRRDEr3EGhd57YeOvNRoXZU6VmcG/1KUhHNUwHo=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=eJYSAgil0JBlITl2BQAOIHZ8lCGAdJE6xZs8YHKmPdnVzg9/dByCOUi6Bc9K6KRGu\n\t/qay/hbepFcao2PAMkvU78wCqYB7UVLzf3C2LqQq7qULv+CHpNi+VwJlID2aZoqs33\n\txmELFglgmD/bE0vflU+YawVJha6BI+REHZd3aADwjQSbyORB6dqpThRnhOKPxTxx7l\n\txLdKhHerCjP3ylUawIg+oOPX9XCuMQmX0eR8I5TFYVTwp4dJYQojL+XZ9sncafxigp\n\tuXysyj6X410RpDOcSjvRmpa48li3GUQAOJMKR9kOdWPfaqHgFYqJkg+M7SnR5AQ/MH\n\tfhcd7RB6HqYNQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649256376;\n\tbh=2GLdwRRDEr3EGhd57YeOvNRoXZU6VmcG/1KUhHNUwHo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=JCv76lzh/YMuunHvm5Dbd+Y9IMgUl1Wwy5Ui4eq4TT/Ue5dZFD5QBcRUZKMPXskIA\n\tXHOcRY3HTEOaD4hwELvYE1kCIvrKCIHqMCcAkmrHzlJEODFxGrZynL08KLfYnmZpDR\n\tLynaf3BVdCBZLpba7WwelIo+oeY0u+ZL3AgXVUpw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JCv76lzh\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Apr 2022 20:15:53 +0530", "Message-Id": "<20220406144553.193858-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Fix\n\tuninitialised watchdogDuration_", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Initialise the watchdogDuration_ member to 0ms before it is used\nin rest of the code base. Failing to do so, spews out log warnings\nregarding dequeue timer being expired.\n\nFixes: 16f3d2de50ff (\"libcamera: v4l2_videodevice: Add a dequeue timer\")\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 634ac4a5..8e0afffe 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -39,6 +39,8 @@\n \n namespace libcamera {\n \n+using namespace std::literals::chrono_literals;\n+\n LOG_DECLARE_CATEGORY(V4L2)\n \n /**\n@@ -520,7 +522,8 @@ const std::string V4L2DeviceFormat::toString() const\n */\n V4L2VideoDevice::V4L2VideoDevice(const std::string &deviceNode)\n \t: V4L2Device(deviceNode), formatInfo_(nullptr), cache_(nullptr),\n-\t fdBufferNotifier_(nullptr), state_(State::Stopped)\n+\t fdBufferNotifier_(nullptr), state_(State::Stopped),\n+\t watchdogDuration_(0ms)\n {\n \t/*\n \t * We default to an MMAP based CAPTURE video device, however this will\n", "prefixes": [ "libcamera-devel" ] }